Treeherder api needs versioning

RESOLVED FIXED

Status

P3
normal
RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: mdoglio, Assigned: mdoglio)

Tracking

Details

Attachments

(1 attachment)

46 bytes, text/x-github-pull-request
emorley
: review+
Details | Review | Splinter Review
(Assignee)

Description

4 years ago
This would allow us to deploy changes to the web api without closing the trees.
(Assignee)

Updated

4 years ago
Depends on: 1145712
Priority: -- → P3
(Assignee)

Comment 1

3 years ago
I'm going to base this implementation on django-oauth-toolkit, which the is recommended package to do oauth authentication with django-rest-framework http://www.django-rest-framework.org/api-guide/authentication/#django-oauth-toolkit
(Assignee)

Comment 2

3 years ago
Oops wrong bug
(Assignee)

Updated

3 years ago
Blocks: 1178641
(Assignee)

Comment 3

3 years ago
Created attachment 8637342 [details] [review]
PR 800
Assignee: nobody → mdoglio
Status: NEW → ASSIGNED
Attachment #8637342 - Flags: review?(emorley)
Comment on attachment 8637342 [details] [review]
PR 800

Awesome, thank you! :-)
Attachment #8637342 - Flags: review?(emorley) → review+
Meant to say, if we ever use anything other than the header based versioning, we'll need to start passing the request argument in reverse() calls, but for now this is fine :-)
(Assignee)

Updated

3 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Once the nodejs client also requests a specific version in the Accepts header, and all submitters have updated to a newer python/node client, do we want to enforce that an API version is specified is the content-type is not text/html? (ie not mandatory if the API is browsed to in the browser, but required otherwise)

Relatedly, should we support specifying the version in the URL for the browser use-case, or are we happy that the new headers features in the Firefox developer tools make this redundant? I'm leaning towards the latter.
You need to log in before you can comment on or make changes to this bug.