Closed
Bug 1145712
Opened 10 years ago
Closed 9 years ago
Upgrade django rest framework version to 3.1
Categories
(Tree Management :: Treeherder: API, defect, P3)
Tree Management
Treeherder: API
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mdoglio, Assigned: mdoglio)
References
Details
Attachments
(1 file)
There are some new features we could take advantage of in the 3.1 release, above all support for api versioning. See http://www.django-rest-framework.org/topics/3.1-announcement/ for a full list of changes
Updated•10 years ago
|
Updated•9 years ago
|
Priority: -- → P3
Assignee | ||
Comment 1•9 years ago
|
||
As a first step I'll update it to the latest 2.4.x release.
Comment 2•9 years ago
|
||
djangorestframework (Current: 2.4.5 Latest: 3.1.3 [wheel])
http://www.django-rest-framework.org/topics/release-notes/
http://www.django-rest-framework.org/topics/3.0-announcement/
http://www.django-rest-framework.org/topics/3.1-announcement/
The 3.0 announcement notes look like the ones we need to pay the most attention to:
"This release is incremental in nature. There are some breaking API changes, and upgrading will require you to read the release notes carefully, but the migration path should otherwise be relatively straightforward."
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → mdoglio
Updated•9 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 3•9 years ago
|
||
Attachment #8632198 -
Flags: review?(emorley)
Updated•9 years ago
|
Attachment #8632198 -
Flags: review?(emorley) → review+
Comment 4•9 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder
https://github.com/mozilla/treeherder/commit/3f34e5da134909b3eb12769e4dad525e59b429db
Bug 1145712 - upgrade django-rest-framework from 2.4.5 to 3.1.3
This patch upgrades the version stored in the requirements file and fixes some issues introduced by breaking changes in the new version of the library:
- Writable nested fields are not available anymore, you need an explicit create method on the serializer to write a nested field.
- ModelViewSet now requires serializer_class and queryset attributes.
- @action and @link decorators are now replaced by either @detail_route or @list_route.
- any attempt to create a ModelSerializer instance with an attribute which type is either dict or list will raise an exception.
Assignee | ||
Updated•9 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•