114630 - After changing font, can't close prefs

Status: VERIFIED FIXED

(SeaMonkey :: Preferences, defect, P1)

Description

[Alexander Skwar]

Using build 2001121106 on Linux.

When I change a font in the preferences and click on the Ok button, the
preferences do not close.  Instead I have to click on Ok, followed by Cancel to
make sure that the prefs are stored and to close the preferences dialog.

Comment 1

[R.K.Aa.]

saw this yesterday too. Don't even have to change any prefs: selecting the font
pane is enough: Once selected, OK button doesn't work.

Added comment about this and the js warnings in
http://bugzilla.mozilla.org/show_bug.cgi?id=108939#c35

Resolving as new, regression keyw.

Comment 2

[Alexander Skwar]

Ah, yes, I thought that I read the bug already somewhere.

However, I do not get any output on the xterm.  I started mozilla with:
"~/mozilla/mozilla".

Comment 3

[R.K.Aa.]

*** Bug 114669 has been marked as a duplicate of this bug. ***

Comment 4

[Alexander Skwar]

Hmm, thinking about it... Does anyone think that Bug 114640 might be related to
this?

Comment 5

[Samir Gehani]

Attachment: Add back one line of code whose removal caused this regression.

Comment 6

[Samir Gehani]

morse, please r.
blake, please sr.

I'd really like to get this in for mozilla0.9.7.  Previous regressions in
mozilla0.9.6 of similar nature caused a barage of bugmail and I'd like to save
us all the energy this time around.  

Comment 7

[Blake Ross]

Hold on...I added that typeof() line originally, but only because I couldn't 
figure out what was going on. It's bogus. I have a better idea now.

Comment 8

[Stephen P. Morse]

Comment on attachment 61360 [details] [diff] [review]
Add back one line of code whose removal caused this regression.

r=morse
If Blake has a better idea, then let's hear it.  Otherwise this should go in as
is for 0.9.7.

Comment 9

[Samir Gehani]

OK, then over to Blake.  Please fix this in mozilla0.9.7.  If you can't get to
it then please sr this patch ((61360) which I've marked obsolete for now) so I
can check it into mozilla0.9.7 to prevent the plentitude of bugmail.  Thanks.  

Steve, thanks for the review.

Comment 10

[Blake Ross]

I meant "I have a better idea of what's going on".  But, in fact, this patch 
may be just fine.  The problem is that the fonts panel has a GetFields function 
which adds additional attributes to the data object, and it's confusing us 
because we're treating them as elements.

Comment 11

[Samir Gehani]

Blake,
Cool, so could you gimme an sr then?  Thanks.

Comment 12

[Blake Ross]

Comment on attachment 61360 [details] [diff] [review]
Add back one line of code whose removal caused this regression.

sr=blake, sorry for delay

Comment 13

[Samir Gehani]

Checked in.

Comment 14

[R.K.Aa.]

*** Bug 114871 has been marked as a duplicate of this bug. ***

Comment 15

[Alexander Skwar]

With 2001121208 on Linux, this bug (and also bug 114640) is fixed.

Comment 16

[sairuh (rarely reading bugmail)]

no longer a problem. vrfy'd fixed using 2002.01.07.0x comm bits on linux rh7.2,
winnt and mac 10.1.2.