1146692 - IE11 Popcorn demo has flashes of black when run.

Status: RESOLVED WORKSFORME

(Core :: Graphics, defect)

Description

[Gary [:streetwolf52]]

User Agent: Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:39.0) Gecko/20100101 Firefox/39.0
Build ID: 20150323103014

Steps to reproduce:

Go to http://ie.microsoft.com/testdrive/Performance/Popcorn/Default.html

Run the demos S, M, or L a few times.


Actual results:

Portions of the screen will flash black when run.  Usually on the bottom or top of the screen.


Expected results:

No black flashing.

Regression Range:

Good:  20150317193142
https://hg.mozilla.org/integration/mozilla-inbound/rev/e5a94f80f342

Bad:  20150317223048
https://hg.mozilla.org/integration/mozilla-inbound/rev/40dae5234a25

Comment 1

[Gary [:streetwolf52]]

Problem happens on AMD and nVidia cards.  Here's my specs:

Graphics
--------

Adapter Description: AMD Radeon HD 7900 Series
Adapter Drivers: aticfx64 aticfx64 aticfx64 aticfx32 aticfx32 aticfx32 atiumd64 atidxx64 atidxx64 atiumdag atidxx32 atidxx32 atiumdva atiumd6a atitmm64
Adapter RAM: 3072
ClearType Parameters: D [ Gamma: 2200 Pixel Structure: R ClearType Level: 100 Enhanced Contrast: 300 ] D [ Gamma: 2200 Pixel Structure: R ClearType Level: 50 Enhanced Contrast: 100 ]
Device ID: 0x6798
Direct2D Enabled: true
DirectWrite Enabled: true (6.3.9600.17415)
Driver Date: 3-18-2015
Driver Version: 14.502.1014.0
GPU #2 Active: false
GPU Accelerated Windows: 1/1 Direct3D 11 (OMTC)
Subsys ID: 00000000
Vendor ID: 0x1002
WebGL Renderer: Google Inc. -- ANGLE (AMD Radeon HD 7900 Series Direct3D11 vs_5_0 ps_5_0)
windowLayerManagerRemote: true
AzureCanvasBackend: direct2d 1.1
AzureContentBackend: direct2d 1.1
AzureFallbackCanvasBackend: cairo
AzureSkiaAccelerated: 0

Here's an Nvidia user with the same problem:

    Adapter Description   NVIDIA GeForce GTX 670
    Adapter Drivers   nvd3dumx,nvwgf2umx,nvwgf2umx nvd3dum,nvwgf2um,nvwgf2um
    Adapter RAM   2048
    Device ID   0x1189
    Direct2D Enabled   true
    DirectWrite Enabled   true (6.2.9200.16571)
    Driver Date   12-13-2014
    Driver Version   9.18.13.4709
    GPU #2 Active   false
    GPU Accelerated Windows   1/1 Direct3D 11 (OMTC)
    Subsys ID   11891569
    Vendor ID   0x10de
    WebGL Renderer   Google Inc. -- ANGLE (NVIDIA GeForce GTX 670 Direct3D11 vs_5_0 ps_5_0)
    windowLayerManagerRemote   true
    AzureCanvasBackend   direct2d 1.1
    AzureContentBackend   direct2d 1.1
    AzureFallbackCanvasBackend   cairo
    AzureSkiaAccelerated   0

Comment 2

[Gary [:streetwolf52]]

Problem happens under e10s and non-e10s.

Comment 3

[Jeff Muizelaar [:jrmuizel]]

Did you produce this regression window with mozregression? It would be nice to have a tighter range.

Comment 4

[Jeff Muizelaar [:jrmuizel]]

The current window: https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=e5a94f80f342&tochange=40dae5234a25

Comment 5

[Jeff Muizelaar [:jrmuizel]]

There are a bunch of build inbetween those two revisions. Can you try some of them (these are 32bit builds, I presume it reproduces there too):

http://inbound-archive.pub.build.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-inbound-win32/

	1426644398/			 
[DIR]	1426645958/			 
[DIR]	1426646200/			 
[DIR]	1426646498/			 
[DIR]	1426647522/			 
[DIR]	1426647578/			 
[DIR]	1426649930/			 
[DIR]	1426649979/			 
[DIR]	1426650458/			 
[DIR]	1426650762/			 
[DIR]	1426651239/			 
[DIR]	1426651660/

Comment 6

[Gary [:streetwolf52]]

Here's the culprit, makes sense.

  https://hg.mozilla.org/integration/mozilla-inbound/rev/d3380179efc1


Setting 'gfx.vsync.hw-vsync.enabled' to False stops the flashing.

Comment 7

[Gary [:streetwolf52]]

Did some more testing with the vsync prefs.  Seems that setting 'gfx.vsync.compositor' to false also stops the flashing.  As long as one of the prefs I mentioned is set to false there is no flashing.

Comment 8

[Gary [:streetwolf52]]

Don't know if it's related but Popcorn is much slower now no matter how I set the vsync prefs.

Comment 9

[Gary [:streetwolf52]]

(In reply to Gary [:streetwolf] from comment #8)
> Don't know if it's related but Popcorn is much slower now no matter how I
> set the vsync prefs.

Under e10s it is definitely very fast. Non-e10s it seems to have gotten slower.

Comment 10

[Mason Chang [Inactive] [:mchang]]

I can reproduce on Windows 7 and 8.

STR:
1) Go to http://ie.microsoft.com/testdrive/Performance/popcorn/
2) Push small on the bottom
3) Keep pushing play, see small flashes of black

Comment 11

[Gary [:streetwolf52]]

Can someone please change this to confirmed?

Comment 12

[Mason Chang [Inactive] [:mchang]]

I'm still kind of poking in the dark here but I have some notes:

1) Using software vsync instead of dwm composition to schedule composites can still cause the flashing to occur. It seems unrelated to using DwmFlush as a way to listen to vsync.
2) Forcing us to wait for vsync (https://dxr.mozilla.org/mozilla-central/source/gfx/layers/d3d11/CompositorD3D11.cpp?from=CompositorD3D11.cpp&case=true#1154) by changing the Present parameters doesn't change anything.
3) By disabling Dwm Composition as a Windows setting, minimizing and maximizing the window on this page specifically causes us to consistently flash the whole page black. Chrome and IE do not flash black when being minimized / maximized on this page. Firefox not does flash black on simpler pages such as reddit.
4) The places we flash black are the layers that are being invalidated during paint invalidation during the animation.
5) With the patches from bug 1145327, which ensure timestamps are always in the future, does not affect this bug but has caused weird animation problems before.

I'm wondering if we're invalidating layers black then dwm composites so we see the flash of black rather than this is a fundamental problem with the silk approach on windows of using Dwm composition.

Comment 13

[Mason Chang [Inactive] [:mchang]]

I verified that with the patch in bug 1145585, which showed the same symptoms of flashing black, this problem is fixed. Will leave open until bug 1145585 lands to get verification that this is fixed.

Comment 14

[Mason Chang [Inactive] [:mchang]]

I cannot reproduce on Windows 7 or 8 with today's nightly (3-27-2015). Gary, can you please test again and verify that this issue is resolved for you? Thanks!

Comment 15

[Gary [:streetwolf52]]

I can't reproduce it either.  Any idea what might have fixed it?

Comment 16

[Mason Chang [Inactive] [:mchang]]

bug 1145585 fixed it from comment 13. Resolving as WFM.