1147661 - Update "Send to devices" icons

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Overlays, defect)

Description

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Attachment: device_mob_PC.zip

Updating device icons from the old ones. They're really quite light ATM.

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: Screenshot

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: MozReview Request: bz://1147661/mcomella

/r/6149 - Bug 1147661 - Add new device assets. r=liuche
/r/6151 - Bug 1147661 - Use new device icons in share overlay. r=liuche

Pull down these commits:

hg pull review -r 056298dee4b10da39bdd05dee44d9da4f327074e

Comment 3

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Comment on attachment 8583916 [details]
Screenshot

Makes me happy :D

Comment 4

[Chenxia Liu [:liuche]]

https://reviewboard.mozilla.org/r/6151/#review5145

::: mobile/android/base/overlays/ui/SendTabDeviceListArrayAdapter.java
(Diff revision 1)
> -            return R.drawable.sync_mobile_inactive;
> +            return R.drawable.device_mobile;

What about other uses of synce_mobile_inactive?
http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/RemoteTabsExpandableListAdapter.java#157

If it's because the contrast between active/inactive  isn't enough, that's also fine (but if you do end up removing all the references, a reminder to remove the resource too)

Comment 5

[Chenxia Liu [:liuche]]

https://reviewboard.mozilla.org/r/6149/#review5143

Nit: maybe rename these to device_desktop instead of pc

Comment 6

[Chenxia Liu [:liuche]]

https://reviewboard.mozilla.org/r/6149/#review5147

Ship It!

Comment 7

[Chenxia Liu [:liuche]]

Comment on attachment 8583917 [details]
MozReview Request: bz://1147661/mcomella

<finkle.gif>

Comment 8

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

https://reviewboard.mozilla.org/r/6151/#review5173

> What about other uses of synce_mobile_inactive?
> http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/RemoteTabsExpandableListAdapter.java#157
> 
> If it's because the contrast between active/inactive  isn't enough, that's also fine (but if you do end up removing all the references, a reminder to remove the resource too)

The other uses are in other widgets that want don't want to change (e.g. the remote tabs panel).

Comment 9

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

https://reviewboard.mozilla.org/r/6149/#review5175

Let's make this an easier uplift: bug 1148095.

Comment 10

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

remote:   https://hg.mozilla.org/integration/fx-team/rev/e1ecc81168bb
remote:   https://hg.mozilla.org/integration/fx-team/rev/0f100d006b7c

Comment 11

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8583917 [details]
MozReview Request: bz://1147661/mcomella

Approval Request Comment
[Feature/regressing bug #]: bug 1130203
[User impact if declined]:
  Users will see the old device icons which are a different color than the ones we'd like (light grey as opposed to dark grey, which matches the font color), i.e. polish. 

[Describe test coverage new/current, TreeHerder]: None
[Risks and why]: 
  Low - we add new assets and replace the previous usage in the code with the new names. Worst case - we use the wrong assets.

[String/UUID change made/needed]: None

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e1ecc81168bb
https://hg.mozilla.org/mozilla-central/rev/0f100d006b7c

Comment 13

[Teodora Vermesan (:TeoVermesan)]

Attachment: Screenshot_2015-03-27-15-36-58.png

Verified as fixed using:
Device: Nexus 5 (Android 5.0)
Build: Firefox for Android 39.0a1 (2015-03-27)

Comment 14

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8583917 [details]
MozReview Request: bz://1147661/mcomella

This missed the uplift to Aurora. It'll need to go through the Beta approval process.

Comment 15

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8583917 [details]
MozReview Request: bz://1147661/mcomella

Approval Request Comment 11

Comment 16

[Sylvestre Ledru [:Sylvestre]]

Should be in 38 beta 2

Comment 17

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-beta/rev/32e9c40ea3f9
https://hg.mozilla.org/releases/mozilla-beta/rev/2d8d16d8c2ad

Comment 18

[Catalin Suciu [:csuciu]]

Verified as fixed on Beta 38.0b3 on Sony Xperia (4.4.4)

Comment 20

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: MozReview Request: Bug 1147661 - Add new device assets. r=liuche

Comment 21

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: MozReview Request: Bug 1147661 - Use new device icons in share overlay. r=liuche