Rename @drawable/device_pc to @drawable/device_desktop

RESOLVED FIXED in Firefox 40

Status

()

defect
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: mcomella, Assigned: dnirm, Mentored)

Tracking

unspecified
Firefox 40
All
Android
Points:
---

Firefox Tracking Flags

(firefox40 fixed)

Details

(Whiteboard: [lang=java][good first bug])

Attachments

(1 attachment)

It's a little more correct. :)

These files can be found at mobile/android/base/resources/drawable-*/device_pc.png. Don't forget to update the uses in code:

https://mxr.mozilla.org/mozilla-central/search?string=device_pc&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central

To start, set up a build environment - you can see the instructions here: https://wiki.mozilla.org/Mobile/Fennec/Android

Then, you'll need to create a patch to upload - see
https://wiki.mozilla.org/Mobile/Fennec/Android#Creating_commits_and_submitting_patches

If you need any help, you can reply to this bug, or feel free to message me on IRC - my nick is "mcomella" and you can find me in #mobile. If you need IRC setup instructions, see https://wiki.mozilla.org/IRC

Thanks and happy coding! ^_^
(Assignee)

Comment 1

4 years ago
Hi, I'm new here and I'd like to take this one.
Hey, Dipti - welcome aboard! :)

Feel free to get started - once you upload a patch, we'll assign you to the bug.
(Assignee)

Comment 3

4 years ago
Thanks Michael! 
I have committed the patch. I'm not sure which flag I need to set here for review (a11y or sec?).
(Assignee)

Updated

4 years ago
Attachment #8590520 - Attachment description: Renames files named "device_pc.png" to "device_. Changes code iRenames files named "device_pc.png" to "device_desktop.png" at @drawable-*. → Renames files named "device_pc.png" to "device_desktop.png". Changes code in mobile/android/base/overlays/ui/SendTabDeviceListArrayAdapter.java
Assignee: nobody → dnirm.moz
Comment on attachment 8590520 [details] [diff] [review]
Renames files named "device_pc.png" to "device_desktop.png". Changes code in mobile/android/base/overlays/ui/SendTabDeviceListArrayAdapter.java

Review of attachment 8590520 [details] [diff] [review]:
-----------------------------------------------------------------

Nice work!

I made a push to our try test servers (see above).

Once it goes green, feel free to add the checkin-needed keyword [1]. Let me know if you need help reading the results. Note that all patches that use "checkin-needed" must also have an associated green try run.

[1]: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch#Getting_the_patch_checked_into_the_tree
Attachment #8590520 - Flags: review?(michael.l.comella) → review+
If you'd like to get working on another bug, perhaps bug 952290 or bug 1105271 strikes your fancy? If not, let me know and I can dig up some more bugs.

Also, you should add a colon before the name in the brackets in your Bugzilla profile name - it helps with auto-completion (e.g. try typing :mcomella vs. mcomella into the needinfo section).
(Assignee)

Comment 9

4 years ago
Thank you Michael!
I see all the jobs green except
Keywords: checkin-needed
(Assignee)

Comment 10

4 years ago
Please ignore "except" in previous comment. 
I'll go through the two bugs and will let you know.
https://hg.mozilla.org/integration/fx-team/rev/74178879df7d
Keywords: checkin-needed
Whiteboard: [lang=java][good first bug] → [lang=java][good first bug][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/74178879df7d
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Whiteboard: [lang=java][good first bug][fixed-in-fx-team] → [lang=java][good first bug]
Target Milestone: --- → Firefox 40
You need to log in before you can comment on or make changes to this bug.