1148095 - Rename @drawable/device_pc to @drawable/device_desktop

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

It's a little more correct. :)

These files can be found at mobile/android/base/resources/drawable-*/device_pc.png. Don't forget to update the uses in code:

https://mxr.mozilla.org/mozilla-central/search?string=device_pc&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central

To start, set up a build environment - you can see the instructions here: https://wiki.mozilla.org/Mobile/Fennec/Android

Then, you'll need to create a patch to upload - see
https://wiki.mozilla.org/Mobile/Fennec/Android#Creating_commits_and_submitting_patches

If you need any help, you can reply to this bug, or feel free to message me on IRC - my nick is "mcomella" and you can find me in #mobile. If you need IRC setup instructions, see https://wiki.mozilla.org/IRC

Thanks and happy coding! ^_^

Comment 1

[Dipti Nirmale [:dnirm]]

Hi, I'm new here and I'd like to take this one.

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Hey, Dipti - welcome aboard! :)

Feel free to get started - once you upload a patch, we'll assign you to the bug.

Comment 3

[Dipti Nirmale [:dnirm]]

Thanks Michael! 
I have committed the patch. I'm not sure which flag I need to set here for review (a11y or sec?).

Comment 4

[Kevin Brosnan [Ex-Mozilla]]

Neither in this case. See https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch#Getting_the_patch_reviewed

Comment 5

[Dipti Nirmale [:dnirm]]

Attachment: Renames files named "device_pc.png" to "device_desktop.png". Changes code in mobile/android/base/overlays/ui/SendTabDeviceListArrayAdapter.java

Uploading patch for the fix

Comment 6

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b9d2dd6c4de1

Comment 7

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8590520 [details] [diff] [review]
Renames files named "device_pc.png" to "device_desktop.png". Changes code in mobile/android/base/overlays/ui/SendTabDeviceListArrayAdapter.java

Review of attachment 8590520 [details] [diff] [review]:
-----------------------------------------------------------------

Nice work!

I made a push to our try test servers (see above).

Once it goes green, feel free to add the checkin-needed keyword [1]. Let me know if you need help reading the results. Note that all patches that use "checkin-needed" must also have an associated green try run.

[1]: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch#Getting_the_patch_checked_into_the_tree

Comment 8

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

If you'd like to get working on another bug, perhaps bug 952290 or bug 1105271 strikes your fancy? If not, let me know and I can dig up some more bugs.

Also, you should add a colon before the name in the brackets in your Bugzilla profile name - it helps with auto-completion (e.g. try typing :mcomella vs. mcomella into the needinfo section).

Comment 9

[Dipti Nirmale [:dnirm]]

Thank you Michael!
I see all the jobs green except

Comment 10

[Dipti Nirmale [:dnirm]]

Please ignore "except" in previous comment. 
I'll go through the two bugs and will let you know.

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/fx-team/rev/74178879df7d

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/74178879df7d