1147944 - [SIM PIN] Input gets disabled with 2 SIMS, after entering the right PIN on the first one

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Alberto Pastor [:albertopq]]

STR:

1.- Insert 2 PIN enabled SIMs
2.- Start the phone
3.- Enter the right PIN on the first one

Expected:

The input is enabled in the 2nd PIN screen

Actual:

The input is disabled in the 2nd PIN screen

Comment 1

[Alberto Pastor [:albertopq]]

Blocker of a blocker

Comment 2

[GitHub Autolander Bot]

Attachment: [gaia] albertopq:1147944-sim2-disabled > mozilla-b2g:master

Comment 3

[Alberto Pastor [:albertopq]]

Comment on attachment 8583892 [details] [review]
[gaia] albertopq:1147944-sim2-disabled > mozilla-b2g:master

Just found a regression of bug 1139308. We need to clear the input after a succeed unlock.

Comment 4

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8583892 [details] [review]
[gaia] albertopq:1147944-sim2-disabled > mozilla-b2g:master

It's not bad, but my question is can't us clear in the init/show function when second SIM PIN prompt is requested?

Comment 5

[Alberto Pastor [:albertopq]]

I was following the same path that was implemented before the change (we were clearing after verifying) but makes perfectly sense. I already change it. Thanks!

Comment 6

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/7184640ad30addb45282a0e32e4b061c6b94a99e

Comment 7

[Alberto Pastor [:albertopq]]

Comment on attachment 8583892 [details] [review]
[gaia] albertopq:1147944-sim2-disabled > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): 1139308
[User impact] if declined: User can not enter the PIN on a second SIM
[Testing completed]: Added unit tests
[Risk to taking this patch] (and alternatives if risky): Low risk patch. Adding a missing method that was forgotten on bug 1139308.
[String changes made]: none

Comment 9

[Shally Li（leave from Mozilla）]

Per Comment 6,it has fixed on Flame v3.0.

According to the STR of Comment 0,this bug has been successfully verified on latest Nightly Flame v3.0.
See attachment: verified_v3.0.mp4.
Reproduce rate: 0/5

Device: Flame 3.0 build(Unaffected)
Build ID               20150329010203
Gaia Revision          67ad91f3f660b1f16b354ee4c5159ddc5a74d149
Gaia Date              2015-03-28 10:02:40
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/385840329d91
Gecko Version          39.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150329.042104
Firmware Date          Sun Mar 29 04:21:16 EDT 2015
Bootloader             L1TC000118D0

Comment 10

[Shally Li（leave from Mozilla）]

Attachment: verified_v3.0.mp4

Comment 11

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/8c6f7b037daede4715575a54a61b3fed9333851a

Comment 12

[Shally Li（leave from Mozilla）]

According to the STR of Comment 0,this bug has been successfully verified on latest Nightly Flame v2.2.
See attachment: verified_v2.2.mp4.
Reproduce rate: 0/5

Actual results:Insert 2 SIM cards with PIN codes, the 2nd PIN input box is enabled and displays normally after entering the right PIN on the first one.

Device: Flame 2.2 build(Pass)
Build ID               20150331162505
Gaia Revision          8b3086ad3963f1707e2bee9094baccafffe161c4
Gaia Date              2015-03-31 21:48:06
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/88e0e00cd64e
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150331.200333
Firmware Date          Tue Mar 31 20:03:44 EDT 2015
Bootloader             L1TC000118D0

Comment 13

[Shally Li（leave from Mozilla）]

Attachment: verified_v2.2.mp4