1148167 - Move share overlay theme declaration to themes.xml

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Currently the ShareOverlayActivity style is defined in styles.xml - it should be in themes.xml. See [1].

These files can be found in mobile/android/base/resources/values/

To start, set up a build environment - you can see the instructions here: https://wiki.mozilla.org/Mobile/Fennec/Android

Then, you'll need to create a patch to upload - see
https://wiki.mozilla.org/Mobile/Fennec/Android#Creating_commits_and_submitting_patches

If you need any help, you can reply to this bug, or feel free to message me on IRC - my nick is "mcomella" and you can find me in #mobile. If you need IRC setup instructions, see https://wiki.mozilla.org/IRC

Thanks and happy coding! ^_^

[1]: https://mxr.mozilla.org/mozilla-central/search?string=shareoverlayactivity&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central

Comment 1

[Kai Bittner [:Tondar]]

Attachment: bug1148167_movedShareOverlayActivity.diff

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e410c2520fed

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8585155 [details] [diff] [review]
bug1148167_movedShareOverlayActivity.diff

Review of attachment 8585155 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me - thanks, Kai!

Here is a push to our try test servers: https://treeherder.mozilla.org/#/jobs?repo=try&revision=98df6d6c9f4b

Once it goes green, feel free to add the checkin-needed keyword [1]. Let me know if you need help reading the results. Note that all patches that use "checkin-needed" must also have an associated green try run.

[1]: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch#Getting_the_patch_checked_into_the_tree

Comment 4

[Kai Bittner [:Tondar]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=98df6d6c9f4b
Test was successful - so I've marked it for checkin-needed.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/0ad8d8674fa0

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/0ad8d8674fa0

Comment 7

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Thanks Kai! If you're looking for some followup bugs, perhaps you'd like to look at bug 1085406 comment 5 for front-end work, or bug 1116351 for some background work.