Move share overlay theme declaration to themes.xml

RESOLVED FIXED in Firefox 40

Status

()

Firefox for Android
General
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: mcomella, Assigned: Tondar, Mentored)

Tracking

(Blocks: 1 bug)

unspecified
Firefox 40
All
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox40 fixed)

Details

(Whiteboard: [lang=xml][good first bug])

Attachments

(1 attachment)

Currently the ShareOverlayActivity style is defined in styles.xml - it should be in themes.xml. See [1].

These files can be found in mobile/android/base/resources/values/

To start, set up a build environment - you can see the instructions here: https://wiki.mozilla.org/Mobile/Fennec/Android

Then, you'll need to create a patch to upload - see
https://wiki.mozilla.org/Mobile/Fennec/Android#Creating_commits_and_submitting_patches

If you need any help, you can reply to this bug, or feel free to message me on IRC - my nick is "mcomella" and you can find me in #mobile. If you need IRC setup instructions, see https://wiki.mozilla.org/IRC

Thanks and happy coding! ^_^

[1]: https://mxr.mozilla.org/mozilla-central/search?string=shareoverlayactivity&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central
(Assignee)

Comment 1

3 years ago
Created attachment 8585155 [details] [diff] [review]
bug1148167_movedShareOverlayActivity.diff
Attachment #8585155 - Flags: review?(mhaigh)
Assignee: nobody → kai.bittner
Comment on attachment 8585155 [details] [diff] [review]
bug1148167_movedShareOverlayActivity.diff

Review of attachment 8585155 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me - thanks, Kai!

Here is a push to our try test servers: https://treeherder.mozilla.org/#/jobs?repo=try&revision=98df6d6c9f4b

Once it goes green, feel free to add the checkin-needed keyword [1]. Let me know if you need help reading the results. Note that all patches that use "checkin-needed" must also have an associated green try run.

[1]: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch#Getting_the_patch_checked_into_the_tree
Attachment #8585155 - Flags: review?(mhaigh) → review+
(Assignee)

Comment 4

3 years ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=98df6d6c9f4b
Test was successful - so I've marked it for checkin-needed.
Keywords: checkin-needed
(Assignee)

Updated

3 years ago
Status: NEW → ASSIGNED
https://hg.mozilla.org/integration/fx-team/rev/0ad8d8674fa0
Keywords: checkin-needed
Whiteboard: [lang=xml][good first bug] → [lang=xml][good first bug][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/0ad8d8674fa0
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox40: --- → fixed
Resolution: --- → FIXED
Whiteboard: [lang=xml][good first bug][fixed-in-fx-team] → [lang=xml][good first bug]
Target Milestone: --- → Firefox 40
Thanks Kai! If you're looking for some followup bugs, perhaps you'd like to look at bug 1085406 comment 5 for front-end work, or bug 1116351 for some background work.
You need to log in before you can comment on or make changes to this bug.