1152337 - crash in android.content.res.Resources$NotFoundException: Resource is not a ColorStateList (color or path): TypedValue{t=0x2/d=0x101009b a=3} at android.content.res.Resources.loadColorStateList(Resources.java)

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Teodora Vermesan (:TeoVermesan)]

This bug was filed from the Socorro interface and is 
report bp-9fb0c5b2-4a59-4243-b613-89bbb2150408.
=============================================================

Tested with:
Device: HTC Desire S (Android 2.3.3)
Build: Firefox for Android 40.0a1 (2015-04-08)

1, Set up sync
2. Go to a web page
3. Go to Menu -> share -> Add to Nightly

=> Nightly crashes

Note:
- crashes also with Aurora 39.0a1 (2015-04-08) when choosing Share -> Add to Nightly

Comment 1

[Michael Comella (:mcomella) [needinfo or I won't see it]]

Looks like this is a GB issue - note that I won't have a GB device to test a fix until Monday.

I think this is a regression from bug 1130203.

Comment 2

[Michael Comella (:mcomella) [needinfo or I won't see it]]

This could also be the fault of bug 1148041 and inheriting from the Gecko theme - we might be pointing at an attribute that is not available in GB.

Comment 3

[Michael Comella (:mcomella) [needinfo or I won't see it]]

Oops, we left the inheritance behind in: https://hg.mozilla.org/mozilla-central/rev/0ad8d8674fa0

That's probably the problem.

Comment 4

[Michael Comella (:mcomella) [needinfo or I won't see it]]

Attachment: MozReview Request: bz://1152337/mcomella

/r/6891 - Bug 1152337 - Inherit from Gecko in OverlayActivity. r=mfinkle

Pull down this commit:

hg pull -r a424309dd98695a0b548e6faf5143617433785da https://reviewboard-hg.mozilla.org/gecko/

Comment 5

[Michael Comella (:mcomella) [needinfo or I won't see it]]

Finkle, if you can repro comment 0, can you pull down the build in comment 4 to make sure this fixes the issue?

Comment 7

[Michael Comella (:mcomella) [needinfo or I won't see it]]

liuche, feel free to also try to repro (comment 5), or I can do it on Monday.

Comment 8

[Chenxia Liu [:liuche]]

Comment on attachment 8590932 [details]
MozReview Request: bz://1152337/mcomella

https://reviewboard.mozilla.org/r/6889/#review5753

This looks just like the fix from bug 1148041 - I was able to repro and verify that this fixed the crash on an SII running 2.3.

Comment 9

[Michael Comella (:mcomella) [needinfo or I won't see it]]

https://hg.mozilla.org/integration/fx-team/rev/d8af46151919

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d8af46151919

Comment 11

[Teodora Vermesan (:TeoVermesan)]

Choosing Menu -> Share -> Add to Nightly => the list of devices is displayed, so:
Verified as fixed using:
Device: HTC Desire S (Android 2.3.3)
Build: Firefox for Android 40.0a1 (2015-04-16)

Comment 13

[Michael Comella (:mcomella) [needinfo or I won't see it]]

Attachment: MozReview Request: Bug 1152337 - Inherit from Gecko in OverlayActivity. r=mfinkle