Closed Bug 1146482 (MediaMonitor) Opened 6 years ago Closed 6 years ago
Remove the Media
MozReview Request: Bug 1146482 - remove MediaDecoder::mReentrantMonitor which is not used anymore. r=jya.
40 bytes, text/x-review-board-request
In my overhaul of the media threading model, the end goal is a world where we have clear rules for which threads own which state. In this world, we won't have a need for the monolithic decoder monitor, so removing it is a good indication that we're finally on solid footing. We're a ways away from being able to do this, but I want to get a bug on file so that I can start racking up dependencies.
All dependents are resolved.
Status: NEW → RESOLVED
Closed: 6 years ago
OS: Mac OS X → Unspecified
Hardware: x86 → Unspecified
Resolution: --- → FIXED
yeah ! let's drink to that !
It looks like MediaDecoder::mReentrantMonitor is still there (but unused). Can we Resolve this bug by removing it? :-)
Oops! I will do it now. Thanks for the reminding.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Bug 1146482 - remove MediaDecoder::mReentrantMonitor which is not used anymore. r=jya.
Attachment #8670672 - Flags: review?(jyavenard)
Attachment #8670672 - Flags: review?(jyavenard) → review+
Comment on attachment 8670672 [details] MozReview Request: Bug 1146482 - remove MediaDecoder::mReentrantMonitor which is not used anymore. r=jya. https://reviewboard.mozilla.org/r/21427/#review19311
You are so awesome JW - Thanks ten thousand times for carrying this to the finish line!
Thanks Bobby. You've done most of the works and invent useful async tools (promise, mirroring) that help a lot on the way. Thanks.
You need to log in before you can comment on or make changes to this bug.