Closed Bug 1146482 (MediaMonitor) Opened 6 years ago Closed 6 years ago

Remove the MediaDecoder monitor

Categories

(Core :: Audio/Video: Playback, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla44
Tracking Status
firefox44 --- fixed

People

(Reporter: bholley, Unassigned)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

In my overhaul of the media threading model, the end goal is a world where we have clear rules for which threads own which state. In this world, we won't have a need for the monolithic decoder monitor, so removing it is a good indication that we're finally on solid footing.

We're a ways away from being able to do this, but I want to get a bug on file so that I can start racking up dependencies.
Alias: MediaMonitor
Depends on: 1146485
Depends on: 1136827
Depends on: 1148234
Depends on: 1148571
Blocks: MSRI
Depends on: 1157803
Depends on: 1158448
Depends on: 1159558
Depends on: 1159974
Depends on: 1160064
Depends on: 1160695
Depends on: 1161901
Depends on: 1162803
Depends on: 1163445
Depends on: 1175768
Depends on: 1178437
Depends on: 1178938
Depends on: 1179498
No longer depends on: 1148234
Depends on: 1179569
Depends on: 1186801
Component: Audio/Video → Audio/Video: Playback
Depends on: 1208930
Depends on: 1208934
Depends on: 1209864
Depends on: 1209887
Depends on: 1209888
Depends on: 1209890
Depends on: 1211327
Depends on: 1211766
All dependents are resolved.
Status: NEW → RESOLVED
Closed: 6 years ago
OS: Mac OS X → Unspecified
Hardware: x86 → Unspecified
Resolution: --- → FIXED
yeah !

let's drink to that !
It looks like MediaDecoder::mReentrantMonitor is still there (but unused). Can we Resolve this bug by removing it? :-)
Flags: needinfo?(jwwang)
Oops! I will do it now. Thanks for the reminding.
Status: RESOLVED → REOPENED
Flags: needinfo?(jwwang)
Resolution: FIXED → ---
Bug 1146482 - remove MediaDecoder::mReentrantMonitor which is not used anymore. r=jya.
Attachment #8670672 - Flags: review?(jyavenard)
Attachment #8670672 - Flags: review?(jyavenard) → review+
Comment on attachment 8670672 [details]
MozReview Request: Bug 1146482 - remove MediaDecoder::mReentrantMonitor which is not used anymore. r=jya.

https://reviewboard.mozilla.org/r/21427/#review19311
https://hg.mozilla.org/mozilla-central/rev/cd59b5c9d812
Status: REOPENED → RESOLVED
Closed: 6 years ago6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You are so awesome JW - Thanks ten thousand times for carrying this to the finish line!
Thanks Bobby. You've done most of the works and invent useful async tools (promise, mirroring) that help a lot on the way. Thanks.
You need to log in before you can comment on or make changes to this bug.