1148449 - Add a check and prompt for validation passing on step 2

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect, P1)

Description

[Wil Clouser [:clouserw]]

On this step, if validation fails for an unlisted add-on that is not requesting full review (side-loading), we should show a prompt saying "Your submission didn't pass validation, which is a requirement for automatic signing. You can submit your add-on for manual review or cancel your submission.

[Submit] [Cancel]"

Submitting puts them in the queue, the same as if they'd checked the box.

Cancelling just clears the prompt and stays on the page (like a normal failed validation looks)

From: https://docs.google.com/a/mozilla.com/drawings/d/1DOJpCF7ytkbi57S6-YsWD17778WkrQI9Vy2ot3nJHCk/edit

Comment 1

[Wil Clouser [:clouserw]]

I filed this a little prematurely hoping that submitting would be the same as if they had checked the box, but Jorge pointed out that it's the same except at the end it's signed with the prelim cert, not the full cert.

Comment 2

[Mathieu Agopian [:magopian]]

PR: https://github.com/mozilla/olympia/pull/503

The current work is in progress (we don't have the automatic validation part yet, we need to come up with a list of messages/warnings that aren't going to result in a manual review).

The "prompt" is just a line explaining if the addon is going to be automatically validated or if it needs a manual review (no submit/cancel button, no popup).

Comment 3

[Mathieu Agopian [:magopian]]

Fixed in https://github.com/mozilla/olympia/commit/921ec571dddbcfd350c795ec67b97fb6602ed064

At the moment, we only do an automatic (preliminary) review and signing for submissions that result in 0 messages/errors from the validator. The implementation of the real behavior will happen with bug 1153231

STR:
1/ Have an add-on that passes validation without any error (example: one created with the latest cfx or jpm tool), and another one that raises at least one error or message/warning (eg, one created with an old cfx or jpm).
2/ try submitting an unlisted addon with the file that passes validation: it should say that it's going to be automatically signed
3/ try submitting an unlisted addon with the file that doesn't pass validation: it should say that it's going to be manually reviewed
4/ try submitting an unlisted sideload addon with both files (it should display the same message with both addons: it needs a manual review)

There are screenshots in the PR description showing the messages (they've been slightly reworded in the final version of the PR, so they aren't perfectly accurate).

Comment 4

[Madalin Cotetiu]

Verified in FF38(Win7) in addons-dev.allizom.org

The issues I have observed are the following:

1. For an unlisted add-on that passes validation the following message is displayed: "Your submission passed validation and will go through a manual review" : http://screencast.com/t/o92bPJXvm  In comment 3 it is stated that the message should say that it's going to be automatically signed. 

2. For a unlisted add-on that passes validation no message is displayed:
add-on with errors: http://screencast.com/t/tfjfohLADCv
only warnings: http://screencast.com/t/zein4NA0V6e

Same issues are reproducing for sideloaded add-ons.

Reopening bug.

Comment 5

[Mathieu Agopian [:magopian]]

Madalin, you need the "automatic-validation" flag enabled in the admin (https://addons-dev.allizom.org/fr/admin/models/waffle/flag/) to be able to test this.

Let me know if you need me to enable it on -dev.

Comment 6

[Madalin Cotetiu]

Thanks :magopian for enabling the flag
 
Verified in FF38(Win7) in add-ons.allizom.org
Unlisted add-on that passes validation: http://screencast.com/t/rlRrRzVcFyd
Sideloaded add-on that passes validation: http://screencast.com/t/FfZe2lGW2B9

For an unlisted add-on that do not passes validation there is no text displayed under the progress bar, but there is a similar text in red lower on the page. I think that is the expected results but wanted to be 100% sure. Mathieu can you please confirm that this is the expected behaviour before I close this bug?  The screencast for this scenario: http://screencast.com/t/PR9fCbsVSb0

Comment 7

[Mathieu Agopian [:magopian]]

Yes it's the expected behaviour since bug 1159720 was fixed. Thanks!

Comment 8

[Madalin Cotetiu]

Closing bug.