1148462 - When "Reading List" is disabled (browser.readinglist.enabled = false) CTRL+ALT+R should not open its sidebar.

Status: VERIFIED FIXED

(Firefox Graveyard :: Reading List, defect, P1)

Description

[Johan C]

This bug concerns both Aurora and Nightly.

STR:
1. Set "browser.readinglist.enabled" to "false"
2. Press CTRL+ALT+R.

Actual result:
1. The "Reading List" sidebar opens.
2. Add-ons using the key combination, e.g. Restartless Restart, do not work as expected.

Expected result:
1. The "Reading List" sidebar should not open.
2. Add-ons using the key combination, e.g. Restartless Restart, should work as expected.

Comment 1

[Justin Dolske [:Dolske]]

This seems important to fix for release (even though hitting it not going to be super-common), because dumping the user into UI for a feature that's actually disabled (and is likely non-functional as a result) is a really bad experience.

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

https://hg.mozilla.org/integration/fx-team/rev/61da0ee2db1f

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/61da0ee2db1f

Comment 5

[Andrei Vaida [:avaida]]

Verified fixed on Nightly 40.0a1 (2015-04-05), using Windows 7 (x64), Ubuntu 14.04 (x64) and Mac OS X 10.9.5.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/651367982d90

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/6238a894c78f

Comment 8

[Andrei Vaida [:avaida]]

Verified fixed on Beta 38.0b2-build1 (20150406174117) as well, using Windows 7 (x64), Ubuntu 14.04 (x64) and Mac OS X 10.9.5.

Comment 9

[[SV Manager] Florin Mezei, QA (:FlorinMezei)]

Removing qe-verify flag as this was verified on Nightly and Beta, and won't be verified on 39 Aurora.