Closed Bug 1148462 Opened 11 years ago Closed 11 years ago

When "Reading List" is disabled (browser.readinglist.enabled = false) CTRL+ALT+R should not open its sidebar.

Categories

(Firefox Graveyard :: Reading List, defect, P1)

Product:
Firefox Graveyard
Component:
Reading List
Type:
defect

Tracking

(firefox38 verified, firefox39 fixed, firefox40 verified)

Status:
VERIFIED FIXED
Milestone:
Firefox 40
Tracking Flags:
Tracking Status
firefox38 --- verified
firefox39 --- fixed
firefox40 --- verified

People

(Reporter: johan.charlez, Assigned: jaws)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Patch
2.21 KB, patch
Gijs
: review+
Gavin
: approval-mozilla-aurora+
Gavin
: approval-mozilla-beta+
Details | Diff | Splinter Review
This bug concerns both Aurora and Nightly. STR: 1. Set "browser.readinglist.enabled" to "false" 2. Press CTRL+ALT+R. Actual result: 1. The "Reading List" sidebar opens. 2. Add-ons using the key combination, e.g. Restartless Restart, do not work as expected. Expected result: 1. The "Reading List" sidebar should not open. 2. Add-ons using the key combination, e.g. Restartless Restart, should work as expected.
status-firefox38: --- → affected
status-firefox39: --- → affected
Flags: qe-verify+
This seems important to fix for release (even though hitting it not going to be super-common), because dumping the user into UI for a feature that's actually disabled (and is likely non-functional as a result) is a really bad experience.
Priority: -- → P1
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Iteration: --- → 40.1 - 13 Apr
Points: --- → 2
Flags: firefox-backlog+
OS: Windows 7 → All
Hardware: x86_64 → All
Blocks: 1132074
Attached patch Patch — — Splinter Review
Attachment #8587662 - Flags: review?(gijskruitbosch+bugs)
Attachment #8587662 - Flags: review?(gijskruitbosch+bugs) → review+
Attachment #8587662 - Flags: approval-mozilla-beta+
Attachment #8587662 - Flags: approval-mozilla-aurora+
https://hg.mozilla.org/mozilla-central/rev/61da0ee2db1f
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
status-firefox40: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 40
QA Contact: andrei.vaida
Verified fixed on Nightly 40.0a1 (2015-04-05), using Windows 7 (x64), Ubuntu 14.04 (x64) and Mac OS X 10.9.5.
Status: RESOLVED → VERIFIED
status-firefox40: fixed → verified
Verified fixed on Beta 38.0b2-build1 (20150406174117) as well, using Windows 7 (x64), Ubuntu 14.04 (x64) and Mac OS X 10.9.5.
status-firefox38: fixed → verified
Removing qe-verify flag as this was verified on Nightly and Beta, and won't be verified on 39 Aurora.
Flags: qe-verify+
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: