Closed Bug 1148933 Opened 9 years ago Closed 9 years ago

Remove old storageservice.js and tests

Categories

(Cloud Services :: Firefox: Common, defect)

Product:
Cloud Services
Component:
Firefox: Common
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox40 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla40
Tracking Flags:
Tracking Status
firefox40 --- fixed

People

(Reporter: rnewman, Assigned: rnewman)

References

Details

Attachments

(1 file)

Remove old storageservice.js and tests. v1
113.34 KB, patch
gps
: review+
Details | Diff | Splinter Review 
We never used this code, it's probably bitrotted, and we ship it on Android!

Beautiful code though it is, it's time to remove it from the tree and stop running the tests.
Rubberstamp?

(Will make sure Try is green before landing, of course.)
Attachment #8585194 - Flags: review?(gps)
Assignee: nobody → rnewman
Status: NEW → ASSIGNED
Green apart from failing to remove storageservice from test_load_modules. Second push is xpcshell-only to verify that.
Comment on attachment 8585194 [details] [diff] [review]
Remove old storageservice.js and tests. v1

Review of attachment 8585194 [details] [diff] [review]:
-----------------------------------------------------------------

So much effort put into this code for so little use. So sad.
Attachment #8585194 - Flags: review?(gps) → review+
Yup, it joins a number of other projects in that regard. Sad.

I left a pointer in Bug 824026; should that ever be prioritized, I expect this code to be raised from the dead.
Does b2g even use FxAccountsClient.jsm?
Flags: needinfo?(rnewman)
https://hg.mozilla.org/mozilla-central/rev/c92cca38290e
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox40: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: