1148990 - Don't ship bagheeraclient, tokenserverclient, etc. unless shipping appropriate desktop features

Status: RESOLVED FIXED

(Cloud Services :: Firefox: Common, defect)

Description

[Richard Newman [:rnewman]]

… and when FHR goes away, bagheeraclient can go away entirely.

The JS client isn't used on Android at all.

Comment 1

[Richard Newman [:rnewman]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=cc703ea624ac

Comment 2

[Richard Newman [:rnewman]]

Attachment: Don't ship bagheeraclient unless shipping the desktop FHR implementation. v1

Pushing to Try now. Hard to test locally -- yup, it excludes the files from my Android build!

Comment 3

[Richard Newman [:rnewman]]

Comment on attachment 8585243 [details] [diff] [review]
Don't ship bagheeraclient unless shipping the desktop FHR implementation. v1

Review of attachment 8585243 [details] [diff] [review]:
-----------------------------------------------------------------

::: services/common/tests/unit/test_load_modules.js
@@ +45,5 @@
> +      throw "Importing " + m + " should have failed!";
> +    }
> +  }
> +}
> +  

Sorry, will fix ws.

@@ +55,5 @@
> +    expectImportsToSucceed(non_android_modules);
> +    expectImportsToSucceed(non_android_test_modules, base=TEST_BASE);
> +  } else {
> +    expectImportsToFail(non_android_modules);
> +    expectTestImportsToFail(non_android_test_modules, base=TEST_BASE);

This is fixed locally.

Comment 4

[Richard Newman [:rnewman]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e2fc76b6bbf3

Comment 5

[Richard Newman [:rnewman]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=87d4a5a188e1

Comment 6

[Richard Newman [:rnewman]]

Attachment: Don't ship bagheeraclient.js or tokenserverclient.js on Android. v2

Neither of these clients are used on Android, and the Bagheera client isn't
used anywhere unless Firefox Health Report is enabled.

This patch conditionalizes their inclusion in services-common, makes the tests
aware, and also tests that they are _not_ present on Android.

Note that some unused test helpers are also omitted.

Comment 7

[Richard Newman [:rnewman]]

https://hg.mozilla.org/integration/fx-team/rev/b5e71f873231

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Backed out for b2g xpcshell bustage in https://hg.mozilla.org/integration/fx-team/rev/23b4ddbe9db9

https://treeherder.mozilla.org/logviewer.html#?job_id=2483030&repo=fx-team

Comment 9

[Richard Newman [:rnewman]]

https://hg.mozilla.org/integration/fx-team/rev/042755670a6d

Comment 10

[Richard Newman [:rnewman]]

Relanded with an 'Android' check replaced with a MOZ_WIDGET check. *shakes fist at b2g*

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/042755670a6d