Closed Bug 1148990 Opened 9 years ago Closed 9 years ago

Don't ship bagheeraclient, tokenserverclient, etc. unless shipping appropriate desktop features

Categories

(Cloud Services :: Firefox: Common, defect)

All
Android
defect
Not set
normal

Tracking

(firefox40 fixed)

RESOLVED FIXED
mozilla40
Tracking Status
firefox40 --- fixed

People

(Reporter: rnewman, Assigned: rnewman)

References

Details

Attachments

(1 file, 1 obsolete file)

… and when FHR goes away, bagheeraclient can go away entirely.

The JS client isn't used on Android at all.
Assignee: nobody → rnewman
Status: NEW → ASSIGNED
Summary: Don't ship bagheeraclient unless shipping the desktop FHR implementation → Don't ship bagheeraclient, tokenserverclient, etc. unless shipping appropriate desktop features
Pushing to Try now. Hard to test locally -- yup, it excludes the files from my Android build!
Attachment #8585243 - Flags: feedback?(gps)
Comment on attachment 8585243 [details] [diff] [review]
Don't ship bagheeraclient unless shipping the desktop FHR implementation. v1

Review of attachment 8585243 [details] [diff] [review]:
-----------------------------------------------------------------

::: services/common/tests/unit/test_load_modules.js
@@ +45,5 @@
> +      throw "Importing " + m + " should have failed!";
> +    }
> +  }
> +}
> +  

Sorry, will fix ws.

@@ +55,5 @@
> +    expectImportsToSucceed(non_android_modules);
> +    expectImportsToSucceed(non_android_test_modules, base=TEST_BASE);
> +  } else {
> +    expectImportsToFail(non_android_modules);
> +    expectTestImportsToFail(non_android_test_modules, base=TEST_BASE);

This is fixed locally.
Neither of these clients are used on Android, and the Bagheera client isn't
used anywhere unless Firefox Health Report is enabled.

This patch conditionalizes their inclusion in services-common, makes the tests
aware, and also tests that they are _not_ present on Android.

Note that some unused test helpers are also omitted.
Attachment #8585506 - Flags: review?(gps)
Attachment #8585243 - Attachment is obsolete: true
Attachment #8585243 - Flags: feedback?(gps)
Attachment #8585506 - Flags: review?(gps) → review+
Relanded with an 'Android' check replaced with a MOZ_WIDGET check. *shakes fist at b2g*
Flags: needinfo?(rnewman)
https://hg.mozilla.org/mozilla-central/rev/042755670a6d
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: