1149144 - Page preview images (GIFs) shouldn't animate in the Reading List sidebar

Status: RESOLVED WORKSFORME

(Firefox Graveyard :: Reading List, defect, P5)

Description

[Cornel Ionce [:noni] [Hubs QA]]

Reproducible on:
Nightly 39.0a1 (build ID: 20150329030238)
Aurora 38.0a2 (build ID: 20150330004006)

Affected platforms:
Windows 7 64-bit, Windows 8.1 64-bit (Microsoft Surface Pro 2), Ubuntu 14.04 32-bit and Mac OS X 10.9.5

Steps to reproduce:
1. Launch Firefox using a clean profile;
2. Make sure Reading list is enabled (browser.readinglist.enabled is set to true in about:config);
3. Go to a crash report (eg. http://bit.ly/1Dkx9gc) and add it to the reading list;
4. Enable the Reading List sidebar (ctrl/cmd+alt+r)

Expected Results:
The crash report page is correctly displayed in the Reading List sidebar.

Actual Results:
Crash-report page thumbnail displays a never-ending loading circle.
Screenshot: http://i.imgur.com/Sn6PdwN.png

Notes:
"Remove this from your Reading List" has also an awkward placement, three small Close buttons are displayed instead of the desired one.
Screenshot: http://i.imgur.com/hLPD3hF.png

Comment 1

[Justin Dolske [:Dolske]]

That the page's throbber is being used as a preview image is bug 1146348. We just shouldn't be doing that. 

But I'm going to mutate this bug -- if we end up using a GIF as the preview image, having it animate in the sidebar is a little lolwat.

Probably need to have a load listener on the image to call .stop(). Bug 653035 would be nice here too...

Comment 2

[Justin Dolske [:Dolske]]

(In reply to Cornel Ionce [QA] from comment #0)

> Notes:
> "Remove this from your Reading List" has also an awkward placement, three
> small Close buttons are displayed instead of the desired one.
> Screenshot: http://i.imgur.com/hLPD3hF.png

Uhh, that's weird. And on OS X I actually get two tiny close buttons (well, 2 images within a button) stacked vertically. Sounds like bug 1149136, let's move this part there.

Comment 3

[Dana Lucaci, Desktop QA]

This issue is not reproducible anymore using the latest Firefox 124.0 build on Ubuntu 22, macOS 12 ARM and Win 10. I'm closing it as WFM.