Closed Bug 1149217 Opened 5 years ago Closed 5 years ago

Change activity name triggered for sharing bugs

Categories

(Firefox OS Graveyard :: Gaia::Bugzilla Lite, defect)

x86
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
2.2 S9 (3apr)

People

(Reporter: daleharvey, Assigned: daleharvey)

References

Details

(Whiteboard: [systemsfe])

Attachments

(2 files)

No description provided.
Blocks: 1134701
Assignee: nobody → dale
This was previously changed in https://bugzilla.mozilla.org/show_bug.cgi?id=1135860, however it now brings up a generic 'share' activity which on my device has twitter, facebook, messages, bluetooth, telegram, wallpaper.

Only email and bugzilla lite are realistically going to be useful, we can either change the activity type or create a new name
Attachment #8585768 - Flags: review?(lissyx+mozillians)
Attachment #8585768 - Flags: review?(jrburke)
Attachment #8585768 - Flags: feedback?
Attached file PR for bzlite
Attachment #8585770 - Flags: review?(drs)
Ok, you're not changing the name, just the types. I think we could also include bluetooth at least, because I already saw myself wanting to pass along data this way for a lot of good reasons.
Yeh bluetooth picks this up as well
Attachment #8585768 - Flags: review?(lissyx+mozillians) → review+
Comment on attachment 8585768 [details] [review]
[gaia] daleharvey:1149217 > mozilla-b2g:master

r+ for the email change, with a suggestion for the media type: probably better to scope it more than just a generic sounding top-level name? Looking here: 
http://en.wikipedia.org/wiki/Internet_media_type

Maybe "text/vnd.moz-systemlog"? r+ for any scoping change for email app purposes. Otherwise, I will assume you have already done the background work for the media type value and this was the result.
Attachment #8585768 - Flags: review?(jrburke) → review+
Agreed over IRC to switch to application/vnd.moz-systemlog

Landed in gaia in https://github.com/mozilla-b2g/gaia/commit/a94413acb269d0f240cf3ea56c30cec9e9e630bd
Comment on attachment 8585770 [details] [review]
PR for bzlite

Looks good. I left one mostly tangential comment on the PR.
Attachment #8585770 - Flags: review?(drs) → review+
Awesome thanks, agree with the version change although I actually misunderstood, I didnt realise the version was completely unused in the manifest. I thought we may have done some type of version check so we could do updates to the activities etc.

As far as I understand without it going through the marketplace users will never see this change and bzlite would be broken until it was uninstalled (which is lucky since only Alexandre and I are users). Going to check up on that

Landed in https://github.com/mozilla-b2g/bzlite/commit/8776c309be0142d353a9e89bf69a1dd546b1fc66
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [systemsfe]
Target Milestone: --- → 2.2 S9 (3apr)
Given the convention we're using for sharing stuff across various apps, you actually want to be using application/*, not a specific MIME type.
Comment on attachment 8585768 [details] [review]
[gaia] daleharvey:1149217 > mozilla-b2g:master

Clearing weird f? I requested by accident
Attachment #8585768 - Flags: feedback?
Blocks: 1151963
No longer blocks: 1151963
You need to log in before you can comment on or make changes to this bug.