1150722 - Triggering log capture activity shows empty form

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Bugzilla Lite, defect)

Comment 1

[Dale Harvey (:daleharvey)]

Race condition between creating the page and handling the activity in https://github.com/mozilla-b2g/bzlite/blob/master/lib/app.js#L172

Comment 2

[Dale Harvey (:daleharvey)]

Attachment: https://github.com/mozilla-b2g/bzlite/pull/5

The issue here was, on load page('/create/') gets called any time, page('/create/') was then triggered by the activity handler which is completely valid (we dont want to wait on a possible activity before rendering)

However occasionally we set app.activity before the first render completed, this meant the first render picked up the activity, displayed its data, then the /create/ triggered by the activity showed an empty form

Comment 3

[Doug Sherk (:drs) (inactive)]

Comment on attachment 8587707 [details] [review]
https://github.com/mozilla-b2g/bzlite/pull/5

There's still a bit of remaining racyness that I'm not comfortable with. I think that fixing this would also improve code flow and make it more clear what's going on.

Comment 4

[Dale Harvey (:daleharvey)]

Comment on attachment 8587707 [details] [review]
https://github.com/mozilla-b2g/bzlite/pull/5

If the init flow gets more complicated we can have it be a promise, but adding the activity handler once init is completed is a lot cleaner and lets us get rid of the initCalled check. 

Good catch, cheers

Comment 5

[Doug Sherk (:drs) (inactive)]

Comment on attachment 8587707 [details] [review]
https://github.com/mozilla-b2g/bzlite/pull/5

Looks good now.

Comment 6

[Dale Harvey (:daleharvey)]

Sweet cheers

https://github.com/mozilla-b2g/bzlite/commit/7d972794d99d2a9511e5247fd688b309f214575d