1151067 - [RTL][Rocket Bar] Search history URL is being truncated differently than the same URL in card view

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Search, defect, P2)

Description

[KTucker [:KTucker][Inactive 3/4/2016]]

Attachment: SearchHistoryURL (1).png

Description:
The user will notice a search history result will be truncated on the left under the Rocketbar but the same URL will be truncated on the right in card view. 

Search history result under the rocketbar:

...//www.google.com/search?q=happy

In card view, the user will see:

www.google.com/search...
   
Repro Steps:
1) Update a Flame device to BuildID: 20150403010203
2) Set the device language in Arabic under Settings > Language.
3) Perform a search for "Happy" in the rocketbar. 
4) After the webpage opens up, hold down the "Home" button on the dut to enter card view.
5) Look at the URL for the search above the webpage card.
6) Tap the "Home" button on the dut to return to the homescreen.
7) Tap on the "Rocketbar" on the homescreen and start entering the search term "Happy" again. 
8) Look at the URL under the search history.

Actual:
The url under search history is truncated differently that the same url in card view.
  
Expected: 
Both URLs are truncated in the same way.

Environmental Variables:
Device: Flame 3.0(Full Flash)(KK)(319mb)
Build ID: 20150403010203
Gaia: 7969b367a7da62877c3a24a26d3cb5fda89d766c
Gecko: 70a113676b21
Gonk: b83fc73de7b64594cd74b33e498bf08332b5d87b
Version: 40.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:40.0) Gecko/40.0 Firefox/40.0
  
Repro frequency: 100%
See attached: screenshots

Comment 1

[KTucker [:KTucker][Inactive 3/4/2016]]

Attachment: CardViewURL.png

Comment 2

[KTucker [:KTucker][Inactive 3/4/2016]]

This issue also occurs on Flame 2.2

Device: Flame 2.2 (Full Flash)(KK)(319mb)
Build ID: 20150401002624
Gaia: 8b3086ad3963f1707e2bee9094baccafffe161c4
Gecko: 20b67213a047
Gonk: ebad7da532429a6f5efadc00bf6ad8a41288a429
Version: 37.0 (2.2)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Comment 3

[Sam Foster [:sfoster] (he/him)]

Nominating. I'll take a look at this - its very likely a similar issue to bug 1151925.

Comment 4

[Sam Foster [:sfoster] (he/him)]

Attachment: search-ltr-content-in-rtl-ui.png

Francis, can you just confirm that this is what we are looking for with bidi or LTR content in a RTL UI? I've got both title and url right-aligned here in RTL. Truncation should follow language direction, so we'll see the ellipsis on the right for LTR and predominately LTR bidi content, and on the left for RTL content. We also see the start of the url here like in card view, instead of the end (current behavior on master, 2.2)

Comment 5

[Francis Djabri [:djabber]]

This looks correct to me. If a word is from a LTR language, it should read LTR and we should truncate accordingly.

Comment 6

[Francis Djabri [:djabber]]

Steph, would you mind taking a look just to confirm?

Comment 7

[Sam Foster [:sfoster] (he/him)]

(In reply to Francis Djabri [:djabber] from comment #6)
> Steph, would you mind taking a look just to confirm?

I have a memory of this alignment issue coming up - perhaps with SMS - and IIRC we decided to right-align lists like this in RTL, regardless of their locale/direction. Does that sound right? I.e. the rocketbar history list would be ragged-left for RTL, ragged-right (left-aligned) for LTR.

Comment 8

[Stephany Wilkes]

Francis is correct and this is covered in the spec document (both alignment and truncation for both RTL and LTR languages are in the spec).

Comment 9

[GitHub Autolander Bot]

Attachment: [gaia] sfoster:search-history-url-rtl-bug-1151067 > mozilla-b2g:master

Comment 10

[Sam Foster [:sfoster] (he/him)]

Comment on attachment 8593121 [details] [review]
[gaia] sfoster:search-history-url-rtl-bug-1151067 > mozilla-b2g:master

More RTL/bidi tweaks. Where we know we are displaying a URL, I added the 'ltr' dir attribute. It helps, but its a stop-gap and hopefully we can solve the URL display thing upstream eventually.  

BTW, I ran into some problems while testing this where I wasn't getting icons or titles for new places entries - always the URL. I didn't get to the bottom of it or narrow down STR yet. Could it be a side-effect of switching between languages? Use of non-ascii titles? Anyhow I'm pretty certain this is not introduced by this patch and will file it if I can repro on master 

FYI: https://ar.wikipedia.org/, http://aljazeera.net are a couple of arabic languages I was testing with

Comment 11

[Kevin Grandon :kgrandon]

Comment on attachment 8593121 [details] [review]
[gaia] sfoster:search-history-url-rtl-bug-1151067 > mozilla-b2g:master

Going to flip this review over to Dale if that's alright as my queue is starting to backup and I don't want you to wait too long. Thanks.

Comment 12

[Dale Harvey (:daleharvey)]

Comment on attachment 8593121 [details] [review]
[gaia] sfoster:search-history-url-rtl-bug-1151067 > mozilla-b2g:master

This looks good to me, cheers

Comment 13

[GitHub Autolander Bot]

https://github.com/mozilla-b2g/gaia/pull/29534

The pull request could not be applied to the integration branch. Please try again after current integration is complete. You may need to rebase your branch against the target branch.

Comment 14

[Kevin Grandon :kgrandon]

(In reply to Autolander from comment #13)
> https://github.com/mozilla-b2g/gaia/pull/29534
> 
> The pull request could not be applied to the integration branch. Please try
> again after current integration is complete. You may need to rebase your
> branch against the target branch.

Trying again..

Comment 15

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/a1a2ef17e3634ab21ca8d04d4594c7942cf37722

Comment 16

[Ryan VanderMeulen [:RyanVM]]

Please request Gaia v2.2 approval on this patch when you get a chance.

Comment 17

[Sam Foster [:sfoster] (he/him)]

Comment on attachment 8593121 [details] [review]
[gaia] sfoster:search-history-url-rtl-bug-1151067 > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): RTL in Search & New Tab 
[User impact] if declined: Icon labels, search and history results can get truncated and ellipsized from wrong end
[Testing completed]: Tested on device, with both en-us and ar default locales
[Risk to taking this patch] (and alternatives if risky): Low risk, limited CSS/markup changes confined to search app
[String changes made]: None

Comment 18

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/9b9e372ff8f7c414ea7b97bea09f826db2054267

Comment 19

[Sue]

Attachment: verify_pass.png

This issus has been verified passed on latest build of Flame2.2/3.0 with the same steps in comment 0.
See attachment:verify_pass.png
Rate:0/5

Device: Flame 2.2 (pass)
Build ID               20150419002502
Gaia Revision          c15a2b6d3a783813959c2b3bffd2a131f4270b9e
Gaia Date              2015-04-17 17:49:32
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/cc02ee38b252
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150419.040848
Firmware Date          Sun Apr 19 04:08:59 EDT 2015
Bootloader             L1TC000118D0

Device: Flame 3.0 (pass)
Build ID               20150419160202
Gaia Revision          c6b04efa0f31a584e6ee0a46dd2b64c1e3c29adc
Gaia Date              2015-04-17 21:10:53
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/a32e3b93c8d8
Gecko Version          40.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150419.193329
Firmware Date          Sun Apr 19 19:33:40 EDT 2015
Bootloader             L1TC000118D0