115132 - files are saved in a file:<path> directory

Status: VERIFIED WORKSFORME

(Core Graveyard :: File Handling, defect)

Description

[sairuh (rarely reading bugmail)]

spun off from bug 114874 as a separate issue.

when saving works, it's saved in a new 'file:' dir that recreates the target
location... eg,

if you meant to save in to /home/halo/myfile.html, the file would actually be
saved in /home/halo/file:/home/halo/myfile.html.

Comment 1

[Kathleen :Brade]

I think Charley had some code which dealt with platform-specific issues of path
handling...

Comment 2

[sairuh (rarely reading bugmail)]

another observation --it seems that an extra, empty directory is being created
as well. same issue? found using 2001.12.13.14 comm build.

eg, when the file is saved to /home/halo/file:/home/halo/myfile.html, an
additional empty directory is created as /home/halo/file:/home/halo/myfile_files/

Comment 3

[sairuh (rarely reading bugmail)]

d'oh --nearly forgot that rkaa had also seen comment 2 in bug 114874 comment 15.

Comment 4

[R.K.Aa.]

the directory is created without x bit for user (0655 instead of 0755) - which
is likely the reason it is empty since it can't be entered or written to.

bug 115088 is about the same/similar phenomena.

Comment 5

[sairuh (rarely reading bugmail)]

rkaa, thx for the pointer --i'll keep these issues seperate, then, unless ben
thinks they're the same.

Comment 6

[Boris Zbarsky [:bzbarsky]]

There are actually three issues.  Bug 115088 is about the empty directory being
created when we are saving "HTML only" (there are no images to put in that
directory then, so it should not be created at all).  Bug 115154 (just filed) is
about the fact that when we save as "whole page" nothing but the HTML gets saved
since the directory, which _is_ needed in that case, is read-only.  I've moved
the relevant comments from bug 114874, including the exact line that's wrong and
what's wrong in it, to that bug.....

Those are both separate from _this_ bug, which is that the directory is created
in the wrong place.

Comment 7

[sairuh (rarely reading bugmail)]

side note/reminder to self: Save Link and Save Image work fine, however.

Comment 8

[Adam Lock]

If you want to save HTML only, you should pass a nsnull data path into
nsIWebBrowserPersist::SaveDocument. Otherwise it creates that directory to save
any files that may be linked to the document.

Comment 9

[André Dahlqvist]

Dupe of bug 115154?

Comment 10

[Boris Zbarsky [:bzbarsky]]

No.  Please read comment #6.

Comment 11

[Diego Biurrun]

Linux 2001121715

I get the same behavior (file: dir created), but no file is saved when I try to
save a plaintext page (like a patch), the dialog just hangs there without
progressing.  I cannot save plaintext at all.  I consider this a blocker that
should get fixed for 0.9.7 by all means.

Comment 12

[tradervik]

I tested this bug using the trunk build 2001121916 (Linux) and it seems to be
working correctly. The HTML file is save as file.html and the images, etc. are
saved in "file_files/".

Comment 13

[Boris Zbarsky [:bzbarsky]]

traverdik, are you saving to a "relative" path or an "absolute" path?

Comment 14

[Diego Biurrun]

Don't know what's up with the trunk, but 2001122008 over in 0.9.7 land is saving
as bad as ever.

Comment 15

[Diego Biurrun]

Build 2001122108 has no more problems for me.  I will mark this as WORKSFORME
since tradervik also seemed to be rid of his problems.

Comment 16

[Diego Biurrun]

My CVS build from half an hour ago has no problems either, so I suppose this is
gone from branch and trunk.

Comment 17

[sairuh (rarely reading bugmail)]

yep, no longer see this with recent bits.