1151448 - Cross-posts won't send because Newsgroups: groups are separated with comma+space, not just comma

Status: VERIFIED FIXED

(MailNews Core :: Networking: NNTP, defect)

Description

[WaltS48 [:walts48]]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Firefox/38.0
Build ID: 20150330154247

Steps to reproduce:

Wanted to followup to a news.mozilla.org newsgroup post in m.support.thunderbird and cross-post  and set Followuo-To:m.general


Actual results:

Received an Alert message; "A News (NNTP) error occurred: posting failed." 

Followed by a Send Message Error;

"Sending of message Failed
The message could not be sent because connecting to the news server failed. The server may be unavailable or is refusing connections. Please verify that your news server settings are correct and try again."



Expected results:

Message should have posted to m.s.thunderbird, cross-posted to m.general and Followup-TO: should have been set to m.general

This works properly using Thunderbird 31.6.0 where my server settings are identical.

Comment 1

[Magnus Melin [:mkmelin]]

Should be due to bug 1143569.

Comment 2

[WaltS48 [:walts48]]

Thunderbird 38.0b4, 38.0b5, 38.0b6, 38.0.1 candidate (build1) and 41.0a1 are not fixed by bug 1143569

I tried xposting and setting Folowup-To: in Mozilla newsgroups for the first time since I filed this bug using 38.0b6 today and noticed it wasn't fixed.

Comment 3

[Wayne Mery (:wsmwk)]

The questions I would ask are:
* is the _original_ issue cited by your bug fixed by bug 1143569?
* is your _current_ a problem _caused_ by the fix in bug 1143569?

Comment 4

[WaltS48 [:walts48]]

No, the _original_ issue is not fixed by bug 1143569.
No, the current problem existed before the fix, which is dated 2015-04-29 for Thunderbird 38, which is after 38.0b3 was released, and why I tested 38.0b4 and 38.0b5 with new test profiles for each yesterday, to see there might have been a regression.

Comment 5

[Kent James (:rkent)]

Whatever the issue here, WaltS48 is reporting this is still happening after the fix in bug 1143569, so either that bug needs reopening or this one. Let's reopen this one for now.

Comment 6

[WaltS48 [:walts48]]

I just completed some further testing and found this bug existed in Tb 37.0b1(BuildID:20150311003756), but not in TB 37.0a1(BuildID:20141231030200). I can't find Aurora builds to test.

Comment 7

[WaltS48 [:walts48]]

The first time this bug surfaces is with Thunderbird 37.0a1 (buildID:20150108030218). 

https://hg.mozilla.org/mozilla-central/rev/70de2960aa87

Comment 8

[Magnus Melin [:mkmelin]]

Confirmed on trunk. Seems I can't have more than one newsgroups.

Comment 9

[Magnus Melin [:mkmelin]]

Seems newsgroups headers that succeed (earlier) have

Newsgroups: mozilla.test,mozilla.test.multimedia


Newer, that fail have comma AND space
Newsgroups: mozilla.test, mozilla.test.multimedia

Comment 10

[Magnus Melin [:mkmelin]]

Attachment: bug1151448_newsgroups_comma.patch

We had a test for this, but unfortunately the test was incorrect. 

Yes, in theory [FWS] is allowed after the comma, but addText(foo, true) adds the extra space even if things end up on the same line.
I'd just say it's not a soft break point, with little harm really done. News peculiarities...

Comment 12

[Joshua Cranmer [:jcranmer]]

Comment on attachment 8621169 [details] [diff] [review]
bug1151448_newsgroups_comma.patch

Review of attachment 8621169 [details] [diff] [review]:
-----------------------------------------------------------------

::: mailnews/compose/test/unit/test_messageHeaders.js
@@ +263,5 @@
>    nntpServer.QueryInterface(Ci.nsINntpIncomingServer)
>      .subscribeToNewsgroup("mozilla.test");
>    let identity = getSmtpIdentity("[e-mail]",
>      getBasicSmtpServer());
> +  fields.newsgroups = "mozilla.test,mozilla.test.multimedia";

Keep the space in this line--it will confirm that the test folds a "a, b" to "a,b".

Comment 13

[Magnus Melin [:mkmelin]]

https://hg.mozilla.org/comm-central/rev/aaecae60620b -> FIXED

Comment 14

[Magnus Melin [:mkmelin]]

Comment on attachment 8621169 [details] [diff] [review]
bug1151448_newsgroups_comma.patch

Approval Request Comment
[Feature/regressing bug #]:js-mime
[User impact if declined]: can't post news posts to more than one group at once
[Describe test coverage new/current, TreeHerder]: xpcshell test
[Risks and why]: no risk

Comment 15

[Kent James (:rkent)]

Comment on attachment 8621169 [details] [diff] [review]
bug1151448_newsgroups_comma.patch

https://hg.mozilla.org/releases/comm-beta/rev/71c23450e64e
http://hg.mozilla.org/releases/comm-aurora/rev/291e12b9a709

Comment 16

[Kent James (:rkent)]

Comment on attachment 8621169 [details] [diff] [review]
bug1151448_newsgroups_comma.patch

http://hg.mozilla.org/releases/comm-esr38/rev/1db4c5ee3045

Comment 17

[Philip Chee]

http://hg.mozilla.org/releases/comm-release/rev/fd8425db2bfe SEAMONKEY_2_35_RELEASE_BRANCH

Comment 18

[Rainer Bielefeld]

VERIFIED with  SeaMonkey 2.39a1 Mozilla/5.0 (Windows NT 6.1; WOW64; rv:42.0 from official download area)  Gecko/20100101  Firefox/42.0  Build 20150721221150  (Classic Theme) on German WIN7 64bit

Comment 19

[Rainer Bielefeld]

To be honest, my verification only was concerning the ""A News (NNTP) error occurred: posting failed.""-Problem.
that indeed has vanished with EN-US SeaMonkey 2.35(γ)  (Windows NT 6.1; WOW64; rv:38.0)  Gecko/20100101 Build 20150722220804 (Classic Theme) on German WIN7 64bit.

But crosspostings still fail. 
Multiple "Newstroup:" recipients: no posting at all will reach NG
Followup-To: will be ignored, only at "Newstroup:" recipient posting will appear.
New bug? Do I misunderstand something?

Details:
--------
a) I did several attempts to send a posting to news.mozilla.org
Newsgroup: mozilla.support.seamonkey
Newsgroup: mozilla.addons.user-experience
Newsgroup: mozilla.dev.apps.seamonkey
Seamonkey always showed a "sent succesfully" and message became sent in "Local Folders - Sent", but no message appeared in the NG

b) I did 1 attempt to send a posting to
Newsgroup: mozilla.support.seamonkey
Followup-To: mozilla.addons.user-experience
Followup-To: mozilla.dev.apps.seamonkey
Seamonkey showed a "sent succesfully" and message became sent in "Local Folders - Sent", but no message appeared in the followup-NG

c) I did 1 attempt to send a posting to News.Individual.DE
Newsgroup: alt.de.test
Followup-To: alt.fr.test
Seamonkey showed a "sent succesfully" and message became sent in "Local Folders - Sent", but no message appeared in the followup-NG

d) Now here I clicked "Reply All" Icon to the successful posting form (b) "SeaMonkey Add-on compatibility", but in the aswer message "mozilla.support.seamonkey" was missing, only Followup-To-Newsgroups appeared in address fields.