1151561 - [Contacts] Contacts that were merged from the Dialer app will briefly appear separate the next time the Contacts app is launched.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Martin Shuman [:Marty]]

Attachment: logcat-contact-dialer-merge.txt

Description:
If the user merges two contacts from the dialer by selecting 'add to existing contact,' the next time the Contacts app is launched, both contacts will be visible for a few seconds.

The extra contact is not selectable

Repro Steps:
1) Update a Flame to 20150406010204
2) Open the Contacts app and create a contact named 'test' with a phone number.
3) Create a second contact named 'new' without a phone number
4) Close the Contacts app and launch the Dialer app
5) Enter in the same phone number for the 'test' contact, and tap the 'add contact' icon.
6) Select 'add to existing contact' and select the 'new' contact. Confirm merging with 'test'
7) close the Dialer app and relaunch the Contacts app.


Actual:
Both 'test' and 'new' contacts are visible for several seconds before only 'new is visible'

Expected:
Only 'new' is visible when launching the Contacts app.

Environmental Variables:
Device: Flame 3.0 (319MB)(Full Flash)
Build ID: 20150406010204
Gaia: ef61ebbe5de8c2c9fc2a8f74a12455044c3b82e9
Gecko: 4fe763cbe196
Gonk: b83fc73de7b64594cd74b33e498bf08332b5d87b
Version: 40.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:40.0) Gecko/40.0 Firefox/40.0

Repro frequency: 8/8
See attached: Video (URL), Logcat

Comment 1

[Martin Shuman [:Marty]]

This issue DOES occur on Flame 2.2 builds.
Both contacts are briefly visible when launching Contacts app after merging them together in Dialer.

Environmental Variables:
Device: Flame 2.2 (319MB)(Full Flash)
Build ID: 20150406002503
Gaia: a6351e1197d54f8624523c2db9ba1418f2aa046f
Gecko: c3335a5d3063
Gonk: ebad7da532429a6f5efadc00bf6ad8a41288a429
Version: 37.0 (2.2)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Comment 2

[Johan Lorenzo [:jlorenzo]]

It looks like the cache is not evicted in that case. What do you think, Fernando?

Comment 3

[Fernando Jiménez Moreno [:ferjm]]

The cache is evicted, but we don't do it until we are in the Contacts app. Not sure if we can do better. I'll take a look.

Comment 4

[Fernando Jiménez Moreno [:ferjm]]

I fixed this one as part of bug 1150220

Comment 5

[Johan Lorenzo [:jlorenzo]]

Verify me once bug 1150220 lands.

Comment 6

[Pi Wei Cheng [:piwei] (inactive)]

Bug 1150220 is verified fixed but it didn't fix this bug. Re-opening.

Comment 7

[Pi Wei Cheng [:piwei] (inactive)]

Removing verifyme keyword because the bug is not fixed.

Comment 8

[GitHub Autolander Bot]

Attachment: [gaia] ferjm:bug1151561.merged.contacts.cached > mozilla-b2g:master

Comment 9

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8593289 [details] [review]
[gaia] ferjm:bug1151561.merged.contacts.cached > mozilla-b2g:master

LGTM, tried on the phone and working.

Comment 10

[GitHub Autolander Bot]

https://github.com/mozilla-b2g/gaia/pull/29544

Autolander could not land the pull request due to not having collaborator rights. This is possibly due to a tree closure. Please check the tree status and request checkin again once the tree is open.

Comment 11

[Francisco Jordano [:arcturus] [:francisco]]

Landed:

https://github.com/mozilla-b2g/gaia/commit/2e8b468d6ec3164cd49347d0488d4416f979395f

Comment 12

[helen（leave from Mozilla）]

Attachment: v3.0.mp4

This bug has been verified as pass on latest build of Flame v3.0 & Nexus 5 v3.0 by the STR in Comment 0. 

Results:
Only 'new' is visible when launch the Contacts app after merging two Contacts.

See attachment: v3.0.mp4
Reproduce rate: 0/10

Device: Flame v3.0(Pass)
Build ID               20150531160203
Gaia Revision          e6dc0f4c583407a4a52a66ce7cb11f058302a762
Gaia Date              2015-05-29 17:20:26
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/f8d21278244b
Gecko Version          41.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150531.192324
Firmware Date          Sun May 31 19:23:35 EDT 2015
Bootloader             L1TC000118D0


Device:Nexus 5 v3.0(Pass)
Build ID               20150531160203
Gaia Revision          e6dc0f4c583407a4a52a66ce7cb11f058302a762
Gaia Date              2015-05-29 17:20:26
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/f8d21278244b
Gecko Version          41.0a1
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.cltbld.20150531.192050
Firmware Date          Sun May 31 19:21:07 EDT 2015
Bootloader             HHZ12f