1151871 - Links with the same domain can not be added to Reading List

Status: RESOLVED INVALID

(Firefox Graveyard :: Reading List, defect, P3)

Description

[Petruta Horea [:phorea]]

Reproducible on Firefox 38 beta 2 (20150406174117), latest Dev Edition 39.0a2 (20150407004006) and latest Nightly 40.0a1 (20150406030204) under Ubuntu 14.04 32-bit, Win 7 32-bit and Mac OS X 10.8.5.

Steps to reproduce:
- Open YouTube playlist (eg https://www.youtube.com/watch?v=OkSyXfsXSzo&list=PLsH19NHPTD44m-5CCyx5jKLKAGir3iL2L&index=3) and add several videos to reading list using the "+" icon from the url bar
- Open a video from vimeo (eg https://vimeo.com/channels/staffpicks/122258599) and add it to reading list. Open another video from the page and add it too (https://vimeo.com/channels/staffpicks/97205916)
- Open a photo from a Facebook album and add it to the list. Select Next/Prev and add another photo to the list (eg https://www.facebook.com/Firefox/photos/a.145889545021.235126.14696440021/10152367676420022/?type=3&theater)

Expected results:
All links can be added in reading list

Actual results:
In all cases, only the first link is added to the list. 
I don't know if it's related to website's domain because if the link is opened in a new tab it will be added to the reading list.

Browser Console error:
Full Message: ReadingListExistsError: An item with the following property already exists: resolvedURL
Full Stack: ReadingListError@resource:///modules/readinglist/ReadingList.jsm:96:17
ReadingListExistsError@resource:///modules/readinglist/ReadingList.jsm:106:3
throwExistsError@resource:///modules/readinglist/SQLiteStore.jsm:312:18
this.SQLiteStore.prototype.addItem<@resource:///modules/readinglist/SQLiteStore.jsm:99:7
TaskImpl_run@resource://gre/modules/Task.jsm:315:40

Comment 1

[Justin Dolske [:Dolske]]

I can't reproduce this with a normal news site like sfgate.com, adding multiple articles works fine..

I suspect this is a similar history pushState issue, as bug 1151845.

cc markh regarding the error message.

Comment 2

[Mark Hammond [:markh] [:mhammond]]

As Dolske said, probably either the same underlying issue as bug 1151845, or alternatively, given it's "resolvedURL", it may be that one of the sites has a bad <link rel="canonical"...> (or similar) entry, with multiple pages pointing to the same canonical URL (which IIRC is where we get resolvedURL from).

Petruta, can you please try and narrow this down to which exact 2 pages can be used to reproduce this and attach readinglist logs - see https://id.etherpad.mozilla.org/readinglist-testing

Comment 3

[Petruta Horea [:phorea]]

Attachment: logs and console's errors

I used vimeo links to track this. Please note that they must be opened in the same tab, using links from the page. Here - vimeo staff picks links that are displayed in gallery.

I started with https://vimeo.com/channels/staffpicks/121359776 (The Darkest Truth..) that was successfully added to Reading List.
I selected then https://vimeo.com/channels/staffpicks/120554483 (Strange Babes..) that wasn't added to Reading List. Same thing happened next with https://vimeo.com/channels/staffpicks/124038805 (Dark Horse..). 

The "+" sign is shown in the url bar for all the videos that are opened after the one that was added.

Comment 4

[Mark Hammond [:markh] [:mhammond]]

Yeah, I suspect this is the same issue as bug 1151845. The symptoms are that the content scripts are seeing the previous page - so all the metadata we get back from PageMetadata.jsm is for the old page - which includes .resolvedURL. The URL itself comes from the chrome code, so this is the only correct element. Note this also reproduces in a non-e10s window, so while it's seems related to child processes it's not specific to e10s being enabled.

One reason I believe this might be history state related is that (a) nsHistory::PushState() is called as you navigate (and passed the URL you are navigating to), and if you disable that by setting the pref browser.history.allowPushState=false the navigation fails to work at all.

Dolske, I think this is something we should try and escalate, but I'm not sure where to start - any ideas?

Comment 5

[Mark Hammond [:markh] [:mhammond]]

heh - I guess I should just open a bug? ;) Bug 1154638.

Comment 6

[Mark Hammond [:markh] [:mhammond]]

Closing some old readinglist bugs.