1152230 - [RTL][Notifications]The ellipsis is displayed at left side of message content in message notification.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect, P2)

Description

[Lancy(Leave from Mozilla)]

[1.Description]:
[RTL][v2.2&v3.0][Notifications]Recieve a message with long LTR text, the ellipsis is displayed at left side of message content in message notification.
See attachment:Screenshot_ellipsis.png

[2.Testing Steps]: 
1.Set your phone language to Arabic and insert one or two sim card to test device.
2.Recieve a message with long LTR text from another device.
3.Open notification and observe the message notification.

[3.Expected Result]: 
3.The ellipsis should be displayed at right side of message content.

[4.Actual Result]: 
3.The ellipsis is displayed at left side of message content.

[5.Reproduction build]: 
Flame 2.2 build(Affected):
Build ID               20150407162504
Gaia Revision          ea735c21bfb0d78333213ff0376fce1eac89ead6
Gaia Date              2015-04-07 20:58:15
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/3f86ddb7f719
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150407.195227
Firmware Date          Tue Apr  7 19:52:39 EDT 2015
Bootloader             L1TC000118D0

Flame 3.0 build (Affected):
Build ID               20150407160201
Gaia Revision          84cbd4391fb7175d5380fa72c04d68873ce77e6d
Gaia Date              2015-04-07 17:33:14
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/078128c2600a
Gecko Version          40.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150407.193600
Firmware Date          Tue Apr  7 19:36:12 EDT 2015
Bootloader             L1TC000118D0

[6.Reproduction Frequency]: 
Always Recurrence,10/10

[7.TCID]: 
15559

Comment 1

[Lancy(Leave from Mozilla)]

Attachment: Screenshot_ellipsis.png

Comment 2

[Julien Wajsberg [:julienw]]

yet another manifestation of bug 883884 that we'll need to workaround using nested containers.

Comment 3

[Delphine Lebédel [:delphine - Use needinfo]]

Triage P2. See also Bug 1152222

Comment 4

[Josh Cheng [:josh]]

Hi Gregor,
Can you help to find someone who can fix this? Thanks!

Comment 6

[GitHub Autolander Bot]

Attachment: [gaia] mikehenrty:bug-1152230-ellipses-sides > mozilla-b2g:master

Comment 7

[Michael Henretty [:mikehenrty][:mhenretty]]

Added a WIP patch that is based on the fix from bug 1152228.

Comment 8

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8591165 [details] [review]
[gaia] mikehenrty:bug-1152230-ellipses-sides > mozilla-b2g:master

Now that bug 1152228 has landed, this one is ready for review. Alive, Greg, could you take a look at this one too?

Comment 9

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8591165 [details] [review]
[gaia] mikehenrty:bug-1152230-ellipses-sides > mozilla-b2g:master

I like simple patch.

Comment 10

[Greg Weng [:snowmantw][:gweng][:λ]]

The LockScreen part is good, but for 'notifications.js' would you mind to add or modify the existing test? Since for System app we need to submit one unit test patch per patch, at least that's I were required to review.

Comment 11

[Michael Henretty [:mikehenrty][:mhenretty]]

Good call Greg, I added an assert to the notification dir stuff. I also needed to fix some marionette query selectors.

Comment 12

[Greg Weng [:snowmantw][:gweng][:λ]]

Comment on attachment 8591165 [details] [review]
[gaia] mikehenrty:bug-1152230-ellipses-sides > mozilla-b2g:master

Nice, thanks a lot.

Comment 13

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/b7ba4fb8edf10483a7e2cac2c94cf758591b54db

Comment 14

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8591165 [details] [review]
[gaia] mikehenrty:bug-1152230-ellipses-sides > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
Probably not a regression.

[User impact] if declined:
Ellipses are displayed on the wrong side for notifications in RTL languages which LTR content.

[Testing completed]:
Manually tested, and updated some unit tests.

[Risk to taking this patch] (and alternatives if risky):
The risk is to how we display notifications, mostly to look of utility tray.

[String changes made]: none.

Comment 15

[Sue]

Attachment: v3.0_verified_passed.png

This issue has been verified passed on latest build of Flame 3.0 with the same steps in comment 0.
See attachment:v3.0_verified_passed.png
Rate:0/3

Device: Flame 3.0 (pass)
Build ID               20150419160202
Gaia Revision          c6b04efa0f31a584e6ee0a46dd2b64c1e3c29adc
Gaia Date              2015-04-17 21:10:53
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/a32e3b93c8d8
Gecko Version          40.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150419.193329
Firmware Date          Sun Apr 19 19:33:40 EDT 2015
Bootloader             L1TC000118D0

Comment 16

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/828dd03a0e3b140d74b2e49355197df4d91d9227

Comment 17

[Sue]

Attachment: v2.2_verified_pass.png

This issue has been verified passed on latest build of Flame 2.2 with the same steps in comment 0.
See attachment:v2.2_verified_pass.png
Rate:0/5

Device: Flame 2.2 (pass)
Build ID               20150421162504
Gaia Revision          41a85c5f9db291d4f7c0e94c8416b5115b4ee407
Gaia Date              2015-04-21 17:23:41
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/e40544535399
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150421.200455
Firmware Date          Tue Apr 21 20:05:07 EDT 2015
Bootloader             L1TC000118D0

Comment 18

[Sue]

Test case has been added in moztrap:
https://moztrap.mozilla.org/manage/case/15559/