1152694 - Make UUID and service name as input arguments for |BluetoothSocket::ConnectSocket| and |BluetoothSocket::ListenSocket|

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Bluetooth, defect)

Description

[Ben Tian (inactive)]

Taking UUID and service name as input arguments in |BluetoothSocket::ConnectSocket| and |BluetoothSocket::ListenSocket| allows BluetoothSocket to handle services other than OBEX object push.

Comment 1

[Ben Tian (inactive)]

Attachment: Patch 1 (v1): Make UUID and service name as input arguments for BluetoothSocket

The patch affects both bluetooth and bluetooth2.

Comment 2

[Ben Tian (inactive)]

Attachment: Patch 1 (v2): Make UUID and service name as input arguments for BluetoothSocket

Rebase on bug 1146355.

Thomas, can you help review my patch? The patch makes UUID and service name as input arguments to allow BluetoothSocket for services besides OBEX object push.

Comment 3

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Comment on attachment 8590606 [details] [diff] [review]
Patch 1 (v2): Make UUID and service name as input arguments for BluetoothSocket

Review of attachment 8590606 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. Could you update the BlueZ code accordingly? It doesn't have to do anything, just that the interfaces for |Connect| and |Listen| are the same.

Comment 4

[Ben Tian (inactive)]

(In reply to Thomas Zimmermann [:tzimmermann] [:tdz] from comment #3)
> Looks good. Could you update the BlueZ code accordingly? It doesn't have to
> do anything, just that the interfaces for |Connect| and |Listen| are the
> same.

The interface change also impacts BlueZ HFP and OPP managers that use socket. Do you prefer to 1) pass redundant arguments in HFP and OPP managers, or 2) add another set of |Connect| and |Listen| as original interface to stuff arguments for these managers? Also do you want the BlueZ socket interface change for future backend integration?

Comment 5

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Hi Ben,

In order to keep the number of API differences between bluez/ and bluedroid/ small, I'd prefer option 1).

For the future of BlueZ, I implemented bug 1088574. It provides BlueZ behind the backend interfaces of BluetothInterface.{cpp,h}. With these patches, the class  |BluetoothSocket| comes from the current implementation in bluedroid/.

Comment 6

[Ben Tian (inactive)]

Attachment: [final] Patch 1: Make UUID and service name as input arguments for BluetoothSocket, r=tzimmermann

Revise based on reviewer's comment.

Comment 7

[Ben Tian (inactive)]

try server result: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b0f2e21b41d4

Comment 8

[Ben Tian (inactive)]

https://hg.mozilla.org/integration/b2g-inbound/rev/2434909a42e3

Comment 9

[Ryan VanderMeulen (PTO, back July 27)]

https://hg.mozilla.org/mozilla-central/rev/2434909a42e3

Comment 10

[Ben Tian (inactive)]

Wesley, please help mark this bug feature-b2g:2.2r since BT feature PBAP depends on this bug.

Comment 11

[Ben Tian (inactive)]

Attachment: [2.2r] Patch 1: Make UUID and service name as input arguments for BluetoothSocket, r=tzimmermann

Upload patch for 2.2r.

Comment 12

[Ryan VanderMeulen (PTO, back July 27)]

https://hg.mozilla.org/releases/mozilla-b2g37_v2_2r/rev/05e75d5495a4