Closed Bug 1152694 Opened 5 years ago Closed 5 years ago

Make UUID and service name as input arguments for |BluetoothSocket::ConnectSocket| and |BluetoothSocket::ListenSocket|

Categories

(Firefox OS Graveyard :: Bluetooth, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(feature-b2g:2.2r+, firefox40 fixed, b2g-v2.2r fixed)

RESOLVED FIXED
2.2 S10 (17apr)
feature-b2g 2.2r+
Tracking Status
firefox40 --- fixed
b2g-v2.2r --- fixed

People

(Reporter: ben.tian, Assigned: ben.tian)

References

Details

Attachments

(2 files, 2 obsolete files)

Taking UUID and service name as input arguments in |BluetoothSocket::ConnectSocket| and |BluetoothSocket::ListenSocket| allows BluetoothSocket to handle services other than OBEX object push.
Summary: Make UUID and service name input arguments for |BluetoothSocket::ConnectSocket| and |BluetoothSocket::ListenSocket| → Make UUID and service name as input arguments for |BluetoothSocket::ConnectSocket| and |BluetoothSocket::ListenSocket|
The patch affects both bluetooth and bluetooth2.
Assignee: nobody → btian
Rebase on bug 1146355.

Thomas, can you help review my patch? The patch makes UUID and service name as input arguments to allow BluetoothSocket for services besides OBEX object push.
Attachment #8590162 - Attachment is obsolete: true
Attachment #8590606 - Flags: review?(tzimmermann)
Comment on attachment 8590606 [details] [diff] [review]
Patch 1 (v2): Make UUID and service name as input arguments for BluetoothSocket

Review of attachment 8590606 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. Could you update the BlueZ code accordingly? It doesn't have to do anything, just that the interfaces for |Connect| and |Listen| are the same.
Attachment #8590606 - Flags: review?(tzimmermann) → review+
(In reply to Thomas Zimmermann [:tzimmermann] [:tdz] from comment #3)
> Looks good. Could you update the BlueZ code accordingly? It doesn't have to
> do anything, just that the interfaces for |Connect| and |Listen| are the
> same.

The interface change also impacts BlueZ HFP and OPP managers that use socket. Do you prefer to 1) pass redundant arguments in HFP and OPP managers, or 2) add another set of |Connect| and |Listen| as original interface to stuff arguments for these managers? Also do you want the BlueZ socket interface change for future backend integration?
Flags: needinfo?(tzimmermann)
Hi Ben,

In order to keep the number of API differences between bluez/ and bluedroid/ small, I'd prefer option 1).

For the future of BlueZ, I implemented bug 1088574. It provides BlueZ behind the backend interfaces of BluetothInterface.{cpp,h}. With these patches, the class  |BluetoothSocket| comes from the current implementation in bluedroid/.
Flags: needinfo?(tzimmermann)
Revise based on reviewer's comment.
Attachment #8590606 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/2434909a42e3
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.2 S10 (17apr)
Wesley, please help mark this bug feature-b2g:2.2r since BT feature PBAP depends on this bug.
Depends on: 1158081
Flags: needinfo?(whuang)
feature-b2g: --- → 2.2r+
Flags: needinfo?(whuang)
Blocks: 1159179
You need to log in before you can comment on or make changes to this bug.