1154188 - security/certverifier/NSSCertDBTrustDomain.cpp:824:3: error: 'UniquePtr' was not declared in this scope (non-SPS)

Status: RESOLVED FIXED

(Core :: Security: PSM, defect)

Description

[Jan Beich]

SPS has the following bootlegging thanks to bug 1151829

  security/certverifier/Unified_cpp_certverifier0.cpp:20:
  security/certverifier/NSSCertDBTrustDomain.cpp:15:
  security/certverifier/../manager/ssl/src/nsNSSCertificate.h:14:
  security/certverifier/../manager/ssl/src/nsNSSShutDown.h:11:
  dist/include/mozilla/CondVar.h:16:
  dist/include/GeckoProfiler.h:204:
  dist/include/GeckoProfilerImpl.h:16:
  dist/include/mozilla/UniquePtr.h

on platforms lacking SPS profiler (Linux/PPC, BSDs, Solaris) it leads to

  In file included from security/certverifier/Unified_cpp_certverifier0.cpp:20:
  security/certverifier/NSSCertDBTrustDomain.cpp:824:3: error:
        use of undeclared identifier 'UniquePtr'
    UniquePtr<char, void(&)(char*)>
    ^
  security/certverifier/NSSCertDBTrustDomain.cpp:824:17: error:
        expected '(' for function-style cast or type construction
    UniquePtr<char, void(&)(char*)>
              ~~~~^
  security/certverifier/NSSCertDBTrustDomain.cpp:824:25: error:
        expected expression
    UniquePtr<char, void(&)(char*)>
                          ^
  security/certverifier/NSSCertDBTrustDomain.cpp:824:31: error:
        expected '(' for function-style cast or type construction
    UniquePtr<char, void(&)(char*)>
                            ~~~~^
  security/certverifier/NSSCertDBTrustDomain.cpp:824:32: error:
        expected expression
    UniquePtr<char, void(&)(char*)>
                                 ^
  security/certverifier/NSSCertDBTrustDomain.cpp:825:5: error:
        use of undeclared identifier 'fullLibraryPath'
      fullLibraryPath(PR_GetLibraryName(dir, "nssckbi"), PR_FreeLibraryName);
      ^
  security/certverifier/NSSCertDBTrustDomain.cpp:826:8: error:
        use of undeclared identifier 'fullLibraryPath'
    if (!fullLibraryPath) {
         ^
  ...

Comment 1

[Jan Beich]

Attachment: explicit #include

inb4 bug 903843 is done more regularly

https://treeherder.mozilla.org/#/jobs?repo=try&revision=151d80ff94c5

Comment 2

[Landry Breuil (:gaston)]

FFS... failures are just piling on top of each other. Can ppl stop messing up with those damn headers ?

Comment 3

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Comment on attachment 8592125 [details] [diff] [review]
explicit #include

Review of attachment 8592125 [details] [diff] [review]:
-----------------------------------------------------------------

::: security/certverifier/NSSCertDBTrustDomain.cpp
@@ +12,3 @@
>  #include "ExtendedValidation.h"
>  #include "OCSPRequestor.h"
>  #include "certdb.h"

Please put the include of mozilla/UniquePtr.h here (alphabetical order)

Comment 4

[Landry Breuil (:gaston)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/eac5e76f9280

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/eac5e76f9280