security/certverifier/NSSCertDBTrustDomain.cpp:824:3: error: 'UniquePtr' was not declared in this scope (non-SPS)

RESOLVED FIXED in Firefox 40

Status

()

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: jbeich, Assigned: jbeich)

Tracking

Trunk
mozilla40
All
FreeBSD
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox40 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
SPS has the following bootlegging thanks to bug 1151829

  security/certverifier/Unified_cpp_certverifier0.cpp:20:
  security/certverifier/NSSCertDBTrustDomain.cpp:15:
  security/certverifier/../manager/ssl/src/nsNSSCertificate.h:14:
  security/certverifier/../manager/ssl/src/nsNSSShutDown.h:11:
  dist/include/mozilla/CondVar.h:16:
  dist/include/GeckoProfiler.h:204:
  dist/include/GeckoProfilerImpl.h:16:
  dist/include/mozilla/UniquePtr.h

on platforms lacking SPS profiler (Linux/PPC, BSDs, Solaris) it leads to

  In file included from security/certverifier/Unified_cpp_certverifier0.cpp:20:
  security/certverifier/NSSCertDBTrustDomain.cpp:824:3: error:
        use of undeclared identifier 'UniquePtr'
    UniquePtr<char, void(&)(char*)>
    ^
  security/certverifier/NSSCertDBTrustDomain.cpp:824:17: error:
        expected '(' for function-style cast or type construction
    UniquePtr<char, void(&)(char*)>
              ~~~~^
  security/certverifier/NSSCertDBTrustDomain.cpp:824:25: error:
        expected expression
    UniquePtr<char, void(&)(char*)>
                          ^
  security/certverifier/NSSCertDBTrustDomain.cpp:824:31: error:
        expected '(' for function-style cast or type construction
    UniquePtr<char, void(&)(char*)>
                            ~~~~^
  security/certverifier/NSSCertDBTrustDomain.cpp:824:32: error:
        expected expression
    UniquePtr<char, void(&)(char*)>
                                 ^
  security/certverifier/NSSCertDBTrustDomain.cpp:825:5: error:
        use of undeclared identifier 'fullLibraryPath'
      fullLibraryPath(PR_GetLibraryName(dir, "nssckbi"), PR_FreeLibraryName);
      ^
  security/certverifier/NSSCertDBTrustDomain.cpp:826:8: error:
        use of undeclared identifier 'fullLibraryPath'
    if (!fullLibraryPath) {
         ^
  ...
(Assignee)

Comment 1

3 years ago
Created attachment 8592125 [details] [diff] [review]
explicit #include

inb4 bug 903843 is done more regularly

https://treeherder.mozilla.org/#/jobs?repo=try&revision=151d80ff94c5
Attachment #8592125 - Flags: review?(brian)
FFS... failures are just piling on top of each other. Can ppl stop messing up with those damn headers ?
Comment on attachment 8592125 [details] [diff] [review]
explicit #include

Review of attachment 8592125 [details] [diff] [review]:
-----------------------------------------------------------------

::: security/certverifier/NSSCertDBTrustDomain.cpp
@@ +12,3 @@
>  #include "ExtendedValidation.h"
>  #include "OCSPRequestor.h"
>  #include "certdb.h"

Please put the include of mozilla/UniquePtr.h here (alphabetical order)
Attachment #8592125 - Flags: review?(brian) → review+
https://hg.mozilla.org/mozilla-central/rev/eac5e76f9280
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox40: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
(Assignee)

Updated

3 years ago
Assignee: nobody → jbeich
You need to log in before you can comment on or make changes to this bug.