1154218 - Get rid of webapprt's downloads-aero.css

Status: RESOLVED FIXED

(Firefox Graveyard :: Webapp Runtime, defect)

Description

[Alfred Kayser]

downloads-aero.css can easily be removed.
It only adds some rules specifically to aero protected by "@media (-moz-windows-compositor) {".

Comment 1

[Alfred Kayser]

It is the on;y -aero.css left, so removing this will remove this aero dependency to overrides for .css files

Comment 2

[Dão Gottwald [:dao]]

There's no such file in the Firefox theme. Toolkit's downloads-aero.css has been removed in bug 1150006.

Comment 3

[:Gijs (he/him)]

Ugh, the component story here is super confusing.

Comment 4

[:Gijs (he/him)]

Attachment: MozReview Request: bz://1154218/Gijs

/r/7023 - Bug 1154218 - get rid of webapprt's downloads-aero.css, r?dao,baku

Pull down this commit:

hg pull -r 0af11f1e1037a24d20a1d2787c74787a6c549fe6 https://reviewboard-hg.mozilla.org/gecko/

Comment 5

[:Gijs (he/him)]

Apologies for the binary file stupidities, but I'm hoping that at least now with the actual cset I won't have trouble committing this like Dão did with some previous bugs. Essentially what the change is doing is moving the non-suffixed assets to -XP, and the -aero-suffixed assets to be unsuffixed, and then updating the overrides to be XP-only. This matches what we've done in the main browser theme and should make it easier to maintain the code in conjunction with the browser code.

Comment 6

[Andrea Marchesini [:baku]]

Comment on attachment 8592204 [details]
MozReview Request: bz://1154218/Gijs

I cannot review this code. Sorry.

Comment 7

[:Gijs (he/him)]

Comment on attachment 8592204 [details]
MozReview Request: bz://1154218/Gijs

Eh, sorry, wrong reviewer. Thanks for responding so quickly!

Comment 8

[Marco Castelluccio [:marco]]

Comment on attachment 8592204 [details]
MozReview Request: bz://1154218/Gijs

Assuming the image changes are correct (I don't know yet how this new review tool works, the image changes are stripped from the diff file) and the patch has been tested, this looks good to me.

Comment 9

[:Gijs (he/him)]

(In reply to Marco Castelluccio [:marco] from comment #8)
> Comment on attachment 8592204 [details]
> MozReview Request: bz://1154218/Gijs
> 
> Assuming the image changes are correct (I don't know yet how this new review
> tool works, the image changes are stripped from the diff file) and the patch
> has been tested, this looks good to me.

I am pretty sure the code changes are correct from a logical perspective, but I have no idea how to test this. How can I test this? :-)

Comment 10

[Marco Castelluccio [:marco]]

Attachment: testdownload.zip

You can simply host this app somewhere (localhost for example), install it, launch it and then see if downloading still works.

Comment 11

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/4f271f5de1c4

Comment 12

[:Gijs (he/him)]

(In reply to Marco Castelluccio [:marco] from comment #10)
> Created attachment 8593881 [details]
> testdownload.zip
> 
> You can simply host this app somewhere (localhost for example), install it,
> launch it and then see if downloading still works.

Thanks! Had to tweak it a bit, but worked it out in the end. Tested and landed.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4f271f5de1c4

Comment 15

[:Gijs (he/him)]

Attachment: MozReview Request: Bug 1154218 - get rid of webapprt's downloads-aero.css, r?dao,baku