1154614 - [Flame][Settings]Try to rename my device in Settings->Bluetooth,system is hang.

Status: VERIFIED FIXED

(Core :: Panning and Zooming, defect)

Description

[Elie]

[1.Description]:
[Flame][v3.0][Settings]Enter Settings->bluetooth,enable bluetooth and Visible to all,try to rename device,tap input box,system is crash,press power key/volume key/tap screen,there is no response.
Attachment:VIDEO0351_Compress.MP4 and logcat(16).txt
Happen time: 6:29

[2.Testing Steps]: 
1.Launch Settings
2.Tap Bluetooth
3.Toggle on bluetooth and toggle on Visible to all
4.Tap "Rename my device",try to rename device

[3.Expected Result]: 
5.You can rename device successfully.

[4.Actual Result]: 
4.The device is hang,press power key/volume key/tap screen,there is no response.

[5.Reproduction build]: 
Flame 3.0 (affected):
Build ID               20150414160204
Gaia Revision          8e28588496f82f8f069c171c65842d622b9d8d7d
Gaia Date              2015-04-14 18:43:50
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/de27ac2ab94f
Gecko Version          40.0a1
Device Name            flame
Firmware(Release)      4.4.2
[6.Reproduction Frequency]: 
Always Recurrence,5/5

[7.TCID]: 
Free Test

Comment 1

[Elie]

Attachment: VIDEO0351_Compress.MP4

Comment 2

[Elie]

Attachment: logcat(16).txt

Comment 3

[William Hsu [:whsu]]

A v3.0 regression.

Add tag -"regression" & "regressionwindow-wanted"

Comment 4

[[e-mail], [e-mail]]

Hi Elie, I think the problem is relative with input focus. Is the problem only happened in this specific user story(settings::bluetooth::rename)? Are you able to reproduce it from other input field? Thanks.

Comment 5

[Elie]

(In reply to Ian Liu [:ianliu] from comment #4)
> Hi Elie, I think the problem is relative with input focus. Is the problem
> only happened in this specific user story(settings::bluetooth::rename)? Are
> you able to reproduce it from other input field? Thanks.

Hi Lan
I tried to invoke keyboard in Clock/contact/Message/Mail/E.me/SIM PIN input/Wifi,and input some words to input box,It looks well. Till now,I found this issue only happened in Settings->BT->Rename my device.
Thanks.

Comment 6

[[e-mail], [e-mail]]

Elie, Thanks for your info. We can focus on what settings::bluetooth panel have done. Then, we are stuck in the hanged issue.

Comment 7

[[e-mail], [e-mail]]

Hi Xulei, Could you please help to investigate the issue? I cannot grep any console log and other operation while the issue is happened. Thanks.

Comment 8

[[e-mail], [e-mail]]

I find out the problem is coming from access <input type="text">. If we don't access the input instance 'updateNameInput'[1], the platform won't be hanged.

Xulei, I try to mark out these code which is accessed with 'updateNameInput'. Then, the dialog show/hide normally. Not sure these info is helpful for you.

[1] https://github.com/mozilla-b2g/gaia/blob/master/apps/settings/js/bluetooth.js#L90-L95

Comment 9

[William Hsu [:whsu]]

[Blocking Requested - why for this release]:

A basic function is broken.

Comment 10

[William Hsu [:whsu]]

Caused by APZ related patches.(Bug 1154130)

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Mozilla-inbound Regression Window:

Last Working Environmental Variables:
Device: Flame 3.0
BuildID:    20150414091119
Gaia:       c8cb0c0ebb8dd1f5c0c9037e38f8e4b237beb77b
Gecko:      598ccd9bc144
Version:    40.0a1 (3.0) 
Firmware:   v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:40.0) Gecko/40.0 Firefox/40.0

First Broken Environmental Variables:
Device:     Flame 3.0
BuildID:    20150414092719
Gaia:       c8cb0c0ebb8dd1f5c0c9037e38f8e4b237beb77b
Gecko:      879e74f2e74c
Version:    40.0a1 (3.0) 
Firmware:   v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:40.0) Gecko/40.0 Firefox/40.0

Last Working Gaia First Broken Gecko: Issue DOES reproduce 
Gaia:  c8cb0c0ebb8dd1f5c0c9037e38f8e4b237beb77b
Gecko: 879e74f2e74c

First Broken Gaia Last Working Gecko: Issue does NOT reproduce
Gaia: 3c68964cb9fdba7cf0f6829b7f44562acaf1f1d7
Gecko: 6562cb71c376

Comment 11

[William Hsu [:whsu]]

Caused by APZ related patches.(Bug 1154130)

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Mozilla-inbound Regression Window:

Last Working Environmental Variables:
Device: Flame 3.0
BuildID:    20150414091119
Gaia:       c8cb0c0ebb8dd1f5c0c9037e38f8e4b237beb77b
Gecko:      598ccd9bc144
Version:    40.0a1 (3.0) 
Firmware:   v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:40.0) Gecko/40.0 Firefox/40.0

First Broken Environmental Variables:
Device:     Flame 3.0
BuildID:    20150414092719
Gaia:       c8cb0c0ebb8dd1f5c0c9037e38f8e4b237beb77b
Gecko:      879e74f2e74c
Version:    40.0a1 (3.0) 
Firmware:   v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:40.0) Gecko/40.0 Firefox/40.0

Last Working Gaia First Broken Gecko: Issue DOES reproduce 
Gaia:  c8cb0c0ebb8dd1f5c0c9037e38f8e4b237beb77b
Gecko: 879e74f2e74c

First Broken Gaia Last Working Gecko: Issue does NOT reproduce
Gaia: c8cb0c0ebb8dd1f5c0c9037e38f8e4b237beb77b
Gecko: 598ccd9bc144

Comment 12

[Kartikaya Gupta (email:[e-mail])]

Attachment: Thread backtrace

I can look into this.

Comment 13

[William Hsu [:whsu]]

Appreciated!
Thanks Kartikaya! :)

Comment 14

[Kartikaya Gupta (email:[e-mail])]

Attachment: Patch

GetIndirectShadowTree tries to grab the lock, so holding the lock prior to calling it is a bad idea. I just rearranged this method to be consistent with the other nearby functions, which I think should be correct.

Comment 17

[David Anderson [:dvander] - inactive, e-mail if emergency]

Comment on attachment 8592833 [details] [diff] [review]
Patch

Review of attachment 8592833 [details] [diff] [review]:
-----------------------------------------------------------------

Whoops, sorry about that.

Comment 18

[Kartikaya Gupta (email:[e-mail])]

Landed directly on m-c so we can get new nightlies with the fix.

https://hg.mozilla.org/mozilla-central/rev/11077895df62

Comment 20

[Peter Bylenga [:PBylenga]]

Moving markers over.

Also see below:
This issue is locking up the phone in several different areas. Here is a current list of known affected areas:

-Calendar when switching to Week or Day view
-Settings app, specifically in Sim Manager, as well as possibly in Bluetooth
-Email, on the Google sign in page, Manual Set Up page, and when changing to a second account in the Drawer.

Comment 21

[Yeojin Chung [:YeojinC]]

This issue is verified fixed on Flame Master.

Result: Device functions properly without any issue when following STRs from Comment 0 and Comment 20.

Environmental Variables:
Device: Flame 3.0 (KK, 319mb, full flash)
Build ID: 20150415095209
Gaia: 2dd89fef4fae4d86fd313037ef384086c2e0e8a5
Gecko: 11077895df62
Gonk: b83fc73de7b64594cd74b33e498bf08332b5d87b
Version: 40.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:40.0) Gecko/40.0 Firefox/40.0