1155517 - Change Reader View to have a "Save Page to Pocket" button instead of "Add To Reader List"

Status: VERIFIED FIXED

(Toolkit :: Reader Mode, defect, P2)

Description

[Justin Dolske [:Dolske]]

When viewing a page in Reader View, the user should have a button (in the Reader View toolbar) to "Save To Pocket" (wording TBD).

This will replace the "Add To Reading List" button on Desktop. Current plan is for Android to keep the long-existing Reading List button/feature, although we're still figuring out what Pocket integration means on Android.

If the user isn't signed in to Pocket, this should probably offer to create an FxA / signin, as with the toolbar button?

Comment 1

[Bryan Clark (DevTools PM) [:clarkbw]]

(In reply to Justin Dolske [:Dolske] from comment #0)
> If the user isn't signed in to Pocket, this should probably offer to create
> an FxA / signin, as with the toolbar button?

@mmaslaney: similarly, should we hide this button when a user isn't logged in?

Comment 2

[Michael Maslaney [:mmaslaney] ([e-mail])]

That, or we could have the button disabled accompanied by a tooltip encouraging you to create an account? 

In the spirit of shipping by June, let's suppress the feature if the user is not signed in, unless you feel like the previously mentioned is possible within our tight deadline.

Comment 3

[Bryan Clark (DevTools PM) [:clarkbw]]

We can continue to investigate other avenues for a short period of time, likely end of this week is the hard stop.  Suppress the feature seems to be the easiest way right now.

Comment 4

[Bryan Clark (DevTools PM) [:clarkbw]]

note this work is being done in bug 1155523

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Most of this work was completed in bug 1155523, but this bug will need to add the icon and string for the button. It is currently naked.

Comment 6

[Michael Maslaney [:mmaslaney] ([e-mail])]

Attachment: Pocket_ReaderView.zip

Jared, do these work out?

Comment 7

[Jared Wein [:jaws] (please needinfo? me)]

(In reply to Michael Maslaney [:mmaslaney] ([e-mail]) from comment #6)
> Jared, do these work out?

I think so, thanks!

Comment 8

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/d06d16029cad

Comment 10

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8604842 [details] [diff] [review]
Patch

Approval Request Comment
[Feature/regressing bug #]: pocket
[User impact if declined]: the toolbar icon on osx hidpi is the wrong dimensions
[Describe test coverage new/current, TreeHerder]: none, just graphic swap
[Risks and why]: none
[String/UUID change made/needed]: none

Comment 11

[Jared Wein [:jaws] (please needinfo? me)]

Approval Request Comment
[Feature/regressing bug #]: pocket
[User impact if declined]: the button to add to pocket from reader mode is blank
[Describe test coverage new/current, TreeHerder]: none, just adding a graphic
[Risks and why]: none
[String/UUID change made/needed]: none

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d06d16029cad

Comment 14

[Justin Dolske [:Dolske]]

Comment on attachment 8604842 [details] [diff] [review]
Patch

a+ for aurora/beta/release: required for Pocket launch in 38.0.5.

Comment 15

[Justin Dolske [:Dolske]]

(aurora currently closed)
https://hg.mozilla.org/releases/mozilla-beta/rev/87d07b3f416e
https://hg.mozilla.org/releases/mozilla-release/rev/921eb304600e

Comment 16

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/3c85481b4681

Comment 17

[Andrei Vaida [:avaida]]

Verified fixed on 38.0.5b2-build1 (20150514163436), using Ubuntu 14.04 (x64), Windows 7 (x64) and Mac OS X 10.9.5.

* The Pocket button available in Reader View brings up the sign-up panel if the user is not logged into Pocket.
* Clicking the Pocket button available in Reader View successfully saves the page to Pocket.
* If the Pocket add-on is already installed and used by default instead of the built-in one, Reader View will also hide the Pocket button from its controls bar.
* The Pocket button adapts properly to browser window and screen size, display resolution and zoom level.

The only thing that *might* be missing here is the button's tooltip.