1156114 - Incorrectly escaped regexp in browser/app/profile/firefox.js - warning preserving unexpected JS escape sequence: file modules/libpref/prefread.cpp, line 393

Status: RESOLVED FIXED

(Firefox :: Tours, defect)

Description

[Nickolay_Ponomarev]

In browser/app/profile/firefox.js:255 <http://hg.mozilla.org/mozilla-central/annotate/a32e3b93c8d8/browser/app/profile/firefox.js#l254>

> pref("browser.uitour.readerViewTrigger", "^https:\/\/www\.mozilla\.org\/[^\/]+\/firefox\/reading\/start");

(added in bug 1134501) triggers 9 warnings on a startup in a debug build:

WARNING: preserving unexpected JS escape sequence: file modules/libpref/prefread.cpp, line 393

Backslashes are supposed to be escaped in pref files. I'm guessing "https:\\/\\/" and so on, but I didn't test.

(a similar case was recently fixed in bug 1146097)

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch

Comment 2

[Jesse Ruderman]

Comment on attachment 8594547 [details] [diff] [review]
Patch

Review of attachment 8594547 [details] [diff] [review]:
-----------------------------------------------------------------

Looks right to me. I think it would also work with / in place of \\/, since you call the RegExp constructor rather than eval'ing a literal delimited by slashes.

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Thanks for the r+. I'll leave it as-is for now wrt the backslashes being necessary.

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/integration/fx-team/rev/6a29dd1152df

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6a29dd1152df