1157142 - support 'inline' and 'block' values for the orient attribute in <input type=range>, with 'inline' being the new default behavior

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, defect)

Description

[Jonathan Kew [:jfkthame]]

This will make the 'orient' attribute of <input type=range> similar to the -moz-orient property used by <progress> and <meter> (bug 1028716).

(Actually, 'inline' doesn't need any explicit support; it'll be the unmarked behavior.)

We can support both the logical (inline/block) and physical (horizontal/vertical) values for the attribute by updating forms.css to apply logical styling when the orientation is logically specified, and physical styling when it is physically specified.

This bug does not propose to address the discrepancy between how authors control orientation for <input type=range> (using an HTML attribute) vs the <progress> and <meter> elements (using a CSS property). Because of the desire to style parts of the <input> element in an orientation-aware way, it's not clear how best to handle this. In principle, I think moving <input type=range> to use the CSS property would be desirable, but that would be a more extensive and disruptive change that we should consider separately.

Comment 1

[Jonathan Kew [:jfkthame]]

Attachment: Support logical (inline/block) in addition to physical orientation for the <input type=range> element; make inline the default behavior so that range sliders respect writing mode

:jwatt, do you think this is a reasonable way forward here?

Comment 2

[Jonathan Kew [:jfkthame]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a4015ed4e6d4

Comment 3

[Jonathan Kew [:jfkthame]]

Attachment: Support logical (inline/block) in addition to physical orientation for the <input type=range> element; make inline the default behavior so that range sliders respect writing mode

Minor update to make horizontal sliders in vertical-rl mode advance from right to left.

Comment 4

[Jonathan Kew [:jfkthame]]

Attachment: Reftests for logical and physical orientation of <input type=range>

And here are some reftests to check that the new attribute values are behaving as expected.

Comment 5

[Jonathan Kew [:jfkthame]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1e7aa3504b29
https://hg.mozilla.org/integration/mozilla-inbound/rev/508b6bf16048

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/1e7aa3504b29
https://hg.mozilla.org/mozilla-central/rev/508b6bf16048