1157251 - Firefox for iOS (Build 8-9): incomplete for empty username/passwords

Status: RESOLVED FIXED

(Firefox for iOS :: Browser, defect)

Description

[Francesco Lodolo [:flod]]

Attachment: Authentication dialog

See screenshot: besides being in English while the string is localized, the username is missing

<source>Do you want to save the password for (MISSING) on website?

Comment 1

[Francesco Lodolo [:flod]]

Besides being consistently in English, the dialog seems a bit random.

Try to enter a password protected website using a username and blank password (there actually is one). 
At the bottom of the page I get a request to "save the password for USER on URL". When I finally get the Apache error page, the request becomes "save the password for USER on (EMPTY)".

Try to access without providing username and password, you get the incomplete dialog in the attachment (no username) when the Apache error page is displayed.

Comment 2

[Wesley Johnston (:wesj)]

Attachment: PR https://github.com/mozilla/firefox-ios/pull/414

I think maybe we shouldn't save empty usernames or passwords. That's what this does.

Comment 3

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Comment on attachment 8600522 [details] [review]
PR https://github.com/mozilla/firefox-ios/pull/414

Just a comment about a stray println() left in the code.

Comment 4

[Brian Nicholson (:bnicholson)]

Comment on attachment 8600522 [details] [review]
PR https://github.com/mozilla/firefox-ios/pull/414

I know that empty usernames/passwords are valid, so I don't know if not saving them is the best option. WFM if this is what Android/desktop do. If we're different, we should probably get UX approval for this change.

Comment 6

[Francesco Lodolo [:flod]]

This looks fixed in build 13, I don't get any request to save the password.

Amending subject, keeping bug 1157246 for the localizability issue (still present in build 13).