Closed Bug 1158194 Opened 5 years ago Closed 5 years ago

Use scoped styles to avoid conflicts between styles for reader view content and controls

Categories

(Firefox for Android :: Reader View, defect)

35 Branch
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 40
Tracking Status
firefox40 --- fixed

People

(Reporter: Margaret, Assigned: Margaret)

References

Details

Attachments

(2 files)

Follow-up to bug 1154028 for mobile.
I decided to `hg rm` these new empty files I added, so that in my next patch I can copy aboutReader.css before modifying it to make it easier to see changes to existing files (the same thing I did for the desktop in bug 1154028).
Attachment #8598226 - Flags: review?(gijskruitbosch+bugs)
I did a bunch of testing locally, and it looks like this all works as expected.
Attachment #8598230 - Flags: review?(gijskruitbosch+bugs)
Attachment #8598230 - Flags: review?(gijskruitbosch+bugs) → review+
Attachment #8598226 - Flags: review?(gijskruitbosch+bugs) → review+
We should have a followup bug to unify these with the desktop/toolkit ones.
(In reply to :Gijs Kruitbosch from comment #3)
> We should have a followup bug to unify these with the desktop/toolkit ones.

I think we can use bug 1153371 for that.

In the past, the UX team did want some purposefully different styles between desktop and mobile, but I agree that a lot of these content styles could really be the same.
https://hg.mozilla.org/mozilla-central/rev/f7f00a3feb76
https://hg.mozilla.org/mozilla-central/rev/03c06fb73542
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 40
You need to log in before you can comment on or make changes to this bug.