1158194 - Use scoped styles to avoid conflicts between styles for reader view content and controls

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Reader View, defect)

Description

[:Margaret Leibovic]

Follow-up to bug 1154028 for mobile.

Comment 1

[:Margaret Leibovic]

Attachment: (Part 1) Remove empty style files

I decided to `hg rm` these new empty files I added, so that in my next patch I can copy aboutReader.css before modifying it to make it easier to see changes to existing files (the same thing I did for the desktop in bug 1154028).

Comment 2

[:Margaret Leibovic]

Attachment: (Part 2) Split up mobile aboutReader.css into aboutReaderContent.css and aboutReaderControls.css

I did a bunch of testing locally, and it looks like this all works as expected.

Comment 3

[:Gijs (he/him)]

We should have a followup bug to unify these with the desktop/toolkit ones.

Comment 4

[:Margaret Leibovic]

(In reply to :Gijs Kruitbosch from comment #3)
> We should have a followup bug to unify these with the desktop/toolkit ones.

I think we can use bug 1153371 for that.

In the past, the UX team did want some purposefully different styles between desktop and mobile, but I agree that a lot of these content styles could really be the same.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/f7f00a3feb76
https://hg.mozilla.org/integration/fx-team/rev/03c06fb73542

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f7f00a3feb76
https://hg.mozilla.org/mozilla-central/rev/03c06fb73542