1158270 - Plugins can't run if e10s is force-disabled

Status: VERIFIED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Alice0775 White]

[Tracking Requested - why for this release]: regression

Though Flash plugin "always activate" in  about:addons,
Flash plugin is disabled,  fals to run.

Steps to reproduce:
1. Open non-e10s browser
2. Open http://www.adobe.com/software/flash/about/
     or any other page http://edition.cnn.com/videos
 
Actual results:
Flash plugin fails to run

Pushlog:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=4bae26d5e06f&tochange=19d97c221555
Regressed by:
19d97c221555	Brad Lassey — bug 1155976 - Loading plugins in a non-e10s window hangs the browser on Mac r=jimm

Comment 1

[Alice0775 White]

It failed if non-e10s window was opened from File menu.
However , it worked if e10s was disabled from option.

Comment 2

[Alice0775 White]

And Flash plugin also fails on Windows10TP and Windows8.1 because e10s was disabled (An accessibility tool is or was active) by default.

Comment 5

[:Felipe Gomes (needinfo for replies!)]

(In reply to Alice0775 White from comment #1)
> It failed if non-e10s window was opened from File menu.
> However , it worked if e10s was disabled from option.

This is intentional, the purpose of bug 1155976 is to disable plugins for "non-e10s windows" because they can't run at the same time on e10s and non-e10s windows.

(In reply to Alice0775 White from comment #2)
> And Flash plugin also fails on Windows10TP and Windows8.1 because e10s was
> disabled (An accessibility tool is or was active) by default.

This is a bug, currently any user with e10s force disabled (e.g. for Accessibility, lack of hardware accel, etc.) will have plugins disabled. I'll post a patch.

Comment 6

[:Felipe Gomes (needinfo for replies!)]

Attachment: Patch

Some of the prefs might be true but e10s can still be globally disabled because it was force disabled.

Comment 7

[laz2727]

Is it impossible to run two plugin containers for e10 and non-e10?

Comment 8

[:Felipe Gomes (needinfo for replies!)]

(In reply to laz2727 from comment #7)
> Is it impossible to run two plugin containers for e10 and non-e10?

Yeah, at the moment this is not properly supported, and we think fixing that would be harder than what's worth spending time, since this configuration (e10s and non-e10s at the same time) is not meant to exist in the long run.

Comment 9

[Jim Mathies [:jimm]]

(In reply to laz2727 from comment #7)
> Is it impossible to run two plugin containers for e10 and non-e10?

We have no plans to support something like this in release.

Comment 10

[Han Tacoma-Emons]

I had to revert to "firefox-35.0a1.en-US.win64-x86_64.installer" (the only one I have)  and turned off "Automatically install updates (recommended: improved security)", it is now set at "Check for updates, but let me choose whether to install them" whuch will be never until the Flash situation is resolved because at this level it works.

Comment 11

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/f43178fc99aa

Comment 12

[:Felipe Gomes (needinfo for replies!)]

(In reply to [e-mail] from comment #10)
> I had to revert to "firefox-35.0a1.en-US.win64-x86_64.installer" (the only
> one I have)  and turned off "Automatically install updates (recommended:
> improved security)", it is now set at "Check for updates, but let me choose
> whether to install them" whuch will be never until the Flash situation is
> resolved because at this level it works.

this should be fixed in the next Nightly

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f43178fc99aa

Comment 14

[Han Tacoma-Emons]

(In reply to :Felipe Gomes from comment #12)
> (In reply to [e-mail] from comment #10)
> > I had to revert to "firefox-35.0a1.en-US.win64-x86_64.installer" (the only
> > one I have)  and turned off "Automatically install updates (recommended:
> > improved security)", it is now set at "Check for updates, but let me choose
> > whether to install them" whuch will be never until the Flash situation is
> > resolved because at this level it works.
> 
> this should be fixed in the next Nightly

Applied "Nightly 40.1a1 20150427030207 Nightly" and Flash would not start.
Again reverted to 35.0a1

Comment 15

[Jim Jeffery not reading bug-mail 1/2/11]

(In reply to Han Tacoma-Emons from comment #14)
> (In reply to :Felipe Gomes from comment #12)
> > (In reply to [e-mail] from comment #10)
> > > I had to revert to "firefox-35.0a1.en-US.win64-x86_64.installer" (the only
> > > one I have)  and turned off "Automatically install updates (recommended:
> > > improved security)", it is now set at "Check for updates, but let me choose
> > > whether to install them" whuch will be never until the Flash situation is
> > > resolved because at this level it works.
> > 
> > this should be fixed in the next Nightly
> 
> Applied "Nightly 40.1a1 20150427030207 Nightly" and Flash would not start.
> Again reverted to 35.0a1

the fix did NOT make the Nightly, landed/merged too late, will be tomorrow now.

Comment 16

[Jim Mathies [:jimm]]

I'm in 40.0a1 (2015-04-27) and flash is loading for me in a non-e10s browser.

Comment 17

[Daniel Holbert [:dholbert]]

I(In reply to Jim Mathies [:jimm] from comment #16)
> I'm in 40.0a1 (2015-04-27) and flash is loading for me in a non-e10s browser.

I only hit this bug if flash is force-disabled *due to an a11y tool having been active* -- i.e. if flash is force-disabled via the pref "browser.tabs.remote.autostart.disabled-because-using-a11y"

(And I do hit it in current nightly, but not in latest inbound build.)

So I think comment 15 is correct.

Comment 18

[Daniel Holbert [:dholbert]]

(Re-posting my comment to correct a typo):
(In reply to Jim Mathies [:jimm] from comment #16)
> I'm in 40.0a1 (2015-04-27) and flash is loading for me in a non-e10s browser.

I only hit this bug if e10s is force-disabled *due to an a11y tool having been active* -- i.e. if e10s is force-disabled via the pref "browser.tabs.remote.autostart.disabled-because-using-a11y"

(And I do hit it in current nightly, but not in latest inbound build.)

So I think comment 15 is correct.

Comment 19

[Daniel Holbert [:dholbert]]

I verified that this is fixed in today's nightly.
 BROKEN: 40.0a1 (2015-04-27)
 FIXED: 40.0a1 (2015-04-28)

(Tested by setting the pref in comment 18 to true, in a fresh profile, and then trying to load http://homestarrunner.com/ in that profile.)

Clearing "tracking-firefox40" request, since this is fixed now.

Comment 20

[bartosz]

I verified too last update FF 40.0a1 (2015-04-29) repaired my Flash Player. (thanks)

But still can't enable E10S and see comment "Enable E10S (multi-process) (disabled: An accessibility tool is or was active. See bug 1115956.)".

Comment 21

[Daniel Holbert [:dholbert]]

Yup. As that message says, "see bug 1115956" (specifically bug 1115956 comment 12) if you see that message & want to enable e10s. :)

Comment 22

[Matt Cosentino]

I still get this when I open a new non-e10s window in the latest nightly build.

Comment 23

[:Felipe Gomes (needinfo for replies!)]

(In reply to Matt Cosentino from comment #22)
> I still get this when I open a new non-e10s window in the latest nightly
> build.

Yeah, this is intentional, plugins aren't supported in non-e10s windows. See comment 5 or 8 for the reason.