1158612 - Source Component widget in Call Tree

Status: RESOLVED WONTFIX

(DevTools :: Performance Tools (Profiler/Timeline), defect, P3)

Description

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Right not it is like this:

  <a>some-script.js</a>:12345

When it should be like this (the whole source location should be within the link):

  <a>some-script.js:12345</a>

Comment 1

[Jordan Santell [:jsantell] [@jsantell]]

Call Tree urls should be styled like other source urls: monospaced, all one link, all blue, cursor pointer. Should use .devtools-source-link class from bug 1167006

Comment 2

[Victor Porof [:vporof][:vp]]

Triaging. Filter on ADRENOCORTICOTROPIC (yes).

Comment 3

[agore1]

Hi i am interested in this bug. Can you please guide me ?

Thank you

Comment 4

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Sorry I don't have the time right now.

Comment 5

[Hubert B Manilla]

Attachment: 1158612wip.patch

Comment 6

[Hubert B Manilla]

Attachment: 1158612wip.patch

Quick feedback. Thanks!

Comment 7

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Comment on attachment 8767268 [details] [diff] [review]
1158612wip.patch

Review of attachment 8767268 [details] [diff] [review]:
-----------------------------------------------------------------

Hey Hubert!

I think this will make the line part of the link, but will lose the styling on line numbers. As an incremental interim improvement, I think we could take this if the styling is maintained.

However, I think the bug summary was changed by Jordan to mean that this should use the Frame component that we are using elsewhere now days. This is going to be a little more extensive change however, since that Frame component is a React component and the call tree doesn't use React yet.

Frame component: https://dxr.mozilla.org/mozilla-central/source/devtools/client/shared/components/frame.js#13
Example usage: https://dxr.mozilla.org/mozilla-central/source/devtools/client/performance/components/jit-optimizations-item.js#139

Comment 8

[Hubert B Manilla]

Hey nick,
Thanks(In reply to Nick Fitzgerald [:fitzgen] [⏰PDT; UTC-7] from comment #7)
> Comment on attachment 8767268 [details] [diff] [review]
> 1158612wip.patch
> 
> Review of attachment 8767268 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Hey Hubert!
> 
> I think this will make the line part of the link, but will lose the styling
> on line numbers. As an incremental interim improvement, I think we could
> take this if the styling is maintained.

Thanks! Ok will maintain styling.
> 
> However, I think the bug summary was changed by Jordan to mean that this
> should use the Frame component that we are using elsewhere now days. This is
> going to be a little more extensive change however, since that Frame
> component is a React component and the call tree doesn't use React yet.
> 
> Frame component:
> https://dxr.mozilla.org/mozilla-central/source/devtools/client/shared/
> components/frame.js#13
> Example usage:
> https://dxr.mozilla.org/mozilla-central/source/devtools/client/performance/
> components/jit-optimizations-item.js#139

Looking into to understand the details of this and get.

Comment 9

[Patrick Brosset <:pbro>]

[good first bug] whiteboard -> keyword mass change

Comment 10

[Greg Tatum [:gregtatum]]

Looks like the original need info was completed by other members of the team. If something else is needed feel free to need info me again.

Comment 11

[Luna Phipps-Costin]

agore1, are you still planning on working in this? Seeing as it's 11 months old, I'd like to work on it if you don't respond in a few days.

Thanks.

Comment 12

[Greg Tatum [:gregtatum]]

We won't be fixing this with moving to the new recording panel.