1158901 - Make tinderbox printline and other off-screen job data more discoverable

Status: VERIFIED FIXED

(Tree Management :: Treeherder, defect)

Description

[(No longer employed by Mozilla) Aaron Klotz]

In bug 913244, jmaher added the ability to upload the trace file from a failed xperf run. TBPL's UI would give us a handy link to that file.

Could we add that link to the treeherder UI?

Comment 1

[Jonathan Griffin (:jgriffin)]

Do we rely on TinderboxPrints for this in Treeherder?

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

actually this is displayed but way down on the list in the lefthand side of the popup display pane.  It was a lot easier to find this in tbpl- maybe we can do something here to make those hidden links more visible?

Comment 3

[(No longer employed by Mozilla) Aaron Klotz]

Here's an example. This failure:

https://treeherder.mozilla.org/logviewer.html#?job_id=2841963&repo=fx-team

uploaded an ETL file to this URL:

http://mozilla-releng-blobs.s3.amazonaws.com/blobs/Fx-Team-Non-PGO/sha512/6c7484ccbce1ce225a6ba2947b449026e6eee77667682880e81a3e94b6384f474ab135ef950efe0750d90af1d59e737e493626db0a88d16cd8a03c50a1f94e15

Comment 4

[(No longer employed by Mozilla) Aaron Klotz]

https://treeherder.mozilla.org/#/jobs?repo=fx-team&revision=7cecb4e23fcf&filter-searchStr=T%28x%29

Comment 5

[William Lachance (:wlach)]

It seems like the general complaint is that "artifact uploaded" field in the job pane in the summary view is not sufficiently obvious. Show we put this in the error summary?

Comment 6

[Joel Maher ( :jmaher ) (UTC -8)]

yeah, if we could get that in the error summary or make it easier in treeherder to know that there are links and data in that left hand side of the preview pane!

Comment 7

[Ed Morley [:emorley]]

I'm not sure the error summary is the right place for this - perhaps another tab in that panel?

Comment 8

[William Lachance (:wlach)]

We discussed this in the meeting. I believe we agreed that an "Extra info" (other name suggestions welcome) containing this information is the way to go.

Comment 9

[Jonathan French (:jfrench)]

I'll have a look at this and if I make progress I'll assign myself.

Comment 10

[Jonathan French (:jfrench)]

Attachment: extraInfoWip1

Current WIP for our 'Extra info' tab. Looking at it locally, imo I think we should consider having this printline data only in this tab; rather than leaving them also at the bottom of the job details panel (was discussed in the TH mtg today).

I think replicating the data would be kind of confusing to the user, and increases visual/comprehension workload.

I wonder if we can get away with moving 'Buildername' also to the tab. ie. Do sheriffs and users need to see it right away on job load?

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Comment on attachment 8600091 [details]
extraInfoWip1

Sounds good to me. I'd move the new tab to the end of the row of tabs (or at least not between the Failure Summary and Annotation tabs).

Comment 12

[Jonathan French (:jfrench)]

Sounds good. I'm also thinking we might rename this tab "Job info", or similar. I will muse on that some more while I work on a related discovery tweak.

Comment 13

[Jonathan French (:jfrench)]

Attachment: treeherder-ui-PR#508

Please see above PR for status and review. I want to do a bit more testing prior to merge.

Comment 14

[Cameron Dawson [:camd]]

Comment on attachment 8601580 [details] [review]
treeherder-ui-PR#508

This looks good to me.  As long as we still default to the "Failure Summary" tab first, which it looks like we do.

Comment 15

[Jonathan French (:jfrench)]

Correct, we still default to Failure Summary. Thanks camd, I will re-base and merge tomorrow. :)

Comment 16

[Jonathan French (:jfrench)]

Some discussions going on in the PR re: the details count, will hold off merging for now.

Comment 17

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder-ui

https://github.com/mozilla/treeherder-ui/commit/df43cb24a9790c8f140008ff6f3695216ab0d1df
Bug 1158901 - Make off-screen job details discoverable with a tab

Comment 18

[Jonathan French (:jfrench)]

Marking fixed per above merge. I will verify on the next push to stage/prod.

Comment 19

[Jonathan French (:jfrench)]

Verified fixed on stage.

Comment 20

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/d7bb591c8b67206a553e0b45ef7437b32a4c14d2
Bug 1158901 - Make off-screen job details discoverable with a tab