Closed Bug 1158982 Opened 8 years ago Closed 8 years ago

Using up/down keys moves overview graphs

Categories

(DevTools :: Performance Tools (Profiler/Timeline), defect, P2)

Product:
DevTools
Component:
Performance Tools (Profiler/Timeline)
Version:
37 Branch
Type:
defect

Tracking

(firefox40 verified, firefox41 verified)

Status:
VERIFIED FIXED
Milestone:
Firefox 41
Tracking Flags:
Tracking Status
firefox40 --- verified
firefox41 --- verified

People

(Reporter: jsantell, Assigned: vporof)

References

Details

(Whiteboard: [polish-backlog])

Attachments

(1 file)

v1
1.11 KB, patch
jsantell
: review+
Sylvestre
: approval-mozilla-aurora+
Details | Diff | Splinter Review 
When giving focus to an overview graph (can select, or just click one of the 3 overview graphs), and hitting up/down keys (waterfall or flamegraphs will cause the bug, calltree will not as the events are captured probably), the graph will move up and down by a few pixels, sliding out of view.
Assignee: nobody → vporof
Status: NEW → ASSIGNED
Priority: -- → P2
Attached patch v1 — — Splinter Review 
wat
Attachment #8611330 - Flags: review?(jsantell)
Comment on attachment 8611330 [details] [diff] [review]
v1

Review of attachment 8611330 [details] [diff] [review]:
-----------------------------------------------------------------

CSS ¯\_(ツ)_/¯
Attachment #8611330 - Flags: review?(jsantell) → review+
Blocks: perf-40-uplifts
Whiteboard: [devedition-40][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/2f0c78320bd5
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox41: --- → fixed
Resolution: --- → FIXED
Whiteboard: [devedition-40][fixed-in-fx-team] → [devedition-40]
Target Milestone: --- → Firefox 41
Comment on attachment 8611330 [details] [diff] [review]
v1


Approval Request Comment
[Feature/regressing bug #]: 1167252, the new performance tool
[User impact if declined]: The overview graphs move around a bit with the arrow keys
[Describe test coverage new/current, TreeHerder]: There are try pushes in Bug 1167252
[Risks and why]: CSS only so almost none - any risk is contained within devtools performance panel.
[String/UUID change made/needed]: None
Attachment #8611330 - Flags: approval-mozilla-aurora?
Attachment #8611330 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Whiteboard: [devedition-40] → [polish-backlog]
Reproduced the bug on Nightly 41.0a2 (2015-05-27), using the steps from Comment 0.

This is verified fixed on Firefox 41.0b1 and Firefox 40.0.2, using Windows 7 (x64).
Status: RESOLVED → VERIFIED
status-firefox40: fixed → verified
status-firefox41: fixed → verified
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.