1158982 - Using up/down keys moves overview graphs

Status: VERIFIED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), defect, P2)

Description

[Jordan Santell [:jsantell] [@jsantell]]

When giving focus to an overview graph (can select, or just click one of the 3 overview graphs), and hitting up/down keys (waterfall or flamegraphs will cause the bug, calltree will not as the events are captured probably), the graph will move up and down by a few pixels, sliding out of view.

Comment 2

[Jordan Santell [:jsantell] [@jsantell]]

From bug 1159446: https://bug1159446.bugzilla.mozilla.org/attachment.cgi?id=8598893

Comment 3

[Victor Porof [:vporof][:vp]]

Attachment: v1

wat

Comment 4

[Jordan Santell [:jsantell] [@jsantell]]

Comment on attachment 8611330 [details] [diff] [review]
v1

Review of attachment 8611330 [details] [diff] [review]:
-----------------------------------------------------------------

CSS ¯\_(ツ)_/¯

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/2f0c78320bd5

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2f0c78320bd5

Comment 7

[Brian Grinstead [:bgrins]]

Comment on attachment 8611330 [details] [diff] [review]
v1


Approval Request Comment
[Feature/regressing bug #]: 1167252, the new performance tool
[User impact if declined]: The overview graphs move around a bit with the arrow keys
[Describe test coverage new/current, TreeHerder]: There are try pushes in Bug 1167252
[Risks and why]: CSS only so almost none - any risk is contained within devtools performance panel.
[String/UUID change made/needed]: None

Comment 8

[Sylvestre Ledru [:Sylvestre]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/ea651e839495

Comment 9

[Andrei Vaida [:avaida]]

Reproduced the bug on Nightly 41.0a2 (2015-05-27), using the steps from Comment 0.

This is verified fixed on Firefox 41.0b1 and Firefox 40.0.2, using Windows 7 (x64).