Closed
Bug 1159209
Opened 9 years ago
Closed 9 years ago
Remove template parameters from socket I/O classes
Categories
(Firefox OS Graveyard :: General, defect)
Tracking
(firefox40 fixed)
RESOLVED
FIXED
2.2 S11 (1may)
Tracking | Status | |
---|---|---|
firefox40 | --- | fixed |
People
(Reporter: tzimmermann, Assigned: tzimmermann)
References
Details
Attachments
(5 files)
17.65 KB,
patch
|
qdot
:
review+
|
Details | Diff | Splinter Review |
8.00 KB,
patch
|
qdot
:
review+
|
Details | Diff | Splinter Review |
3.27 KB,
patch
|
qdot
:
review+
|
Details | Diff | Splinter Review |
10.16 KB,
patch
|
qdot
:
review+
|
Details | Diff | Splinter Review |
8.83 KB,
patch
|
qdot
:
review+
|
Details | Diff | Splinter Review |
Most of the socket I/O classes in ipc/unixsocket don't require templates. Most of the operations depend on the implementation of a single method. Virtual methods seem to solve this problem better.
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8598595 -
Flags: review?(kyle)
Assignee | ||
Comment 2•9 years ago
|
||
Attachment #8598596 -
Flags: review?(kyle)
Assignee | ||
Comment 3•9 years ago
|
||
Attachment #8598597 -
Flags: review?(kyle)
Assignee | ||
Comment 4•9 years ago
|
||
Attachment #8598599 -
Flags: review?(kyle)
Assignee | ||
Comment 5•9 years ago
|
||
Attachment #8598600 -
Flags: review?(kyle)
Assignee | ||
Comment 6•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c938685d7242
Updated•9 years ago
|
Attachment #8598595 -
Flags: review?(kyle) → review+
Updated•9 years ago
|
Attachment #8598596 -
Flags: review?(kyle) → review+
Updated•9 years ago
|
Attachment #8598597 -
Flags: review?(kyle) → review+
Updated•9 years ago
|
Attachment #8598599 -
Flags: review?(kyle) → review+
Updated•9 years ago
|
Attachment #8598600 -
Flags: review?(kyle) → review+
https://hg.mozilla.org/integration/b2g-inbound/rev/27561f4e4910 https://hg.mozilla.org/integration/b2g-inbound/rev/65cd149078f9 https://hg.mozilla.org/integration/b2g-inbound/rev/a2fe03686c0d https://hg.mozilla.org/integration/b2g-inbound/rev/3d372dd3a144 https://hg.mozilla.org/integration/b2g-inbound/rev/4a53afc1acbf
Assignee | ||
Comment 8•9 years ago
|
||
Thanks, Kyle! https://treeherder.mozilla.org/#/jobs?repo=b2g-inbound&revision=4a53afc1acbf
Comment 9•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/27561f4e4910 https://hg.mozilla.org/mozilla-central/rev/65cd149078f9 https://hg.mozilla.org/mozilla-central/rev/a2fe03686c0d https://hg.mozilla.org/mozilla-central/rev/3d372dd3a144 https://hg.mozilla.org/mozilla-central/rev/4a53afc1acbf
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 2.2 S11 (1may)
You need to log in
before you can comment on or make changes to this bug.
Description
•