1159209 - Remove template parameters from socket I/O classes

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Most of the socket I/O classes in ipc/unixsocket don't require templates. Most of the operations depend on the implementation of a single method. Virtual methods seem to solve this problem better.

Comment 1

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [01] Bug 1159209: Remove template parameters from |SocketIOEventRunnable|

Comment 2

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [02] Bug 1159209: Remove template parameters from |SocketIORequestClosingRunnable|

Comment 3

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [03] Bug 1159209: Remove template parameters from |SocketIODeleteInstanceRunnable|

Comment 4

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [04] Bug 1159209: Remove template parameters from |SocketIOShutdownTask|

Comment 5

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [05] Bug 1159209: Remove template parameters from |DataSocketIO|

Comment 6

[Thomas Zimmermann [:tzimmermann] [:tdz]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c938685d7242

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/27561f4e4910
https://hg.mozilla.org/integration/b2g-inbound/rev/65cd149078f9
https://hg.mozilla.org/integration/b2g-inbound/rev/a2fe03686c0d
https://hg.mozilla.org/integration/b2g-inbound/rev/3d372dd3a144
https://hg.mozilla.org/integration/b2g-inbound/rev/4a53afc1acbf

Comment 8

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Thanks, Kyle!

https://treeherder.mozilla.org/#/jobs?repo=b2g-inbound&revision=4a53afc1acbf

Comment 9

[Ryan VanderMeulen (PTO, back July 27)]

https://hg.mozilla.org/mozilla-central/rev/27561f4e4910
https://hg.mozilla.org/mozilla-central/rev/65cd149078f9
https://hg.mozilla.org/mozilla-central/rev/a2fe03686c0d
https://hg.mozilla.org/mozilla-central/rev/3d372dd3a144
https://hg.mozilla.org/mozilla-central/rev/4a53afc1acbf