Closed
Bug 1159371
Opened 9 years ago
Closed 9 years ago
Make --disable-compile-environment work with --enable-application=mobile/android
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox40 fixed)
RESOLVED
FIXED
mozilla40
Tracking | Status | |
---|---|---|
firefox40 | --- | fixed |
People
(Reporter: nalexander, Assigned: nalexander)
References
Details
Attachments
(2 files, 1 obsolete file)
Bug 1063880 made a complete |mach build| work with --disable-compile-environment on Linux (I guess). Bug 1140364 tracks an issue making |mach build| work on Mac OS X. This ticket tracks making |mach build| work (on Mac OS X, to start) when --enable-application=mobile/android is set. This is trickier than other situations because we're cross compiling. So we need to set enough "compilation" flags to know that host != target, but (eventually) not actually require a cross compiling toolchain. For now, I'll take requiring the cross compiling toolchain, since my use case is locally producing an omni.ja and downloading the Gecko native-code libraries.
Assignee | ||
Comment 1•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=354e8f1a46cf
Assignee | ||
Comment 2•9 years ago
|
||
/r/7783 - Bug 1159371 - Make --disable-compile-environment work with --enable-application=mobile/android. r=glandium /r/7785 - Bug 1159371 - Allow compiling sub-directories with --disable-compile-environment. r=glandium Pull down these commits: hg pull -r 354e8f1a46cffdc9fede3e15095931958cd472e0 https://reviewboard-hg.mozilla.org/gecko/
Attachment #8598812 -
Flags: review?(mh+mozilla)
Assignee | ||
Comment 3•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/dcd206152465 https://hg.mozilla.org/integration/fx-team/rev/3232d253cf90
Assignee | ||
Comment 4•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/675b389d52da https://hg.mozilla.org/integration/fx-team/rev/c732db3afd50
Assignee | ||
Comment 5•9 years ago
|
||
(In reply to Nick Alexander :nalexander from comment #4) > https://hg.mozilla.org/integration/fx-team/rev/675b389d52da > https://hg.mozilla.org/integration/fx-team/rev/c732db3afd50 I pushed this by accident. Sorry all.
Comment 6•9 years ago
|
||
https://reviewboard.mozilla.org/r/7783/#review6759 Ship It! ::: configure.in:372 (Diff revision 1) > + MOZ_CROSS_COMPILER You can spare yourself from requiring a host compiler and doing the related checks by replacing MOZ_CROSS_COMPILER with: CROSS_COMPILE=1 AC_DEFINE(CROSS_COMPILE) And afaics, that works (I got through a full --disable-compile-environment build)
Comment 7•9 years ago
|
||
https://reviewboard.mozilla.org/r/7785/#review6761 Ship It!
Assignee | ||
Comment 8•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/6e2943f56f2f https://hg.mozilla.org/integration/fx-team/rev/df9523258590
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → nalexander
Status: NEW → ASSIGNED
Comment 9•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/6e2943f56f2f https://hg.mozilla.org/mozilla-central/rev/df9523258590
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
Comment 10•9 years ago
|
||
Comment on attachment 8598812 [details]
MozReview Request: bz://1159371/nalexander
sigh mozreview
Attachment #8598812 -
Flags: review?(mh+mozilla)
Depends on: 1163077
Assignee | ||
Comment 11•9 years ago
|
||
Attachment #8598812 -
Attachment is obsolete: true
Assignee | ||
Comment 12•9 years ago
|
||
Assignee | ||
Comment 13•9 years ago
|
||
Depends on: 1180949
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•