Make --disable-compile-environment work with --enable-application=mobile/android

RESOLVED FIXED in Firefox 40

Status

()

Core
Build Config
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: nalexander, Assigned: nalexander)

Tracking

unspecified
mozilla40
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox40 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

3 years ago
Bug 1063880 made a complete |mach build| work with --disable-compile-environment on Linux (I guess).  Bug 1140364 tracks an issue making |mach build| work on Mac OS X.  This ticket tracks making |mach build| work (on Mac OS X, to start) when --enable-application=mobile/android is set.

This is trickier than other situations because we're cross compiling.  So we need to set enough "compilation" flags to know that host != target, but (eventually) not actually require a cross compiling toolchain.

For now, I'll take requiring the cross compiling toolchain, since my use case is locally producing an omni.ja and downloading the Gecko native-code libraries.
(Assignee)

Comment 1

3 years ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=354e8f1a46cf
(Assignee)

Comment 2

3 years ago
Created attachment 8598812 [details]
MozReview Request: bz://1159371/nalexander

/r/7783 - Bug 1159371 - Make --disable-compile-environment work with --enable-application=mobile/android. r=glandium
/r/7785 - Bug 1159371 - Allow compiling sub-directories with --disable-compile-environment. r=glandium

Pull down these commits:

hg pull -r 354e8f1a46cffdc9fede3e15095931958cd472e0 https://reviewboard-hg.mozilla.org/gecko/
Attachment #8598812 - Flags: review?(mh+mozilla)
(Assignee)

Comment 3

3 years ago
https://hg.mozilla.org/integration/fx-team/rev/dcd206152465
https://hg.mozilla.org/integration/fx-team/rev/3232d253cf90
(Assignee)

Comment 4

3 years ago
https://hg.mozilla.org/integration/fx-team/rev/675b389d52da
https://hg.mozilla.org/integration/fx-team/rev/c732db3afd50
(Assignee)

Comment 5

3 years ago
(In reply to Nick Alexander :nalexander from comment #4)
> https://hg.mozilla.org/integration/fx-team/rev/675b389d52da
> https://hg.mozilla.org/integration/fx-team/rev/c732db3afd50

I pushed this by accident.  Sorry all.
https://reviewboard.mozilla.org/r/7783/#review6759

Ship It!

::: configure.in:372
(Diff revision 1)
> +    MOZ_CROSS_COMPILER

You can spare yourself from requiring a host compiler and doing the related checks by replacing MOZ_CROSS_COMPILER with:
CROSS_COMPILE=1
AC_DEFINE(CROSS_COMPILE)

And afaics, that works (I got through a full --disable-compile-environment build)
https://reviewboard.mozilla.org/r/7785/#review6761

Ship It!
(Assignee)

Comment 8

3 years ago
https://hg.mozilla.org/integration/fx-team/rev/6e2943f56f2f
https://hg.mozilla.org/integration/fx-team/rev/df9523258590
(Assignee)

Updated

3 years ago
Assignee: nobody → nalexander
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/6e2943f56f2f
https://hg.mozilla.org/mozilla-central/rev/df9523258590
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox40: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
Comment on attachment 8598812 [details]
MozReview Request: bz://1159371/nalexander

sigh mozreview
Attachment #8598812 - Flags: review?(mh+mozilla)
Depends on: 1163077
(Assignee)

Comment 11

2 years ago
Comment on attachment 8598812 [details]
MozReview Request: bz://1159371/nalexander
Attachment #8598812 - Attachment is obsolete: true
(Assignee)

Comment 12

2 years ago
Created attachment 8620183 [details]
MozReview Request: Bug 1159371 - Allow compiling sub-directories with --disable-compile-environment. r=glandium
(Assignee)

Comment 13

2 years ago
Created attachment 8620184 [details]
MozReview Request: Bug 1159371 - Make --disable-compile-environment work with --enable-application=mobile/android. r=glandium
Depends on: 1180949
(Assignee)

Updated

2 years ago
Blocks: 1220476
You need to log in before you can comment on or make changes to this bug.