1159644 - [Dialer]The "Select all" is truncated when editing call logs.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Shared, defect)

Description

[Shine(Leave from Mozilla)]

Attachment: bn-IN_Select all.png

[1.Description]:
[Flame][v2.2][Dialer]Set device language to Bengali India, make a call and enter call log edit view, the "Select all" are truncated.
See attachment: bn-IN_Select all.png

[2.Testing Steps]: 
1. Insert SIM card into device and set device language to Bengali India
2. Open the Phone app and make a call
3. After ending the call, select the Call log tab to enter it
4. Selec the edit icon

[3.Expected Result]: 
4. The "Select all" should not be truncated.

[4.Actual Result]: 
4. The "Select all" is truncated.

[5.Reproduction build]: 
Device: Flame 2.1 user (Unaffected)
Build ID               20150428001200
Gaia Revision          bbe983b4e8bebfec26b3726b79568a22d667223c
Gaia Date              2015-04-09 13:52:48
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/5f2c57b580ff
Gecko Version          34.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150428.035731
Firmware Date          Tue Apr 28 03:57:42 EDT 2015
Bootloader             L1TC000118D0

Device: Flame 2.2 user (Affected)
Build ID               20150428002500
Gaia Revision          9f6b1b9082662ba2c14168fc66bb02b4df3141e5
Gaia Date              2015-04-27 20:41:33
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/e79c19bf19bf
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150428.042314
Firmware Date          Tue Apr 28 04:23:26 EDT 2015
Bootloader             L1TC000118D0

[6.Reproduction Frequency]: 
Always Recurrence,5/5

[7.TCID]: 
Free Test

Comment 1

[Elie]

Attachment: 2015-04-29-05-51-28.png

Set system language to Portuguese Brazil,this issue exist on flame 2.2
(NOT exist on Flame 2.1)
Refer to picture:2015-04-29-05-51-28.png
Flame 2.2 user:
Build ID               20150429002501
Gaia Revision          1b7aa7e60788668ed09abf76022dfa231dbe88d4
Gaia Date              2015-04-28 19:36:06
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/d38ff4717f39
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150429.040640
Firmware Date          Wed Apr 29 04:06:52 EDT 2015
Bootloader             L1TC000118D0

Comment 2

[Delphine Lebédel]

If I understand correctly, this should get fixed by Bug 1157173. Please verify once fix lands. thanks

Comment 3

[Delphine Lebédel]

Wrong bug! Please ignore comment 2, sorry for noise! Updating bug to reflect this

Comment 4

[GitHub Autolander Bot]

Attachment: [gaia] sfoster:editmode-button-padding-bug-1159644 > mozilla-b2g:master

Comment 5

[Sam Foster [:sfoster] (he/him)]

Attachment: edit-calllog-buttons-pt-BR.png

With patch applied to reduce side padding on buttons

Comment 6

[Sam Foster [:sfoster] (he/him)]

Comment on attachment 8600515 [details] [review]
[gaia] sfoster:editmode-button-padding-bug-1159644 > mozilla-b2g:master

Turns out these buttons use the shared/style/edit_mode.css stylesheet for their side padding. This patch corrects for the effect of bug 1010675 which changed the way these labels overflow. As the text is aligned center, I don't think we'll see any negative impact elsewhere.

Comment 7

[Kevin Grandon :kgrandon]

Comment on attachment 8600515 [details] [review]
[gaia] sfoster:editmode-button-padding-bug-1159644 > mozilla-b2g:master

Looks good to me. Normally I'd have Pavel look at this, but it seems simple enough that I think we can land this. Thanks!

Comment 8

[Sam Foster [:sfoster] (he/him)]

Moving to Shared component as the problem originates in a shared stylesheet - which is fixed in the patch.

Comment 9

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/2a69f30edc24be73bb276e3b03dcf2ebf6816bbb

Comment 11

[Shine(Leave from Mozilla)]

Attachment: Verify_Pass_3.0user_All languages.png

This problem are verified Pass on latest user build of Flame 3.0 in Spanish, Serbian Cyrillic, Serbian Latin, Russian, Bengali from India, Greek, Polish, Basque, Portuguese from Brazil, Portuguese from Portugal, Arabic languages.
See attachment: Verify_Pass_3.0user_All languages.png

Device: Flame 3.0 user (Pass)
Build ID               20150504160201
Gaia Revision          70077825aab2c7a79611befb40a5fe7e610d5443
Gaia Date              2015-05-04 18:09:33
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/102d0e9aa9e1
Gecko Version          40.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150504.191951
Firmware Date          Mon May  4 19:20:03 EDT 2015
Bootloader             L1TC000118D0

Comment 12

[Sam Foster [:sfoster] (he/him)]

Comment on attachment 8600515 [details] [review]
[gaia] sfoster:editmode-button-padding-bug-1159644 > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Edit-mode dialog buttons (Dialer)
[User impact] if declined: Button labels may be truncated and meaning unclear in some languages
[Testing completed]: Testing on device in multiple languages, verified on master
[Risk to taking this patch] (and alternatives if risky): Low risk, limited stylistic-only change
[String changes made]: None

Comment 13

[Sam Foster [:sfoster] (he/him)]

v2.2: https://github.com/mozilla-b2g/gaia/commit/24517ac3d802f31e91fcee9ac387589f978e6af3

Comment 14

[Shine(Leave from Mozilla)]

Attachment: Verify_Pass_2.2user_All languages_Select all.png

This problem are verified pass on latest Flame 2.2 user build in Spanish, Serbian Cyrillic, Serbian Latin, Russian, Bengali from India, Greek, Polish, Basque, Portuguese from Brazil, Portuguese from Portugal, Arabic languages.
See attachment: Verify_Pass_2.2user_All languages_Select all.png

Device: Flame 2.2 user (Pass)
Build ID               20150510002505
Gaia Revision          528ef60e7cda09ad43478065f5d33bda398fbeb7
Gaia Date              2015-05-08 23:40:58
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/8d04cc085cf5
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150510.043421
Firmware Date          Sun May 10 04:34:32 EDT 2015
Bootloader             L1TC000118D0