Closed
Bug 1160663
Opened 9 years ago
Closed 9 years ago
Allow hilighting the Pocket button via UITour
Categories
(Firefox :: Tours, defect)
Firefox
Tours
Tracking
()
RESOLVED
FIXED
Firefox 40
People
(Reporter: Dolske, Assigned: Dolske)
References
Details
Attachments
(1 file, 2 obsolete files)
3.63 KB,
patch
|
MattN
:
review+
Sylvestre
:
approval-mozilla-aurora+
Sylvestre
:
approval-mozilla-release+
|
Details | Diff | Splinter Review |
We're not currently planning to have a UITour for Pocket (at least in 38.0.5), but it's trivial to allow hilighting the button so we might as well do so anyway, just in case.
Attachment #8600484 -
Flags: review?(MattN+bmo)
Comment 1•9 years ago
|
||
Comment on attachment 8600484 [details] [diff] [review] Patch v.1 Review of attachment 8600484 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/components/uitour/UITour.jsm @@ +190,5 @@ > } > return loopBrowser.contentDocument.querySelector(".signin-link"); > }, > }], > + ["pocket", {query: "#pocket-button"}], If you want a tour to be able to automatically move it (back) to the nav-bar you also need to add the widgetName property.
Attachment #8600484 -
Flags: review?(MattN+bmo) → review+
Comment 2•9 years ago
|
||
Comment on attachment 8600484 [details] [diff] [review] Patch v.1 Review of attachment 8600484 [details] [diff] [review]: ----------------------------------------------------------------- Actually, I think you'll also need to update the available targets test or it will fail.
Assignee | ||
Comment 3•9 years ago
|
||
Untested test, need to apply 1155521 to check it out.
Attachment #8600484 -
Attachment is obsolete: true
Assignee | ||
Updated•9 years ago
|
Flags: needinfo?(dolske)
Comment 4•9 years ago
|
||
Comment on attachment 8600493 [details] [diff] [review] Patch v.2 Review of attachment 8600493 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/components/uitour/test/browser_UITour_availableTargets.js @@ +56,5 @@ > "help", > "home", > "loop", > "devtools", > + ...(hasPocket ? ["pocket"] : []) The test fails because you're missing commas on this line and the similar stuff below
Comment 5•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/377431f8f408
Attachment #8600493 -
Attachment is obsolete: true
Flags: needinfo?(dolske)
Attachment #8602402 -
Flags: review+
Updated•9 years ago
|
Status: NEW → ASSIGNED
status-firefox38.0.5:
--- → affected
status-firefox39:
--- → affected
status-firefox40:
--- → fixed
Comment 6•9 years ago
|
||
Comment on attachment 8602402 [details] [diff] [review] Patch v.3 Approval Request Comment [Feature/regressing bug #]: Pocket product page and snippets [User impact if declined]: No ability for Mozilla web content (including about:home) to annotate the Pocket button [Describe test coverage new/current, TreeHerder]: Updated b-c test [Risks and why]: Low risk UITour change that is isolated to tour code [String/UUID change made/needed]: None
Attachment #8602402 -
Flags: approval-mozilla-release?
Attachment #8602402 -
Flags: approval-mozilla-aurora?
Comment 7•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/377431f8f408
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 40
Updated•9 years ago
|
Attachment #8602402 -
Flags: approval-mozilla-release?
Attachment #8602402 -
Flags: approval-mozilla-release+
Attachment #8602402 -
Flags: approval-mozilla-aurora?
Attachment #8602402 -
Flags: approval-mozilla-aurora+
Assignee | ||
Comment 8•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/cefe398586cf https://hg.mozilla.org/releases/mozilla-release/rev/1701e22c91f6
Updated•9 years ago
|
QA Contact: andrei.vaida
You need to log in
before you can comment on or make changes to this bug.
Description
•