Closed Bug 1162759 Opened 9 years ago Closed 9 years ago

/whatsnew 38.0.5 (Pocket, Video) - Development

Categories

(www.mozilla.org :: Pages & Content, defect)

Product:
www.mozilla.org
Component:
Pages & Content
Version:
Production
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: ckprice, Assigned: agibson)

References

Details

(Whiteboard: [kb=1743593] [engagement-fxGrowth-2015]) 

This bug executes the development of the /whatsnew page for 38.0.5.

Design/copy done in bug 1162757.

Flows/specs detailed in
https://spring15.etherpad.mozilla.org/pocket-dev?

Target locales:
VIDEO LOCALES:
en-us
en-gb
de
pt-br
es-*
fr

POCKET LOCALES:
en-us
es-es
ru-ru
ja-jp
de-de
No longer depends on: 1161810
Depends on: 1161810
Assignee: nobody → agibson
Status: NEW → ASSIGNED
Whiteboard: [kb=1743593] [engagement-fxGrowth-2015]
Ok strings are in templates on demo2:

Video + Pocket:
https://www-demo2.allizom.org/en-US/firefox/38.0.5/whatsnew/

Pocket only:
https://www-demo2.allizom.org/ja/firefox/38.0.5/whatsnew/

Video only:
https://www-demo2.allizom.org/fr/firefox/38.0.5/whatsnew/

Designs/functionality still WIP.
Also please note the Firefox Hello video in these links is just placeholder until the spring campaign video is finished and uploaded to CDN.
I talked with Alex on IRC, but at this point I'm quite lost.

First issue: the whatsnew/firtstun page was scheduled for all locales, so we're still asking all locales to translate the template.
https://l10n.mozilla-community.org/~pascalc/langchecker/?locale=all&website=0&file=firefox/whatsnew_38.lang

I realized this morning that I missed bug 1135820 comment 6. It's not a huge page to translate, but still a waste of resources. Why aren't we showing that page for all locales, given the initial request?

Second issue: as comment 1 describes, we have 3 variants. Note that the campaign video is not es-*, nor is Pocket.

Video only:  en-GB, es-MX, fr 
Pocket only: ja, pt-BR
Video+Pocket: de, en-US, es-ES, ru

I assume "video only" is already covered by the current template (firefox/whatsnew_38.lang).

Either we create a new template (firefox/whatsnew_38_pocket.lang), duplicating the existing one and adding the 4 Pocket's strings, or we add the 4 strings to the existing template (that would impact es-MX and fr), and stop asking all locales to translate the file. I would go with the latter.
Flags: needinfo?(cprice)
(In reply to Francesco Lodolo [:flod] (UTC+2) from comment #4)
> I talked with Alex on IRC, but at this point I'm quite lost.
> 
> First issue: the whatsnew/firtstun page was scheduled for all locales, so
> we're still asking all locales to translate the template.
> https://l10n.mozilla-community.org/~pascalc/langchecker/
> ?locale=all&website=0&file=firefox/whatsnew_38.lang
> 
> I realized this morning that I missed bug 1135820 comment 6. It's not a huge
> page to translate, but still a waste of resources. Why aren't we showing
> that page for all locales, given the initial request?

Given that we no longer have translated content to show all locales for /whatsnew (video is only x locales, pocket even less), this is now the only real option. Firstrun is a different matter, nothing has changed there.

> Second issue: as comment 1 describes, we have 3 variants. Note that the
> campaign video is not es-*, nor is Pocket.
> 
> Video only:  en-GB, es-MX, fr 
> Pocket only: ja, pt-BR
> Video+Pocket: de, en-US, es-ES, ru

These video locales seem to change every time I ask :/ 

I'll update the current list I'm using here if the video is no longer es-*, thanks.

https://github.com/mozilla/bedrock/blob/8bc233da9c09e9dce84d6bb03ed7cfd53b06cae9/bedrock/firefox/views.py#L104-L117
 
> I assume "video only" is already covered by the current template
> (firefox/whatsnew_38.lang).
> 
> Either we create a new template (firefox/whatsnew_38_pocket.lang),
> duplicating the existing one and adding the 4 Pocket's strings, or we add
> the 4 strings to the existing template (that would impact es-MX and fr), and
> stop asking all locales to translate the file. I would go with the latter.

Both myself and Flod are discussing the best course of action here on IRC. Will update when we decide how best to handle the lang files.
As Alex pointed out I'm mixing /firstrun from /whatsnew. The former is still displayed for all locales, so most of the strings in that file are still needed and we need to keep tracking it.

That still leaves us with the problem of figuring out how to manage those 4 extra strings.

Solution A: add the strings to the existing lang file.
PRO: not many chances to break things.
CONS: strings will be exposed to all locales, and would create a bit of confusion about what Pocket is, why only some locales, etc.

Solution B: duplicate the content of firefox/whatsnew_38.lang as firefox/whatsnew_38_pocket.lang, add the 4 strings there, track the new template only for those locales.
PRO: we expose the strings only to the right locales.
CONS: we need to update /firstrun to include both files, and make sure things work as expected without funny surprises
https://github.com/mozilla/bedrock/pull/2932/files#diff-e968735b096944b3b2875134313af28eR5
The change to /firstrun would be needed to avoid keeping 2 files around for Pocket locales.

I reckon that B would be more complicated on our side, but also cleaner.
I realized that we also have a "Solution C". Since all Pocket locales will have a landing page for Pocket, we could load that file in whatsnew together with firefox/whatsnew_38.lang.

whatsnew_38/whatsnew-pocket-video.html
whatsnew_38/whatsnew-pocket.html

{% add_lang_files "firefox/whatsnew_38" "firefox/pocket" %}

We wouldn't need to touch firstrun, and we won't have 2 very similar lang files around.
(In reply to Francesco Lodolo [:flod] (UTC+2) from comment #7)
> I realized that we also have a "Solution C". Since all Pocket locales will
> have a landing page for Pocket, we could load that file in whatsnew together
> with firefox/whatsnew_38.lang.
> 
> whatsnew_38/whatsnew-pocket-video.html
> whatsnew_38/whatsnew-pocket.html
> 
> {% add_lang_files "firefox/whatsnew_38" "firefox/pocket" %}
> 
> We wouldn't need to touch firstrun, and we won't have 2 very similar lang
> files around.

This sounds good to me, it shall be so.
(In reply to Francesco Lodolo [:flod] (UTC+2) from comment #4)
> Video only:  en-GB, es-MX, fr 
> Pocket only: ja, pt-BR
> Video+Pocket: de, en-US, es-ES, ru

Trying to avoid spreading even more confusion from bad copy and paste on my side

Video only:  en-GB, es-MX, fr, pt-BR
Pocket only: ja, ru
Video+Pocket: de, en-US, es-ES
Thank you for breaking this down, Flod. Very helpful. I've also updated the specs here: https://spring15.etherpad.mozilla.org/pocket-dev
Pocket templates are now updated on demo2 to include the following lang files:

{% add_lang_files "firefox/whatsnew_38" "firefox/pocket" %}

I've also updated the list of locales as per Comment 9:

https://github.com/mozilla/bedrock/blob/bug-1136934-ff-38-1-whatsnew-pages/bedrock/firefox/views.py#L104-L114
Flags: needinfo?(cprice)
Ok strings and demo2 are now updated with the last minute headline change ("Pocket comes to Firefox!").

I haven't seen the final design yet, but for the string: 

"Sign in with your Firefox Account and you can save articles, videos and more to enjoy anytime, anywhere." 

I've wrapped using emphasis "<em>Sign in with your Firefox Account</em>", as most of the comps I've seen appear to format this text visually.
Updated comp with the design linked in Comment 13 is now on demo2

https://www-demo2.allizom.org/en-US/firefox/38.0.5/whatsnew/

This includes the super late, last minute, very final, last ever string change for the subheading that is now en-US only.
Pocket UITour code is now in on demo2:

https://www-demo2.allizom.org/en-US/firefox/38.0.5/whatsnew/

To test, make sure you have https://www-demo2.allizom.org listed in browser.uitour.testingOrigins

If the pocket icon is in the pallet, clicking "Try it now" should open the pocket menu. If the icon is not present, the button will go to a SUMO article (Note: URL is TBD, for now it is simply getpocket.com)
Testing is ongoing, however I wanted to drop a few notes of encouragement in the bug - so far everything looks correct.

> If the pocket icon is in the pallet, clicking "Try it now" should open the
> pocket menu. 

Pocket in the toolbar of Fx 38.0.5 correctly opens up the pocket menu.

> Pocket not in the menu - If the icon is not present, the button will go to a SUMO

Pocket not in the toolbar redirects to https://support.mozilla.org/en-US/kb/where-pocket-button-firefox

Non-Firefox browsers in OSX, Linux, Windows Vista (+versions above) - Chrome, Safari, IE redirect to https://www-demo2.allizom.org/en-US/firefox/new/
All localized campaign videos are now up on the demo server (plus video-poster image).
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.