1160696 - Tweak how Ion types are displayed in the JIT Opts pane

Status: RESOLVED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), defect)

Description

[Shu-yu Guo [:shu]]

Right now it's MIRType (Site), which is confusing. Change this to Site : MIRType, which is more in line with standard type decoration syntax across languages.

Comment 1

[Shu-yu Guo [:shu]]

Attachment: Display MIRTypes in the JIT optimizations side pane as "Site : MIRType".

Comment 2

[Jordan Santell [:jsantell] [@jsantell]]

Comment on attachment 8600560 [details] [diff] [review]
Display MIRTypes in the JIT optimizations side pane as "Site : MIRType".

Review of attachment 8600560 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good if there aren't any localization issues that are mentioned in the comment

::: browser/devtools/performance/views/jit-optimizations.js
@@ +249,5 @@
>     */
>  
>    _createIonNode: function (ionType) {
>      let node = document.createElement("span");
> +    node.textContent = `${ionType.site} : ${ionType.mirType}`;

This seems strange to have "site : type" -- would "site: type" make more sense? Obviously deferring to your judgement here. Also, would something like this need localized, or is this the standard way to do mir types, with regard to ":" placement?

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/78b5f6585c91

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/78b5f6585c91

Comment 5

[Brian Grinstead [:bgrins]]

Comment on attachment 8600560 [details] [diff] [review]
Display MIRTypes in the JIT optimizations side pane as "Site : MIRType".


Approval Request Comment
[Feature/regressing bug #]: 1167252, the new performance tool
[User impact if declined]: Won't ship the performance tool
[Describe test coverage new/current, TreeHerder]: There are try pushes in Bug 1167252 with all patches needing uplift
[Risks and why]: Requesting uplift for the accumulated changes in the performance tool since the 40 merge date, so these changes haven't had the full 6 weeks to bake.  Risks are generally contained within devtools, specifically within the performance panel.
[String/UUID change made/needed]: None

Comment 6

[Brian Grinstead [:bgrins]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/b78b5fac8645

Comment 7

[Brian Grinstead [:bgrins]]

Note: I had verbal confirmation for these uplifts from Sylvestre even before he's flagged them as a+.  See https://bugzilla.mozilla.org/show_bug.cgi?id=1167252#c26

Comment 8

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8600560 [details] [diff] [review]
Display MIRTypes in the JIT optimizations side pane as "Site : MIRType".

Change approved to skip one train as part of the spring campaign.