Closed
Bug 1160696
Opened 9 years ago
Closed 9 years ago
Tweak how Ion types are displayed in the JIT Opts pane
Categories
(DevTools :: Performance Tools (Profiler/Timeline), defect)
DevTools
Performance Tools (Profiler/Timeline)
Tracking
(firefox40 fixed, firefox41 fixed)
RESOLVED
FIXED
Firefox 41
People
(Reporter: shu, Assigned: shu)
References
Details
Attachments
(1 file)
2.09 KB,
patch
|
jsantell
:
review+
Sylvestre
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
Right now it's MIRType (Site), which is confusing. Change this to Site : MIRType, which is more in line with standard type decoration syntax across languages.
Assignee | ||
Comment 1•9 years ago
|
||
Assignee | ||
Updated•9 years ago
|
Attachment #8600560 -
Flags: review?(jsantell)
Comment 2•9 years ago
|
||
Comment on attachment 8600560 [details] [diff] [review] Display MIRTypes in the JIT optimizations side pane as "Site : MIRType". Review of attachment 8600560 [details] [diff] [review]: ----------------------------------------------------------------- Looks good if there aren't any localization issues that are mentioned in the comment ::: browser/devtools/performance/views/jit-optimizations.js @@ +249,5 @@ > */ > > _createIonNode: function (ionType) { > let node = document.createElement("span"); > + node.textContent = `${ionType.site} : ${ionType.mirType}`; This seems strange to have "site : type" -- would "site: type" make more sense? Obviously deferring to your judgement here. Also, would something like this need localized, or is this the standard way to do mir types, with regard to ":" placement?
Attachment #8600560 -
Flags: review?(jsantell) → review+
Updated•9 years ago
|
Assignee: nobody → shu
Status: NEW → ASSIGNED
Comment 4•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/78b5f6585c91
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox41:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
Updated•9 years ago
|
Blocks: perf-40-uplifts
Updated•9 years ago
|
Flags: qe-verify-
Comment 5•9 years ago
|
||
Comment on attachment 8600560 [details] [diff] [review] Display MIRTypes in the JIT optimizations side pane as "Site : MIRType". Approval Request Comment [Feature/regressing bug #]: 1167252, the new performance tool [User impact if declined]: Won't ship the performance tool [Describe test coverage new/current, TreeHerder]: There are try pushes in Bug 1167252 with all patches needing uplift [Risks and why]: Requesting uplift for the accumulated changes in the performance tool since the 40 merge date, so these changes haven't had the full 6 weeks to bake. Risks are generally contained within devtools, specifically within the performance panel. [String/UUID change made/needed]: None
Attachment #8600560 -
Flags: approval-mozilla-aurora?
Comment 6•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/b78b5fac8645
status-firefox40:
--- → fixed
Comment 7•9 years ago
|
||
Note: I had verbal confirmation for these uplifts from Sylvestre even before he's flagged them as a+. See https://bugzilla.mozilla.org/show_bug.cgi?id=1167252#c26
Comment 8•9 years ago
|
||
Comment on attachment 8600560 [details] [diff] [review] Display MIRTypes in the JIT optimizations side pane as "Site : MIRType". Change approved to skip one train as part of the spring campaign.
Attachment #8600560 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•