1160864 - The description field is not shown when editing a read-only container child in the Library

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[紫]

Attachment: description_textarea_missing_20150503.jpg

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:40.0) Gecko/20100101 Firefox/40.0
Build ID: 20150502030208

Steps to reproduce:

A test with a new profile has no effect.

Problem 1 'Editing a bookmark'
1. Click on a tag
2. Clcik on a bookmark in the bookmark list
3. Clcik on the 'more' botton

Further:
A switch from the Name 'Textfield' to the 'Description' textarea leads to 'undefined'.

Problem 2 'Add a new bookmark'
1. Right click on a folder and click on 'New Bookmark...'
2. In the 'New Bookmark' enter a name and switch to 'Location'


Actual results:

Firefox Version 40.0a1
Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:40.0) Gecko/20100101 Firefox/40.0

Problem 1 'Editing a bookmark'
As Result, the 'Description' textarea is not displayed. 
See Attchment description_textarea_missing_20150503

Problem 2 'Add a new bookmark'
As Result, the entered name is changed to 'undefined'. 
See Attchment new_bookmark_20150503


Expected results:

Firefox Version 31.6.0 ESR 
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Firefox/31.0
works fine.

Comment 1

[紫]

Attachment: new_bookmark_20150503.jpg

Comment 2

[紫]

Firefox Version 37.0.2
Mozilla/5.0 (Windows NT 6.3; rv:37.0) Gecko/20100101 Firefox/37.0
works fine.

Comment 3

[Alice0775 White]

[Tracking Requested - why for this release]:regression

Comment 4

[Marco Bonardo [:mak]]

The undefined issue is solved in bug 1159812, so what's left here is the missing Description field.

Comment 5

[Marco Bonardo [:mak]]

The problem only happens for bookmarks inside read-only containers, like tags or queries.

Comment 6

[Marco Bonardo [:mak]]

Attachment: patch v1

The heuristics we currently use look far more complicated than we need, and are not reliable (readOnly relies on tagsRow visibility but is used before such visibility is updated).
 did a bunch of testing in the Library and other panels and this seems to cover all the cases I tried so far. Maybe I'm missing some use-cases? Anything that jumps to your eyes?

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/1683f5135a1f

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/1683f5135a1f