Closed Bug 1160864 Opened 5 years ago Closed 5 years ago

The description field is not shown when editing a read-only container child in the Library

Categories

(Firefox :: Bookmarks & History, defect)

40 Branch
defect
Not set
Points:
1

Tracking

()

VERIFIED FIXED
Firefox 40
Iteration:
40.3 - 11 May
Tracking Status
firefox40 + verified

People

(Reporter: rgeisler, Assigned: mak)

References

Details

(Keywords: regression)

Attachments

(3 files)

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:40.0) Gecko/20100101 Firefox/40.0
Build ID: 20150502030208

Steps to reproduce:

A test with a new profile has no effect.

Problem 1 'Editing a bookmark'
1. Click on a tag
2. Clcik on a bookmark in the bookmark list
3. Clcik on the 'more' botton

Further:
A switch from the Name 'Textfield' to the 'Description' textarea leads to 'undefined'.

Problem 2 'Add a new bookmark'
1. Right click on a folder and click on 'New Bookmark...'
2. In the 'New Bookmark' enter a name and switch to 'Location'


Actual results:

Firefox Version 40.0a1
Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:40.0) Gecko/20100101 Firefox/40.0

Problem 1 'Editing a bookmark'
As Result, the 'Description' textarea is not displayed. 
See Attchment description_textarea_missing_20150503

Problem 2 'Add a new bookmark'
As Result, the entered name is changed to 'undefined'. 
See Attchment new_bookmark_20150503


Expected results:

Firefox Version 31.6.0 ESR 
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Firefox/31.0
works fine.
Firefox Version 37.0.2
Mozilla/5.0 (Windows NT 6.3; rv:37.0) Gecko/20100101 Firefox/37.0
works fine.
Summary: Various problems with the bookmark manager → Various minor problems with the bookmark manager
Component: Untriaged → Bookmarks & History
[Tracking Requested - why for this release]:regression
Blocks: 951651
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: regression
Depends on: 1160708
The undefined issue is solved in bug 1159812, so what's left here is the missing Description field.
Depends on: 1159812
No longer depends on: 1160708
Assignee: nobody → mak77
Status: NEW → ASSIGNED
Points: --- → 1
Flags: qe-verify-
Flags: firefox-backlog+
Summary: Various minor problems with the bookmark manager → The description field is not shown when editing an existing bookmark in the Library
Iteration: --- → 40.3 - 11 May
The problem only happens for bookmarks inside read-only containers, like tags or queries.
Summary: The description field is not shown when editing an existing bookmark in the Library → The description field is not shown when editing a read-only container child in the Library
Attached patch patch v1Splinter Review
The heuristics we currently use look far more complicated than we need, and are not reliable (readOnly relies on tagsRow visibility but is used before such visibility is updated).
 did a bunch of testing in the Library and other panels and this seems to cover all the cases I tried so far. Maybe I'm missing some use-cases? Anything that jumps to your eyes?
Attachment #8600945 - Flags: review?(mano)
https://hg.mozilla.org/mozilla-central/rev/1683f5135a1f
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 40
Depends on: 1163341
You need to log in before you can comment on or make changes to this bug.