Closed Bug 116114 Opened 18 years ago Closed 9 years ago

Links from Address Cards must have same behaviour as for links from MailNews

Categories

(SeaMonkey :: MailNews: Address Book & Contacts, enhancement)

x86
All
enhancement
Not set

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.1b2

People

(Reporter: BesTo, Assigned: philip.chee)

References

Details

(Keywords: dataloss)

Attachments

(4 files, 1 obsolete file)

Right-click on a link to choose "open in new windows" should be possible in a
card on the e-mail-list.

I make a attachment to explain which links I mean.
Attached image example

*** This bug has been marked as a duplicate of 64030 ***
Status: UNCONFIRMED → RESOLVED
Closed: 18 years ago
Resolution: --- → DUPLICATE
Verified duplicate.
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
> *** This bug has been marked as a duplicate of bug 64030 ***

The right-click issues from 64030 are not related.

Main goal of this one is to open links from the address cards without overwriting existing content. So they need to be opened in a new browser window or new tab. 

Links from MailNews are targeted according to the "Links from other applications" preference set in Tabbed Browsing. Additionally they watch Ctrl+Click, Middle-Click and Right-Click -> Context-Menu.

Links from Address Book should do the same.

Old summary: [RFE] right-click\"open in new window" should be possible on links in a card displayed in the e-mail-list
Severity: enhancement → normal
Status: VERIFIED → UNCONFIRMED
Keywords: dataloss
OS: Windows 98 → All
Resolution: DUPLICATE → ---
Summary: [RFE] right-click\"open in new window" should be possible on links in a card displayed in the e-mail-list → Links from Address Cards must have same behaviour as for links from MailNews
Status: UNCONFIRMED → NEW
Ever confirmed: true
Currently openLink(id) calls openTopWin() however it should call openUILink() instead now that we have this utility function.
Severity: normal → enhancement
Currently openLink(id) calls openTopWin() however it should call openAsExternal()


> -        <hbox style="min-width: 10ch; max-width: 10ch;">
> +        <hbox style="min-width: 10ch; max-width: 10ch; display: inline-block"> 

I got tired of getting this error message in the Error Console every time I tested this patch:

> Warning: XUL box for hbox element contained an inline img child, forcing all its children to be wrapped in a block.
> Source file: chrome://messenger/content/addressbook/addressbook.xul

So I decided to fix it here rather than in a separate bug/patch since it's a one liner.

>            <description class="CardViewLink" id="cvHomeWebPageBox">
> -            <html:a onclick="return openLink('cvHomeWebPage');" href="" id="cvHomeWebPage"/>
> +            <html:a onclick="return openLink(event);" href="" id="cvHomeWebPage"/>
>            </description>

I don't suppose it's worth while converting these to a text-link label + .textContent
Assignee: racham → philip.chee
Status: NEW → ASSIGNED
Attachment #497237 - Flags: feedback?(neil)
Comment on attachment 497237 [details] [diff] [review]
Proposed fix v1.0 use openAsExternal()

[Bah, this crashed my debug build. Filed bug 618792.]

>+        <hbox style="min-width: 10ch; max-width: 10ch; display: inline-block">
>           <spacer flex="1"/>
This is no good, because the spacers won't flex. (You can't tell with the default image because it's too big and has to shrink to fit anyway.) Maybe setting display: -moz-box on the img will work. (I haven't tried it.)
Attachment #497237 - Flags: feedback?(neil) → feedback+
Switching review to Neil as IanN seems MIA.

>>+        <hbox style="min-width: 10ch; max-width: 10ch; display: inline-block">
>>           <spacer flex="1"/>
> This is no good, because the spacers won't flex. (You can't tell with the
> default image because it's too big and has to shrink to fit anyway.) Maybe
> setting display: -moz-box on the img will work. (I haven't tried it.)

-moz-box didn't work or rather it did but I still got the "inline img child" warning. Putting inline-block on the html:img however worked in that the image is centred horizontally and the warning doesn't crop up.
Attachment #497237 - Attachment is obsolete: true
Attachment #497276 - Flags: review?(neil)
Attachment #497276 - Flags: feedback+
Comment on attachment 497276 [details] [diff] [review]
Patch v1.0a use inline-block on the img element instead. f=Neil

I'd prefer display: block; if it works.
Attachment #497276 - Flags: review?(neil) → review+
Pushed to comm-central:
http://hg.mozilla.org/comm-central/rev/83dfe09bf8ff

> I'd prefer display: block; if it works.
Yes. display: block; works.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago9 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1b2
Blocks: 543293
You need to log in before you can comment on or make changes to this bug.