1161704 - Pocket integration code spams terminal with "unreachable code" warnings at start-up

Status: RESOLVED DUPLICATE of bug 1161514

(Firefox :: Pocket, defect)

Description

[Daniel Holbert [:dholbert]]

STR:
 1. start a debug build
 2. Watch your terminal-spew (or check your Browser Console)

ACTUAL RESULTS: 
Two warnings for unreachable code in Pocket code:
{
JavaScript warning: chrome://browser/content/pocket/pktApi.js, line 325: SyntaxError: unreachable code after return statement
JavaScript warning: chrome://browser/content/pocket/main.js, line 379: SyntaxError: unreachable code after return statement
}

The first (pktApi.js) is a double return statement (the second statement, "return sendAction(action, options)", is unreachable):

http://hg.mozilla.org/mozilla-central/annotate/754579ec0e68/browser/components/pocket/pktApi.js#l296

The second (main.js) is a "return" statement with a bunch of logic after it:

http://hg.mozilla.org/mozilla-central/annotate/754579ec0e68/browser/components/pocket/main.js#l376

Comment 1

[Daniel Holbert [:dholbert]]

(I'm hitting this with current mozilla-inbound, FWIW.)

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

The first one should be fixed now. The second one should get fixed by 1160396. Not sure how you want to close/dupe this bug, or leave it open?

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

(The first one was fixed by bug 1161654.)

Comment 4

[Daniel Holbert [:dholbert]]

(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #2)
> The first one should be fixed now. The second one should get fixed by
> 1160396. Not sure how you want to close/dupe this bug, or leave it open?

Thanks! Duping WFM. (Bug 1160396 seems to be itself a dupe -- I'll dupe to its dupe-target, which is bug 1161514.)