Closed Bug 11620 Opened 21 years ago Closed 21 years ago

Form elments inside labels don't disable

Categories

(Core :: Layout: Form Controls, defect, P3)

defect

Tracking

()

VERIFIED FIXED

People

(Reporter: mikepinkerton, Assigned: rods)

References

Details

(Whiteboard: Fixed in my tree; waiting to checkin)

The code in nsLabelFrame::HandleEvent does this:

if (nsEventStatus_eConsumeNoDefault != aEventStatus) {
  mControlFrame->MouseClicked(&aPresContext);
}

there is no check for the state of the disabled attribute here. I tried just
putting in

if (nsEventStatus_eConsumeNoDefault != aEventStatus) {
  if ( !nsFormFrame::GetDisabled(mControlFrame) )
    mControlFrame->MouseClicked(&aPresContext);
}

but this didn't compile because mControlFrame is an nsFormControlFrame, not and
nsIFrame. Didn't know the right thing to do, so i just left it and opened the bug
;).
Blocks: 7310
Assignee: karnaze → kmcclusk
Reassigning to Kevin.
Assignee: kmcclusk → rods
Rod, since your working on the form  element disabling I'm reassigning to you.
Blocks: 11868
Whiteboard: Fixed in my tree; waiting to checkin
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Fixed.
QA Contact massive update.
Mike Pinkerton, would you like to verify this one ?
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.