1162140 - [User Story] Allow user to select a query from search suggestions in Awesome Bar

Status: VERIFIED FIXED

(Firefox :: Search, defect, P1)

Description

[Kev Needham [:kev]]

Allow user to select a query from a list of presented search suggestions.

Primary use case is selection for the purpose of executing a query against the default provider.

Secondary use cases can include what happens on hover/right-click/middle-click, etc., but those should probably be tracked separately.

Comment 1

[:shell escalante]

this was #2 when prioritizing user stories for the theme "suggestions"

Comment 2

[Stephen Horlander [:shorlander]]

Attachment: Select Search Suggest from Results — 01

Selecting a search suggest entry:

1) Type word or fragment into AwesomeBar
2) Get results from history intermixed with search suggest
3) Mouse over or arrow to desired result
4) Highlight result and append provider name to suggest; e.g. "— Yahoo! Search"
5) Select entry with mouse press or by hitting enter
6) Go to SAP

> Secondary use cases can include what happens on
> hover/right-click/middle-click, etc., but those should probably be tracked
> separately.

Onky two considerations here (that I can think of ATM):

1) Hover will append provider name
2) Ctrl/Command modifier  + Mouse, Middle-Click and Alt/Option + Enter select currently open a new tab from AwesomeBar results

Aside those I don't think we should tackle any kind of secondary behavior here right now. We can use follow-ups as needed.

Comment 3

[Stephen Horlander [:shorlander]]

Attachment: Select Search Suggest from Results — 01

Comment 4

[:shell escalante]

Hi Mak,

Have you had a chance to make progress on this bug?

Comment 5

[Marco Bonardo [:mak]]

I suppose the needinfo was for me :)
Just some brainstorming. On the other side, looks like bug 959594 is pretty much overlapping with this. So I will first feedback there, since I need to sync with Drew to avoid double work.

Also bug 959595 is overlapping with both, since once the result is shown there's not much to do to allow "selection" as requested here. The only thing left at that point is the presentation (append provider name when a row is selected), since we already handle middle-click/ctrl for awesomebar entries. I will look at that on Monday.

Comment 6

[Marco Bonardo [:mak]]

to support proper styling of these entries (that is, show Search With Engine only on the selected entry), we might need bug 1054800. I will know more after further investigation. Just annotating for now.

Comment 7

[Marco Bonardo [:mak]]

Stephen I have a couple questions for you:

1 - we are currently using the string "- Search with Engine Name" in the first action row. The reasoning for not using "Engine Search" is that some engine might already include the "search" word, in such a case we'd end up with (for example) "MSN Search Search" while "Search with MSN Search" works fine. Can I retain the current "Search With" string everywhere (both the first action row and suggestion rows) or do you have alternative suggestions?

2 - In the mockup you are not showing the "Search With" on the first action row. Should I assume the rule to hide "Search With" is valid not just for suggestions but for any search-like row? (the first row is preselected on typing so the action is still clear for the user)

Comment 8

[Marco Bonardo [:mak]]

My other problem is that it might not be trivial to implement "autofill" as in the mock-up for selected entries, so that the whole suggestion is copied into the locationbar input field. So, I'd leave that for future if possible, it might open a can of worms.

Comment 9

[Marco Bonardo [:mak]]

Attachment: WIP screenshot

this is what I have so far

Comment 10

[Marco Bonardo [:mak]]

Attachment: patch v1

Drew, you can apply this before your patch to get proper styling.
The only thing to do for adding search suggestions is invoking _addSearchEngineMatch like
this._addSearchEngineMatch(match, this._originalSearchString, suggestion);
where match should be built by PlacesSearchAutocompleteProvider.jsm

Comment 11

[Stephen Horlander [:shorlander]]

(In reply to Marco Bonardo [::mak] from comment #7)
> Stephen I have a couple questions for you:
> 
> 1 - we are currently using the string "- Search with Engine Name" in the
> first action row. The reasoning for not using "Engine Search" is that some
> engine might already include the "search" word, in such a case we'd end up
> with (for example) "MSN Search Search" while "Search with MSN Search" works
> fine. Can I retain the current "Search With" string everywhere (both the
> first action row and suggestion rows) or do you have alternative suggestions?

That makes sense. I am ok with using "— Search with <Engine Name>" everywhere. 

Although I don't think <Engine Search> would be too terrible since it seems that search engine names that end with search are not that common.

> 2 - In the mockup you are not showing the "Search With" on the first action
> row. Should I assume the rule to hide "Search With" is valid not just for
> suggestions but for any search-like row? (the first row is preselected on
> typing so the action is still clear for the user)

Yes. The magnifying glass is the "hey this is a search" indicator, and we would only add the action text to the item that is currently highlighted/selected.

Comment 12

[Drew Willcoxon :adw]

Comment on attachment 8617923 [details] [diff] [review]
patch v1

Review of attachment 8617923 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.

Comment 13

[Marco Bonardo [:mak]]

Comment on attachment 8617923 [details] [diff] [review]
patch v1

ok, now that I got Stephen's feedback let's make this a proper review.

Comment 14

[Drew Willcoxon :adw]

Comment on attachment 8617923 [details] [diff] [review]
patch v1

Review of attachment 8617923 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.  (Nothing to add to my previous f+.)

Comment 15

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/fba4dc82c929

Comment 16

[Pulsebot]

Backout:
https://hg.mozilla.org/integration/fx-team/rev/a3399f552e3b

Comment 17

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/e420871145cb

Comment 18

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/e420871145cb

Comment 19

[Petruta Horea [:phorea], Desktop QA]

Some of the issues (such as no suggestions when there are too many history items; pages deleted from history are still visible in awesome bar etc) initially found while verifying this bug are no longer reproducible on latest Nightly.

One issue (maybe) that still reproduces is:
- without entering anything in location bar, press the Down arrow key and then Enter -> the default search engine page is opened
- Press Down arrow again -> there are 2 options in the drop down, both covering the same link: "Visit <<link>>" and "Search - switch to tab"

Should I fill this? Thanks!

I'm marking this bug as verified on Nightly 42.0a1 as it was disabled on 41.0a2 Dev Edition. Will file a follow if needed.

Comment 20

[Marco Bonardo [:mak]]

(In reply to Petruta Rasa [QA] [:petruta] from comment #19)
> One issue (maybe) that still reproduces is:
> - without entering anything in location bar, press the Down arrow key and
> then Enter -> the default search engine page is opened

bug 1176437?
But the option doesn't do anything for me, it doesn't open the default search engine. Which OS was this on?

> - Press Down arrow again -> there are 2 options in the drop down, both
> covering the same link: "Visit <<link>>" and "Search - switch to tab"

Is the locationbar still empty? I cannot reproduce this. Likely cause I cannot reproduce opening the default search engine page at the first step? I'm interested in understanding why "switch to tab" appears, since it should never appear for an empty location bar.
Were all the options in Privacy / Locationbar at the default value? Was History enabled there?

Comment 21

[Petruta Horea [:phorea], Desktop QA]

Reproduced under OS X 10.9.5 and Win 7 64-bit using new profiles.

In previous build pressing once Down arrow was enough, now I see that it must be pressed twice to select the magnifying glass "Search with" first row.

The Visit link and "switch to tab" appear when pressing twice the Down arrow key, while on the same page (the location bar is not empty)

Maybe bug 1176437 will fix this too.

Comment 22

[Marco Bonardo [:mak]]

(In reply to Petruta Rasa [QA] [:petruta] from comment #21)
> Reproduced under OS X 10.9.5 and Win 7 64-bit using new profiles.
> 
> In previous build pressing once Down arrow was enough, now I see that it
> must be pressed twice to select the magnifying glass "Search with" first row.

This is wrong, if something regressed it we need to figure what. I cannot reproduce on Windows.
I open a new tab (this also focuses the locationbar) and press DOWN, the first entry (bogus) is selected, enter does nothing.

> The Visit link and "switch to tab" appear when pressing twice the Down arrow
> key, while on the same page (the location bar is not empty)

Ah yes, this is bug 555694, it was there already.

Comment 23

[Petruta Horea [:phorea], Desktop QA]

(In reply to Marco Bonardo [::mak] from comment #22)
> This is wrong, if something regressed it we need to figure what. I cannot
> reproduce on Windows.
> I open a new tab (this also focuses the locationbar) and press DOWN, the
> first entry (bogus) is selected, enter does nothing.

Could you please try no navigate between the dropdown items and press Enter only when the first row is selected and the magnifying glass is shown on location bar (http://i.imgur.com/xWFBWbV.png)

> > The Visit link and "switch to tab" appear when pressing twice the Down arrow
> > key, while on the same page (the location bar is not empty)
> 
> Ah yes, this is bug 555694, it was there already.

No we have the same link twice: http://i.imgur.com/XwIuDZB.png

Comment 24

[Marco Bonardo [:mak]]

(In reply to Petruta Rasa [QA] [:petruta] (PTO until 3rd August) from comment #23)
> Could you please try no navigate between the dropdown items and press Enter
> only when the first row is selected and the magnifying glass is shown on
> location bar (http://i.imgur.com/xWFBWbV.png)

I see, I think bug 1176437 will solve this.
 
> > > The Visit link and "switch to tab" appear when pressing twice the Down arrow
> > > key, while on the same page (the location bar is not empty)
> > 
> > Ah yes, this is bug 555694, it was there already.
> 
> No we have the same link twice: http://i.imgur.com/XwIuDZB.png

Yes, the switch to tab entry should not appear (bug 555694), the visit entry is expected.

Thank you for verifying this.

Comment 25

[Petruta Horea [:phorea], Desktop QA]

This is disabled in Firefox 41 so I'm removing the qe-verify+ flag.