1162274 - [Search] "Settings" in search suggestion dialog is not linked to the settings screen

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Search, defect)

Description

[Yeojin Chung [:YeojinC]]

Attachment: logcat_20150506_1449.txt

Description:
On Flame Master, the "Settings" on the search suggestion dialog is not highlighted and linked to the settings page.

Pre-requisite: Have an internet connection.

Repro Steps:
1) Update a Flame to 20150506010204.
2) Tap the rocketbar, and type in a few words.
3) Observe the dialog "Search suggestions are enabled. The characters you type when....."


Actual:
"Settings" at the end of the dialog is not highlighted and linked to the settings page.

Expected:
"Settings" at the end of the dialog is highlighted and linked to the settings page.

Environmental Variables:
Device: Flame 3.0 (KK, 319mb, full flash)
Build ID: 20150506010204
Gaia: 3e6fd1e0a478af2c95d09ce95c2c6de2de2fec14
Gecko: ba44099cbd07
Gonk: a9f3f8fb8b0844724de32426b7bcc4e6dc4fa2ed
Version: 40.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:40.0) Gecko/40.0 Firefox/40.0

Repro frequency: 7/7
See attached: screenshot, video clip, logcat
https://youtu.be/VAcALfQFpZk?t=24s

Comment 1

[Yeojin Chung [:YeojinC]]

This issue does NOT reproduce on Flame 2.2.

Result: "Settings" at the end of the dialog is highlighted and linked to the settings page.

Environmental Variables:
Device: Flame 2.2 (KK, 319mb, full flash)
Build ID: 20150506002501
Gaia: 772a9491909abd02dc67278dd453746e2dd358a8
Gecko: 3af6a0a79227
Gonk: ab265fb203390c70b8f2a054f38cf4b2f2dad70a
Version: 37.0 (2.2)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Comment 2

[Yeojin Chung [:YeojinC]]

Attachment: LinkToSettings.png

Comment 3

[Kevin Grandon :kgrandon]

Can we get a regression window here?

Comment 4

[KTucker [:KTucker][Inactive 3/4/2016]]

[Blocking Requested - why for this release]:

To my knowledge this has always worked so nominating this 3.0? since we regressed here.

Comment 5

[Yeojin Chung [:YeojinC]]

b2g-inbound Regression Window:

Last Working Environmental Variables:
Device: Flame 3.0
BuildID: 20150427103815
Gaia: e8f4231141210db01f43405e0c0336f480083ae7
Gecko: fce6aac57f06
Version: 40.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:40.0) Gecko/40.0 Firefox/40.0

First Broken Environmental Variables:
Device: Flame 3.0
BuildID: 20150427110514
Gaia: 5fd082cb265885248974fbb4ff70239901a6427e
Gecko: 0a66e85d0a42
Version: 40.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:40.0) Gecko/40.0 Firefox/40.0

Last Working Gaia First Broken Gecko: Issue does NOT reproduce 
Gaia: e8f4231141210db01f43405e0c0336f480083ae7
Gecko: 0a66e85d0a42

First Broken Gaia Last Working Gecko: Issue DOES reproduce
Gaia: 5fd082cb265885248974fbb4ff70239901a6427e
Gecko: fce6aac57f06

https://github.com/mozilla-b2g/gaia/compare/e8f4231141210db01f43405e0c0336f480083ae7...5fd082cb265885248974fbb4ff70239901a6427e


Caused by bug 1142526

Comment 6

[KTucker [:KTucker][Inactive 3/4/2016]]

Staś, can you take a look at this please? This might have been caused by the landing for bug 1142526.

Comment 7

[Zibi Braniecki [:zbraniecki][:gandalf]]

Not sure if it's related, but I noticed this in build log today:

[/build_stage/search/index.html: L10n Deprecation Warning: using innerHTML in translations is unsafe and will not be supported in future versions of l10n.js. See https://bugzil.la/1027117
]

(as a matter of fact there are two warnings like this, another for FTU).

Comment 8

[GitHub Autolander Bot]

Attachment: [gaia] stasm:1162274-settings-link > mozilla-b2g:master

Comment 9

[Staś Małolepszy :stas]

Comment on attachment 8602666 [details] [review]
[gaia] stasm:1162274-settings-link > mozilla-b2g:master

Thanks for flagging this.  It was caused by the fact that l10n.js doesn't allow the "id" attribute in translations any more.  The fix is to move the id to the source HTML.

Together with bug 1159906, this was the only instance of "id" or "class" used in translations in Gaia.

Comment 10

[Dale Harvey (:daleharvey)]

Comment on attachment 8602666 [details] [review]
[gaia] stasm:1162274-settings-link > mozilla-b2g:master

This looks good, thanks

Comment 11

[GitHub Autolander Bot]

https://github.com/mozilla-b2g/gaia/pull/29943

Autolander could not land the pull request due to not having collaborator rights. This is possibly due to a tree closure. Please check the tree status and request checkin again once the tree is open.

Comment 12

[GitHub Autolander Bot]

https://github.com/mozilla-b2g/gaia/pull/29943

Autolander could not land the pull request due to not having collaborator rights. This is possibly due to a tree closure. Please check the tree status and request checkin again once the tree is open.

Comment 13

[Kevin Grandon :kgrandon]

The tree was closed, but adding checkin-needed to trigger autolander again.

Comment 14

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/654fa15a768a4eb3738ce705f7b54f510e796cc1

Comment 15

[Yeojin Chung [:YeojinC]]

NI myself to verify the bug tomorrow and re-visit bug 1142313.

Comment 16

[Shally Li（leave from Mozilla）]

This bug has been verified as pass on latest Nightly build of Flame v3.0 and Nexus 5 v3.0 by the STR in Comment 0.

Actual results: The "Settings" word on the search suggestion dialog is highlighted and linked to the Settings page.
See attachment: verified_v3.0.mp4
Reproduce rate: 0/5

Device: Flame 3.0 build(Pass)
Build ID               20150510010201
Gaia Revision          5b2a150f6f5d29bddfaac13fcbbf099376f2f275
Gaia Date              2015-05-09 12:34:41
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/77d92f6d7679
Gecko Version          40.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150510.045933
Firmware Date          Sun May 10 04:59:44 EDT 2015
Bootloader             L1TC000118D0

Device: Nexus 5 v3.0 build (Pass)
Build ID               20150510010201
Gaia Revision          5b2a150f6f5d29bddfaac13fcbbf099376f2f275
Gaia Date              2015-05-09 12:34:41
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/77d92f6d7679
Gecko Version          40.0a1
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.cltbld.20150510.044405
Firmware Date          Sun May 10 04:44:24 EDT 2015
Bootloader             HHZ12f

Comment 17

[Shally Li（leave from Mozilla）]

Attachment: verified_v3.0.mp4