1162396 - Take bug 1140617 "Pasting an image loses the composition style" in TB38

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Jorg K (CEST = GMT+2)]

+++ This bug was initially created as a clone of Bug #1140617 +++

Consider taking bug 1140617 in THUNDERBIRD_38_VERBRANCH for Thunderbird 38.

Here is why:
Thunderbird up to now has a few quirks (to say it mildly) which confuse the user:
Inline spell checking losing the underlines - bug 1100966 (TB bug 1159817) and bug 1154791 (TB bug 1159815); Composition font being lost - bug 756984 (TB bug 1159834); Some problems with the composition font not being displayed on the font indicator, bug 1139524 (regression), bug 1148330 (regression), bug 1140105 (TB bug 1159923).

The really good news is: All of these are fixed now (pending landing of the last two mentioned).

This bug is another "losing font" bug, so it would be fantastic to include it as well. Since the excellent decision was taken to use a special M-C branch for the TB38 release, we should use it and take the opportunity to include this bug. It's really zero risk, since it's an approved one line change.

While I'm busily typing into the narrative here, the last bug to take on board to fix the last annoying quirk in the area would be bug 967494 which automatically fixes bug 717292. Bug 967494 is currently pending review.

Comment 1

[Jorg K (CEST = GMT+2)]

For your kind attention ;-)

Comment 2

[Massimo Fidanza]

Thank +Jorg K for taking on this! :-)

+1 from me

Comment 3

[rsx11m]

Why is a separate bug needed for Thunderbird 38.x integration? AFAICT, bug 1140617 attachment 8602382 [details] [diff] [review] affects editor/ only, thus should be automatically picked up *if* that patch lands on mozilla-esr38. Thus, you'd rather have to request branch approval for attachment 8602382 [details] [diff] [review] which has to include approval-mozilla-esr38? in this case.

Comment 4

[Jorg K (CEST = GMT+2)]

Nothing will land on mozilla38, no chance. We asked before for more important things and the answer has always been "no". Landing it on THUNDERBIRD_38_VERBRANCH is the way to go.

Comment 5

[Magnus Melin [:mkmelin]]

I don't think it's about importance but about risk. We should only take things on the thunderbird branch IF they get denied  m-c approval. Remember that bugs that affect editor are also affecting all the rich text editors on the web so it's not exactly good for firefox to keep them lingering for all their ESR users either. 

In this case it doesn't look very risky to me.

Comment 6

[Jorg K (CEST = GMT+2)]

The rich text editor is about 0.5% of FF's functionality, it's 50% of TB's functionality. Absolutely no one pastes images into FF.
As I said, I've asked for M-C approval before and it was rejected, this time I won't even bother.

Kent summed it up nicely in bug 1159815 comment #2:
... so that we can take bugs that are too risky for Firefox but important for Thunderbird users.

Comment 7

[Jorg K (CEST = GMT+2)]

s/functionality/user time spent/g

Comment 8

[Magnus Melin [:mkmelin]]

So are you saying you think it's a risky patch?

Comment 9

[Jorg K (CEST = GMT+2)]

No. It's a zero risk one line change. I was just quoting. I personally would say:
... so that we can take bugs that important for Thunderbird users but are unimportant to FF so that the FF people can't be bothered to do anything about them.

Look at bug 1042561 comment #89 (red addresses). Just because we poor sods have a 10 months release cycle they granted us landing the bug on mozilla38 which was in Aurora back then.

The autocomplete was so badly broken that an unsigned int was counted down below zero (resulting in a large positive number) and the whole thing just worked by accident in FF. Yet they were not keen to ship a decent fix on mozilla38 and only did because we asked.

Nothing will get accepted into mozilla38 now. Trust me, I've been playing this game for months now and my request to put stuff into mozilla38 was rejected all but once. That's why having our own release branch was a fantastic decision because we can clean up the mess now and not wait for TB40 or TB45.

Comment 10

[Jorg K (CEST = GMT+2)]

Patch received review+ in the other bug 1140617, so it's ready to go.

Comment 11

[Kent James (:rkent)]

"ready to go" would be landed on mozilla-central, not simply reviewed.

Comment 12

[Jorg K (CEST = GMT+2)]

"ready to go" according to Kent's definition ;-)

Comment 13

[Kent James (:rkent)]

a=rkent to take the following patch in the THUNDERBIRD_38_VERBRANCH:

https://hg.mozilla.org/mozilla-central/rev/9bbb797f3e28

Landed as: http://hg.mozilla.org/releases/mozilla-esr38/rev/f88e5322f5d3

Comment 14

[Jorg K (CEST = GMT+2)]

The has so far only landed on mozilla41, I requested aurora inclusion for mozilla40.

Comment 15

[Kent James (:rkent)]

I am not concerned with Mozilla 39 and 40, this is now landed on the branch we are planning to use for TB 38.

You might checkout the builds here, which should include the patch in a TB 38 beta:
https://treeherder.mozilla.org/#/jobs?repo=comm-beta&revision=db5fd57ab6d2