[Stingray] smart-bubbles web component should also support sinking animation

RESOLVED FIXED

Status

Firefox OS
Gaia::TV
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: dwi2, Assigned: dwi2)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
We only have bubble-up animation in smart-bubbles. We also need 'sinking animation' in card filter case.
(Assignee)

Updated

3 years ago
Assignee: nobody → tzhuang
Status: NEW → ASSIGNED
(Assignee)

Comment 1

3 years ago
Created attachment 8603290 [details] [review]
pull request

Hi John,

Please help to review the patch. Thanks
Attachment #8603290 - Flags: review?(im)
Comment on attachment 8603290 [details] [review]
pull request

looks good to me.
Attachment #8603290 - Flags: review?(im) → review+
(Assignee)

Comment 3

3 years ago
Thanks.

Landed on smart-bubbles/master
https://github.com/smart-components/smart-bubbles/commit/afc1ee8602626e712580076839648bc83074bf16
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
(Assignee)

Updated

3 years ago
Blocks: 1163535
(Assignee)

Updated

3 years ago
Blocks: 1163538
(Assignee)

Updated

3 years ago
Blocks: 1163977
You need to log in before you can comment on or make changes to this bug.